Skip to content

Commit 2a14fe0

Browse files
committed
Refactor tag selection code
1 parent e9b1b93 commit 2a14fe0

File tree

1 file changed

+3
-18
lines changed

1 file changed

+3
-18
lines changed

exasol/toolbox/sphinx/multiversion/sphinx.py

Lines changed: 3 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -72,15 +72,6 @@ def version(self):
7272
def version_triple(self):
7373
return self._version_tripple
7474

75-
@staticmethod
76-
def is_valid_tag(tag):
77-
try:
78-
ExasolVersionTag(tag)
79-
except TagFormatError as ex:
80-
logger.warn("%s", ex)
81-
return False
82-
return True
83-
8475

8576
class VersionInfo:
8677
def __init__(self, app, context, metadata, current_version_name):
@@ -136,16 +127,10 @@ def in_development(self):
136127
]
137128

138129
def __iter__(self):
139-
tags = (
140-
ExasolVersionTag(tag)
141-
for tag in self.tags
142-
if ExasolVersionTag.is_valid_tag(tag)
143-
)
144130
yield from self.branches
145-
yield from [
146-
t.version
147-
for t in sorted(tags, key=lambda t: t.version_triple, reverse=True)
148-
]
131+
yield from sorted(
132+
self.tags, key=lambda t: ExasolVersionTag(t).version_triple, reverse=True
133+
)
149134

150135
def __getitem__(self, name):
151136
v = self.metadata.get(name)

0 commit comments

Comments
 (0)