Skip to content

Commit 2b6585b

Browse files
Nicorettickunki
andauthored
Fix multiversion build (#279)
--------- Co-authored-by: Christoph Kuhnke <[email protected]>
1 parent 70456d8 commit 2b6585b

File tree

3 files changed

+24
-7
lines changed

3 files changed

+24
-7
lines changed

doc/changes/unreleased.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33
## 🐞 Fixed
44

55
* Fixed the issue with publishing new documentation after releasing a new version
6+
* Fixed the issue where master/main was not part of the multiversion documentation
7+
68
## ✨ Added
79

810
* #149: Added nox task to lint imports

exasol/toolbox/sphinx/multiversion/main.py

Lines changed: 21 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ def load_sphinx_config_worker(q, confpath, confoverrides, add_defaults):
5959
)
6060
current_config.add(
6161
"smv_branch_whitelist",
62-
sphinx.DEFAULT_TAG_WHITELIST,
62+
sphinx.DEFAULT_BRANCH_WHITELIST,
6363
"html",
6464
str,
6565
)
@@ -228,6 +228,11 @@ def _create_parser():
228228
action="store_true",
229229
help="dump generated metadata and exit",
230230
)
231+
parser.add_argument(
232+
"--debug",
233+
action="store_true",
234+
help="enable debug mode with increased log verbosity, etc."
235+
)
231236
return parser
232237

233238

@@ -247,6 +252,8 @@ def main(argv=None):
247252

248253

249254
def _main(args, argv):
255+
if args.debug:
256+
logger.setLevel(logging.DEBUG)
250257
sourcedir_absolute = os.path.abspath(args.sourcedir)
251258
confdir_absolute = (
252259
os.path.abspath(args.confdir)
@@ -279,13 +286,13 @@ def _main(args, argv):
279286
conffile = os.path.join(confdir, "conf.py")
280287

281288
# Get git references
282-
gitrefs = git.get_refs(
289+
gitrefs = list(git.get_refs(
283290
str(gitroot),
284291
config.smv_tag_whitelist,
285292
config.smv_branch_whitelist,
286293
config.smv_remote_whitelist,
287294
files=(sourcedir, conffile),
288-
)
295+
))
289296

290297
# Order git refs
291298
if config.smv_prefer_remote_refs:
@@ -574,14 +581,22 @@ def _main(args, argv):
574581
with open(
575582
os.path.join(args.outputdir, "index.html"), "w", encoding="utf-8"
576583
) as f:
577-
versions = [
584+
logger.debug("Picked up Git references: %s", [ref.name for ref in gitrefs])
585+
tag_versions = [
578586
ref.name
579587
for ref in gitrefs
580588
if re.match(config.smv_tag_whitelist, ref.name)
581589
]
582-
versions = sorted(
583-
versions, key=lambda v: ExasolVersion.from_string(v), reverse=True
590+
tag_versions = sorted(
591+
tag_versions, key=lambda v: ExasolVersion.from_string(v), reverse=True
584592
)
593+
branches = [
594+
ref.name
595+
for ref in gitrefs
596+
if re.match(config.smv_branch_whitelist, ref.name)
597+
]
598+
versions = branches + tag_versions
599+
logger.debug("Selected versions for documentation: %s", versions)
585600
f.write(template.render(version=versions[0]))
586601

587602
return 0

exasol/toolbox/sphinx/multiversion/sphinx.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
DATE_FMT = "%Y-%m-%d %H:%M:%S %z"
1818
DEFAULT_TAG_WHITELIST = r"^(0|[1-9]\d*)\.(0|[1-9]\d*)\.(0|[1-9]\d*)$"
19-
DEFAULT_BRANCH_WHITELIST = r"master|main"
19+
DEFAULT_BRANCH_WHITELIST = r"^(master|main)"
2020
DEFAULT_REMOTE_WHITELIST = None
2121
DEFAULT_RELEASED_PATTERN = r"^tags/.*$"
2222
DEFAULT_OUTPUTDIR_FORMAT = r"{ref.name}"

0 commit comments

Comments
 (0)