resolve conversation

Author: Jannis-Mittenzwei

.github/workflows/report.yml

@@ -31,6 +31,7 @@ jobs:
         working-directory: ./artifacts
         run: |
           poetry run coverage combine --keep coverage-python3.9*/.coverage
+          # Errors during copying are ignored because they are checked in the next step
           cp .coverage ../ || true
           cp lint-python3.9/.lint.txt ../ || true
           cp lint-python3.9/.lint.json ../ || true

exasol/toolbox/templates/github/workflows/report.yml

@@ -31,6 +31,7 @@ jobs:
         working-directory: ./artifacts
         run: |
           poetry run coverage combine --keep coverage-python3.9*/.coverage
+          # Errors during copying are ignored because they are checked in the next step
           cp .coverage ../ || true
           cp lint-python3.9/.lint.txt ../ || true
           cp lint-python3.9/.lint.txt ../ || true

exasol/toolbox/tools/lint.py

@@ -10,7 +10,7 @@
 
 
 @dataclass(frozen=True)
-class LintIssue:
+class Finding:
     type: str
     module: str
     obj: str
@@ -24,10 +24,10 @@ class LintIssue:
     message_id: str
 
 
-def lint_issue_from_json(data: str) -> Iterable[LintIssue]:
+def lint_issue_from_json(data: str) -> Iterable[Finding]:
     issues = json.loads(data)
     for issue in issues:
-        yield LintIssue(
+        yield Finding(
             type=issue["type"],
             module=issue["module"],
             obj=issue["obj"],
@@ -42,20 +42,20 @@ def lint_issue_from_json(data: str) -> Iterable[LintIssue]:
         )
 
 
-def lint_issue_to_markdown(lint_issues: Iterable[LintIssue]) -> str:
+def lint_issue_to_markdown(lint_issues: Iterable[Finding]) -> str:
     def _header() -> str:
         header = "# Static Code Analysis\n\n"
         header += "|File|line/<br>column|id|message|\n"
         header += "|---|:-:|:-:|---|\n"
         return header
 
-    def _rows(issues: Iterable[LintIssue]) -> str:
+    def _rows(findings: Iterable[Finding]) -> str:
         rows = ""
-        for issue in issues:
-            rows += f"|{issue.path}"
-            rows += f"|line: {issue.line}/<br>column: {issue.column}"
-            rows += f"|{issue.message_id}"
-            rows += f"|{issue.message}|\n"
+        for finding in findings:
+            rows += f"|{finding.path}"
+            rows += f"|line: {finding.line}/<br>column: {finding.column}"
+            rows += f"|{finding.message_id}"
+            rows += f"|{finding.message}|\n"
         return rows
 
     template = cleandoc(

test/unit/lint_test.py

@@ -25,7 +25,7 @@
 )
 def test_lint_issue_from_json(data):
     actual = lint.lint_issue_from_json(json.dumps([data]))
-    expected = lint.LintIssue(
+    expected = lint.Finding(
         type=data["type"],
         module=data["module"],
         obj=data["obj"],
@@ -68,7 +68,7 @@ def test_lint_issue_from_json(data):
     ],
 )
 def test_lint_issue_to_markdown(data, expected):
-    issue = lint.LintIssue(
+    issue = lint.Finding(
         type=data["type"],
         module=data["module"],
         obj=data["obj"],