resolves the conversations

Author: Jannis-Mittenzwei

exasol/toolbox/nox/_dependencies_check.py

@@ -16,9 +16,8 @@ def dependency_check(session: Session) -> None:
     content = Path(PROJECT_CONFIG.root, "pyproject.toml").read_text()
     dependencies = Dependencies(content).parse()
     console = rich.console.Console()
-    illegal = dependencies.illegal()
-    report_illegal(illegal, console)
-    if illegal:
+    if illegal := dependencies.illegal:
+        report_illegal(illegal, console)
         sys.exit(1)
 
 
@@ -66,19 +65,17 @@ def extract_dependencies(section) -> List[str]:
         self.illegal_dict = illegal
         return self
 
+    @property
     def illegal(self) -> Dict[str, List[str]]:
         return self.illegal_dict
 
 
 def report_illegal(illegal: Dict[str, List[str]], console: rich.console.Console):
-    if illegal:
-        count = sum(len(deps) for deps in illegal.values())
-        suffix = "y" if count == 1 else "ies"
-        console.print(f"{count} illegal dependenc{suffix}\n", style="red")
-        for section, dependencies in illegal.items():
-            console.print(f"\\[{section}]", style="red")
-            for dependency in dependencies:
-                console.print(dependency, style="red")
-            console.print("")
-    else:
-        console.print("Success: All dependencies refer to explicit pipy releases.", style="green")
+    count = sum(len(deps) for deps in illegal.values())
+    suffix = "y" if count == 1 else "ies"
+    console.print(f"{count} illegal dependenc{suffix}\n", style="red")
+    for section, dependencies in illegal.items():
+        console.print(f"\\[{section}]", style="red")
+        for dependency in dependencies:
+            console.print(dependency, style="red")
+        console.print("")

test/unit/dependencies_check_test.py

@@ -96,7 +96,7 @@
 )
 def test_dependency_check_parse(toml, expected):
     dependencies = Dependencies(toml).parse()
-    assert dependencies.illegal() == expected
+    assert dependencies.illegal == expected
 
 
 @pytest.mark.parametrize(
@@ -136,29 +136,12 @@ def test_dependency_check_parse(toml, expected):
 example-path1 = {'path': '../my-package/dist/my-package-0.1.0.tar.gz'}
 example-path2 = {'path': '../my-package/dist/my-package-0.2.0.tar.gz'}
 
-"""
-        ),
-        (
-            """
-[tool.poetry.dependencies]
-python = "^3.8"
-
-[tool.poetry.dev.dependencies]
-nox = ">=2022.8.7"
-
-[tool.poetry.group.test.dependencies]
-sphinx = ">=5.3,<8"
-
-[tool.poetry.group.dev.dependencies]
-pytest = ">=7.2.2,<9"
-            """,
-            """Success: All dependencies refer to explicit pipy releases.
 """
         ),
     ]
 )
 def test_dependencies_check_report(toml, expected, capsys):
     console = rich.console.Console()
     dependencies = Dependencies(toml).parse()
-    report_illegal(dependencies.illegal(), console)
+    report_illegal(dependencies.illegal, console)
     assert capsys.readouterr().out == expected