Skip to content

Commit 5fa089b

Browse files
committed
Update pull_request_template
1 parent 8df35e1 commit 5fa089b

File tree

5 files changed

+58
-23
lines changed

5 files changed

+58
-23
lines changed

.github/PULL_REQUEST_TEMPLATE/pull_request_template.md

Lines changed: 0 additions & 7 deletions
This file was deleted.

.github/pull_request_template.md

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
# Checklist
2+
3+
Note: If any of the items in the checklist are not relevant to your PR, just check the box.
4+
5+
## For any Pull Request
6+
7+
Is the following correct:
8+
* [ ] the title of the Pull Request?
9+
* [ ] the title of the corresponding issue?
10+
* [ ] there are no other open [Pull Requests](../../../../pulls) for the same update/change? <!-- markdown-link-check-disable-line -->
11+
* [ ] that the issue which this Pull Request fixes ("Fixes...") is mentioned?
12+
13+
## When Changes Were Made
14+
15+
Did you:
16+
* [ ] update the changelog?
17+
* [ ] update the cookiecutter-template?
18+
* [ ] update the implementation?
19+
* [ ] check coverage and add tests: unit tests and, if relevant, integration tests?
20+
* [ ] update the User Guide & other documentation?
21+
* [ ] resolve any failing CI criteria (incl. Sonar quality gate)?
22+
23+
## When Preparing a Release
24+
25+
Have you:
26+
* [ ] thought about version number (major, minor, patch)?
27+
* [ ] checked Exasol packages for updates and resolved open vulnerabilities, if easily possible?

doc/changes/unreleased.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,3 +7,7 @@
77
## Documentation
88

99
* #488: Updated user guide to make clearer under which conditions branch protections based on GitHub actions can be enacted
10+
11+
## Refactoring
12+
13+
* #382: Updated pull_request_template.md to reflect checks we should regularly perform

exasol/toolbox/templates/github/PULL_REQUEST_TEMPLATE/pull_request_template.md

Lines changed: 0 additions & 16 deletions
This file was deleted.
Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
# Checklist
2+
3+
Note: If any of the items in the checklist are not relevant to your PR, just check the box.
4+
5+
## For any Pull Request
6+
7+
Is the following correct:
8+
* [ ] the title of the Pull Request?
9+
* [ ] the title of the corresponding issue?
10+
* [ ] there are no other open [Pull Requests](../../../../pulls) for the same update/change? <!-- markdown-link-check-disable-line -->
11+
* [ ] that the issue which this Pull Request fixes ("Fixes...") is mentioned?
12+
13+
## When Changes Were Made
14+
15+
Did you:
16+
* [ ] update the changelog?
17+
* [ ] update the implementation?
18+
* [ ] check coverage and add tests: unit tests and, if relevant, integration tests?
19+
* [ ] update the User Guide & other documentation?
20+
* [ ] resolve any failing CI criteria (incl. Sonar quality gate)?
21+
22+
## When Preparing a Release
23+
24+
Have you:
25+
* [ ] thought about version number (major, minor, patch)?
26+
* [ ] checked Exasol packages for updates and resolved open vulnerabilities, if easily possible?
27+
* [ ] executed `poetry run -- tbx workflow update`?

0 commit comments

Comments
 (0)