resolve conversation

Author: Jannis-Mittenzwei

exasol/toolbox/sphinx/multiversion/__init__.py

@@ -17,9 +17,9 @@
 
 from exasol.toolbox.sphinx.multiversion.main import main
 from exasol.toolbox.sphinx.multiversion.sphinx import setup
-from exasol.toolbox.version import VERSION
+from exasol.toolbox.version import Version
 
-__version__ = VERSION
+__version__ = Version
 
 __all__ = [
     "setup",

exasol/toolbox/sphinx/multiversion/sphinx.py

@@ -9,7 +9,7 @@
 from sphinx.locale import _
 from sphinx.util import i18n as sphinx_i18n
 
-from exasol.toolbox.version import VERSION as PLUGIN_VERSION
+from exasol.toolbox.version import Version as PLUGIN_VERSION
 from exasol.toolbox.version import Version as ExasolVersion
 
 logger = logging.getLogger(__name__)

test/unit/release_test.py

@@ -86,5 +86,3 @@ def test_extract_release_notes(unreleased_md):
     )
     actual = extract_release_notes(unreleased_md)
     assert expected == actual
-
-

test/unit/version_test.py

@@ -1,12 +1,21 @@
 import subprocess
 from subprocess import CalledProcessError
-from unittest.mock import patch, MagicMock
+from unittest.mock import (
+    MagicMock,
+    patch,
+)
 
 import pytest
 
 from exasol.toolbox.error import ToolboxError
-from exasol.toolbox.nox._release import _trigger_release, ReleaseError
-from exasol.toolbox.version import Version, poetry_command
+from exasol.toolbox.nox._release import (
+    ReleaseError,
+    _trigger_release,
+)
+from exasol.toolbox.version import (
+    Version,
+    poetry_command,
+)
 
 
 @pytest.mark.parametrize(
@@ -176,3 +185,23 @@ def test():
 
     with pytest.raises(ToolboxError):
         test()
+
+
+def test_version_from_python_module(tmp_path):
+    tmp_file = tmp_path / "file"
+    file = """
+MAJOR = 1
+MINOR = 2
+PATCH = 3
+VERSION = f"{MAJOR}.{MINOR}.{PATCH}"
+__version__ = VERSION
+    """
+    tmp_file.write_text(file)
+    assert Version.from_python_module(tmp_file) == Version.from_string("1.2.3")
+
+
+def test_version_from_python_no_module_error(tmp_path):
+    file_path = tmp_path / "file"
+    file_path.write_text("")
+    with pytest.raises(ToolboxError) as ex:
+        Version.from_python_module(file_path)