Switch python_files to be Iterable[str] as only used that way & restrict bandit to source files

Author: ArBridgeman

exasol/toolbox/nox/_artifacts.py

@@ -10,7 +10,10 @@
 from nox import Session
 
 from exasol.toolbox.nox._shared import MINIMUM_PYTHON_VERSION
-from noxconfig import PROJECT_CONFIG, Config
+from noxconfig import (
+    PROJECT_CONFIG,
+    Config,
+)
 
 COVERAGE_FILE = ".coverage"
 COVERAGE_XML = "ci-coverage.xml"
@@ -197,7 +200,7 @@ def _upload_to_sonar(session: Session, sonar_token: str, config: Config) -> None
         "--sonar-python-version",
         ",".join(config.python_versions),
         "--sonar-sources",
-        config.source
+        config.source,
     ]
     session.run(*command)
 

exasol/toolbox/nox/_format.py

@@ -39,7 +39,7 @@ def _pyupgrade(session: Session, config: Config, files: Iterable[str]) -> None:
 @nox.session(name="project:fix", python=False)
 def fix(session: Session) -> None:
     """Runs all automated fixes on the code base"""
-    py_files = [f"{file}" for file in python_files(PROJECT_CONFIG.root)]
+    py_files = python_files(PROJECT_CONFIG.root)
     _version(session, Mode.Fix)
     _pyupgrade(session, config=PROJECT_CONFIG, files=py_files)
     _code_format(session, Mode.Fix, py_files)
@@ -48,5 +48,5 @@ def fix(session: Session) -> None:
 @nox.session(name="project:format", python=False)
 def fmt_check(session: Session) -> None:
     """Checks the project for correct formatting"""
-    py_files = [f"{file}" for file in python_files(PROJECT_CONFIG.root)]
+    py_files = python_files(PROJECT_CONFIG.root)
     _code_format(session=session, mode=Mode.Check, files=py_files)

exasol/toolbox/nox/_lint.py

@@ -118,8 +118,8 @@ def report_illegal(illegal: dict[str, list[str]], console: rich.console.Console)
 
 @nox.session(name="lint:code", python=False)
 def lint(session: Session) -> None:
-    "Runs the static code analyzer on the project"
-    py_files = [f"{file}" for file in python_files(PROJECT_CONFIG.root)]
+    """Runs the static code analyzer on the project"""
+    py_files = python_files(PROJECT_CONFIG.root)
     _pylint(session, py_files)
 
 
@@ -133,7 +133,7 @@ def type_check(session: Session) -> None:
 @nox.session(name="lint:security", python=False)
 def security_lint(session: Session) -> None:
     """Runs the security linter on the project"""
-    py_files = [f"{file}" for file in python_files(PROJECT_CONFIG.root)]
+    py_files = python_files(PROJECT_CONFIG.root / PROJECT_CONFIG.source)
     _security_lint(session, py_files)
 
 

exasol/toolbox/nox/_shared.py

@@ -28,14 +28,14 @@ class Mode(Enum):
     Check = auto()
 
 
-def python_files(project_root: Path) -> Iterable[Path]:
+def python_files(project_root: Path) -> Iterable[str]:
     """
     Returns iterable of python files after removing unwanted paths
     """
     deny_list = DEFAULT_PATH_FILTERS.union(set(PROJECT_CONFIG.path_filters))
 
     files = project_root.glob("**/*.py")
-    return [path for path in files if not set(path.parts).intersection(deny_list)]
+    return [f"{path}" for path in files if not set(path.parts).intersection(deny_list)]
 
 
 def _version(session: Session, mode: Mode) -> None:

exasol/toolbox/nox/tasks.py

@@ -33,7 +33,7 @@
 def check(session: Session) -> None:
     """Runs all available checks on the project"""
     context = _context(session, coverage=True)
-    py_files = [f"{file}" for file in python_files(PROJECT_CONFIG.root)]
+    py_files = python_files(PROJECT_CONFIG.root)
     _version(session, Mode.Check)
     _code_format(session, Mode.Check, py_files)
     _pylint(session, py_files)

test/unit/nox/_shared_test.py

@@ -51,4 +51,4 @@ def test_python_files(
 
     actual = python_files(tmp_directory)
     assert len(actual) == 1
-    assert actual[0].parent.name == package_directory
+    assert "toolbox-dummy" in actual[0]