Skip to content

Commit 898e10c

Browse files
committed
Simplify _create_versioned_changelog and fix moved type
1 parent 31b48bc commit 898e10c

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

exasol/toolbox/util/dependencies/track_changes.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,8 +83,8 @@ def _categorize_change(
8383
return AddedDependency.from_package(current_dependency)
8484
elif previous_dependency.version != current_dependency.version: # type: ignore
8585
return UpdatedDependency.from_package(
86-
previous_dependency, current_dependency
87-
) # type: ignore
86+
previous_dependency, current_dependency # type: ignore
87+
)
8888
# dependency was unchanged between versions
8989
return None
9090

exasol/toolbox/util/release/changelog.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -44,12 +44,13 @@ def _create_versioned_changelog(self, unreleased_content: str) -> None:
4444
Args:
4545
unreleased_content: the content of the (not yet versioned) changes
4646
"""
47-
template = f"# {self.version} - {datetime.today().strftime('%Y-%m-%d')}"
48-
template += f"\n{unreleased_content}"
47+
header = f"# {self.version} - {datetime.today().strftime('%Y-%m-%d')}"
4948

50-
if dependency_content := self._describe_dependency_changes():
51-
template += f"\n## Dependency Updates\n{dependency_content}"
49+
dependency_content = ""
50+
if dependency_changes := self._describe_dependency_changes():
51+
dependency_content = f"## Dependency Updates\n{dependency_changes}"
5252

53+
template = cleandoc(f"{header}\n{unreleased_content}\n{dependency_content}")
5354
self.versioned_changelog_md.write_text(cleandoc(template))
5455

5556
def _extract_unreleased_notes(self) -> str:
@@ -60,8 +61,7 @@ def _extract_unreleased_notes(self) -> str:
6061
# skip header when reading in file, as contains # Unreleased
6162
lines = f.readlines()[1:]
6263
unreleased_content = cleandoc("".join(lines))
63-
unreleased_content += "\n"
64-
return unreleased_content
64+
return unreleased_content + "\n"
6565

6666
def _describe_dependency_changes(self) -> str:
6767
"""

0 commit comments

Comments
 (0)