Fix integration tests and typo

Author: ArBridgeman

exasol/toolbox/tools/issue.py

@@ -70,7 +70,7 @@ def update_issue(
         help="target directory to install the issue to.",
     ),
     confirm: bool = typer.Option(
-        False, help="Automatically confirm overwritting exsisting issue(s)"
+        False, help="Automatically confirm overwriting existing issue(s)"
     ),
 ) -> None:
     """Similar to install but checks for existing issues and shows diff"""

test/integration/tools/issue_test.py

@@ -1,3 +1,5 @@
+from unittest.mock import patch
+
 from exasol.toolbox.tools.issue import CLI
 
 
@@ -71,14 +73,20 @@ def test_install_twice_no_error(cli_runner, tmp_path):
 
 class TestUpdateIssue:
     @staticmethod
-    def test_default_wants_user_interaction(cli_runner, tmp_path):
+    def test_when_file_does_not_previously_exist(cli_runner, tmp_path):
+        result = cli_runner.invoke(CLI, ["update", "bug", str(tmp_path)])
+
+        assert result.exit_code == 0
+        assert result.output.strip() == f"Updated bug in \n{tmp_path}/bug.md"
+
+    @staticmethod
+    def test_with_existing_file(cli_runner, tmp_path):
         # set up with file in tmp_path so bug files are the same
         cli_runner.invoke(CLI, ["install", "bug", str(tmp_path)])
 
-        result = cli_runner.invoke(CLI, ["update", "bug", str(tmp_path)])
+        with patch("typer.confirm", return_value=False):
+            result = cli_runner.invoke(CLI, ["update", "bug", str(tmp_path)])
 
-        assert result.exit_code == 1
-        assert (
-            result.output.strip()
-            == "issue <bug> already exists, show diff? [y/N]:Aborted."
-        )
+        assert result.exit_code == 0
+        # files are identical, so no output expected
+        assert result.output.strip() == ""

test/integration/tools/workflow_test.py

@@ -1,3 +1,5 @@
+from unittest.mock import patch
+
 from exasol.toolbox.tools.workflow import CLI
 
 
@@ -95,14 +97,20 @@ def test_install_twice_no_error(cli_runner, tmp_path):
 
 class TestUpdateWorkflow:
     @staticmethod
-    def test_default_wants_user_interaction(cli_runner, tmp_path):
+    def test_when_file_does_not_previously_exist(cli_runner, tmp_path):
+        result = cli_runner.invoke(CLI, ["update", "checks", str(tmp_path)])
+
+        assert result.exit_code == 0
+        assert result.output.strip() == f"Updated checks in \n{tmp_path}/checks.yml"
+
+    @staticmethod
+    def test_with_existing_file(cli_runner, tmp_path):
         # set up with file in tmp_path so checks files are the same
         cli_runner.invoke(CLI, ["install", "checks", str(tmp_path)])
 
-        result = cli_runner.invoke(CLI, ["update", "checks", str(tmp_path)])
+        with patch("typer.confirm", return_value=False):
+            result = cli_runner.invoke(CLI, ["update", "checks", str(tmp_path)])
 
-        assert result.exit_code == 1
-        assert (
-            result.output.strip()
-            == "workflow <checks> already exists, show diff? [y/N]:Aborted."
-        )
+        assert result.exit_code == 0
+        # files are identical, so no output expected
+        assert result.output.strip() == ""