Skip to content

Commit a270cd8

Browse files
resolve conversation
1 parent 33ab812 commit a270cd8

File tree

5 files changed

+8
-18
lines changed

5 files changed

+8
-18
lines changed

.github/workflows/checks.yml

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -119,12 +119,7 @@ jobs:
119119

120120
Format:
121121
name: Format Check (Python-${{ matrix.python-version }})
122-
needs: [ Version-Check ]
123122
runs-on: ubuntu-latest
124-
strategy:
125-
fail-fast: false
126-
matrix:
127-
python-version: [ "3.9" ]
128123

129124
steps:
130125
- name: SCM Checkout
@@ -133,7 +128,7 @@ jobs:
133128
- name: Setup Python & Poetry Environment
134129
uses: ./.github/actions/python-environment
135130
with:
136-
python-version: ${{ matrix.python-version }}
131+
python-version: "3.9"
137132

138133
- name: Run format check
139134
run: poetry run nox -s project:format

doc/changes/unreleased.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@
55
* Excluded pyupgrade from project check due to its destructive nature
66
* Updated cookiecutter template
77
- removed obsolete template file `version.html`
8-
* added nox task for format checking
9-
* Updated github workflow template checks.yml
8+
* Added nox task for format checking
9+
* Updated GitHub workflow and workflow template of `checks.yml` to include format check
1010

1111
## 🐞 Fixed
1212

exasol/toolbox/nox/_format.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,5 +44,6 @@ def fix(session: Session) -> None:
4444

4545
@nox.session(name="project:format", python=False)
4646
def fmt_check(session: Session) -> None:
47+
"""Checks the project for correct formatting"""
4748
py_files = [f"{file}" for file in python_files(PROJECT_CONFIG.root)]
4849
_code_format(session=session, mode=Mode.Check, files=py_files)

exasol/toolbox/templates/github/workflows/checks.yml

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -125,12 +125,7 @@ jobs:
125125

126126
Format:
127127
name: Format Check (Python-${{ matrix.python-version }})
128-
needs: [ Version-Check ]
129128
runs-on: ubuntu-latest
130-
strategy:
131-
fail-fast: false
132-
matrix:
133-
python-version: [ "3.9" ]
134129

135130
steps:
136131
- name: SCM Checkout
@@ -139,8 +134,7 @@ jobs:
139134
- name: Setup Python & Poetry Environment
140135
uses: exasol/python-toolbox/.github/actions/[email protected]
141136
with:
142-
python-version: ${{ matrix.python-version }}
143-
137+
python-version: "3.9"
144138
- name: Run format check
145139
run: poetry run nox -s project:format
146140

poetry.lock

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)