resolved conversation

Author: Jannis-Mittenzwei

exasol/toolbox/nox/_artifacts.py

@@ -1,5 +1,6 @@
 import json
 import pathlib
+import re
 import sqlite3
 import sys
 from pathlib import Path
@@ -14,15 +15,14 @@
 def check_artifacts(session: Session) -> None:
     """Validate that all project artifacts are available and consistent"""
     if not_available := _missing_files(
-        {".lint.json", ".lint.txt", ".security.json", ".coverage"}, PROJECT_CONFIG.root
+        {".lint.txt", ".security.json", ".coverage"}, PROJECT_CONFIG.root
     ):
         print(f"not available: {not_available}")
         sys.exit(1)
 
     error = False
-    if msg := _validate_lint_json(Path(PROJECT_CONFIG.root, ".lint.json")):
-        print(f"error in [.lint.json]: {msg}")
-        error = True
+    if msg := _validate_lint_txt(Path(PROJECT_CONFIG.root, ".lint.txt")):
+        print(f"error in [.lint.txt]: {msg}")
     if msg := _validate_security_json(Path(PROJECT_CONFIG.root, ".security.json")):
         print(f"error in [.security.json]: {msg}")
         error = True
@@ -38,6 +38,18 @@ def _missing_files(expected_files: set, directory: Path) -> set:
     return expected_files - files
 
 
+def _validate_lint_txt(file: Path) -> str:
+    try:
+        content = file.read_text()
+    except FileNotFoundError as ex:
+        return f"Could not find file {file}, details: {ex}"
+    expr = re.compile(r"^Your code has been rated at (\d+.\d+)/.*", re.MULTILINE)
+    matches = expr.search(content)
+    if not matches:
+        return f"Could not find a rating"
+    return ""
+
+
 def _validate_lint_json(file: Path) -> str:
     try:
         content = file.read_text()

test/unit/lint_file_check_test.py

@@ -51,6 +51,26 @@ def test_check_lint_files(files, requested_files, expected, tmp_path):
     assert actual == expected
 
 
+@pytest.mark.parametrize(
+    "file,expected",
+    [
+        ("Your code has been rated at 7.85/10 (previous run: 7.83/10, +0.02", ""),
+        (
+            "test_text\nYour code has been rated at 7.85/10 (previous run: 7.83/10, +0.02\ntest_text",
+            "",
+        ),
+        ("", "Could not find a rating"),
+        ("test_text", "Could not find a rating"),
+    ],
+)
+def test_check_lint_txt(file, expected, tmp_path):
+    path = Path(tmp_path, ".lint.txt")
+    path.touch()
+    path.write_text(file)
+    actual = _artifacts._validate_lint_txt(path)
+    assert actual == expected
+
+
 @pytest.mark.parametrize(
     "attributes,expected",
     [