Added tests

Author: ckunki

exasol/toolbox/nox/_artifacts.py

@@ -137,6 +137,7 @@ def get_suffix() -> str:
     _combine_coverage(session, dir, f"coverage{suffix}*/.coverage")
     _copy_artifacts(
         dir,
+        dir.parent,
         f"lint{suffix}/.lint.txt",
         f"lint{suffix}/.lint.json",
         f"security{suffix}/.security.json",
@@ -154,16 +155,16 @@ def _combine_coverage(session: Session, dir: Path, pattern: str):
     pattern: glob pattern, e.g. "*.coverage"
     """
     if args := [f for f in dir.glob(pattern) if f.exists()]:
-        session.run("coverage", "combine", "--keep", *args)
+        session.run("coverage", "combine", "--keep", *sorted(args))
     else:
         print(f"Could not find any file {dir}/{pattern}", file=sys.stderr)
 
 
-def _copy_artifacts(dir: Path, *files: str):
+def _copy_artifacts(source: Path, dest: Path, *files: str):
     for file in files:
-        path = dir / file
+        path = source / file
         if path.exists():
             print(f"Copying file {path}", file=sys.stderr)
-            shutil.copy(path, ".")
+            shutil.copy(path, dest)
         else:
             print(f"File not found {path}", file=sys.stderr)

test/unit/artifacts_test.py

@@ -1,28 +1,29 @@
 import pytest
+import contextlib
+from dataclasses import dataclass
+from pathlib import Path
 import re
 from inspect import cleandoc
-from unittest.mock import Mock, patch
+from unittest.mock import Mock, patch, call
 from exasol.toolbox.nox._artifacts import copy_artifacts
 
 
-
-@pytest.fixture
-def python_version():
-    return "9.9"
-
-
-@pytest.fixture
-def project_config(python_version):
+@contextlib.contextmanager
+def mock_session(path: Path, python_version: str, *files: str):
     with patch("exasol.toolbox.nox._artifacts.PROJECT_CONFIG") as config:
         config.python_versions = [python_version]
-        yield config
+        for rel in files:
+            file = path / rel
+            file.parent.mkdir(parents=True, exist_ok=True)
+            file.write_text(rel)
+        yield Mock(posargs=[str(path)])
 
 
-def test_no_coverage(project_config, tmp_path, capsys):
-    session = Mock(posargs=[str(tmp_path)])
-    copy_artifacts(session)
+def test_missing_files(tmp_path, capsys):
+    with mock_session(tmp_path, "9.9") as session:
+        copy_artifacts(session)
     captured = capsys.readouterr()
-    re.match(
+    assert re.match(
         cleandoc(
             f"""
             Could not find any file .*/coverage-python9.9\\*/.coverage
@@ -33,5 +34,51 @@ def test_no_coverage(project_config, tmp_path, capsys):
         ),
         captured.err,
     )
-    with capsys.disabled():
-        print(captured.err)
+    #with capsys.disabled():
+    #    print(captured.err)
+
+
+@dataclass
+class endswith:
+    """
+    Assert that the str representation of the argument ends with the
+    specfied suffix.
+    """
+    suffix: str
+
+    def __eq__(self, actual):
+        return str(actual).endswith(self.suffix)
+
+
+def test_all_files(tmp_path, capsys):
+    with mock_session(
+        tmp_path / "artifacts",
+        "9.9",
+        "coverage-python9.9-fast/.coverage",
+        "coverage-python9.9-slow/.coverage",
+        "lint-python9.9/.lint.txt",
+        "lint-python9.9/.lint.json",
+        "security-python9.9/.security.json"
+    ) as session:
+        copy_artifacts(session)
+
+    captured = capsys.readouterr()
+    assert session.run.call_args == call (
+        "coverage",
+        "combine",
+        "--keep",
+        endswith("coverage-python9.9-fast/.coverage"),
+        endswith("coverage-python9.9-slow/.coverage"),
+    )
+    assert re.match(
+        cleandoc(
+            f"""
+            Copying file .*/lint-python9.9/.lint.txt
+            Copying file .*/lint-python9.9/.lint.json
+            Copying file .*/security-python9.9/.security.json
+            """
+        ),
+        captured.err,
+    )
+    for f in [".lint.txt", ".lint.json", ".security.json"]:
+        assert (tmp_path / f).exists()