add prysk test for pprint

Author: Jannis-Mittenzwei

.github/workflows/report.yml

@@ -51,4 +51,4 @@ jobs:
           poetry run coverage report -- --format markdown >> $GITHUB_STEP_SUMMARY
           echo  -e "\n\n# Static Code Analysis\n" >> $GITHUB_STEP_SUMMARY
           cat .lint.txt >> $GITHUB_STEP_SUMMARY
-          poetry run tbx security pretty-print --format markdown .security.json >> $GITHUB_STEP_SUMMARY
+          poetry run tbx security pretty-print .security.json >> $GITHUB_STEP_SUMMARY

exasol/toolbox/tools/security.py

@@ -126,10 +126,9 @@ def issues_to_markdown(issues: Iterable[Issue]) -> str:
     template = cleandoc("""
         {header}{rows}
     """)
+
     def _header():
-        header = ""
-        markdown_str = ""
-        markdown_str += "# Security\n\n"
+        header = "# Security\n\n"
         header += "|File|Cve|Cwe|Details|\n"
         header += "|---|:-:|:-:|---|\n"
         return header
@@ -140,7 +139,7 @@ def _row(issue):
         row += issue.cwe + "|"
         for element in issue.references:
             row += element + " ,<br>"
-        row += row[:-5] + "|"
+        row = row[:-5] + "|"
         return row
 
     return template.format(
@@ -310,7 +309,6 @@ class PPrintFormats(str, Enum):
 
 @CLI.command(name="pretty-print")
 def json_issue_to_markdown(
-        format: PPrintFormats = typer.Option(default="", help="output format",),
         json_file: typer.FileText = typer.Argument(default="", mode="r", help="json file with issues to convert"),
 ) -> None:
     content = json_file.read()

test/integration/cli/security-pprint-emty.t

@@ -0,0 +1,18 @@
+Create test input
+
+  $ cat > .security.json <<EOF
+  > {
+  >   "result":[
+  >   ]
+  > }
+  > EOF
+
+Run test case
+
+  $ tbx security pretty-print .security.json
+  # Security
+  
+  |File|Cve|Cwe|Details|
+  |---|:-:|:-:|---|
+  
+

test/integration/cli/security-pprint.t

@@ -0,0 +1,39 @@
+Create test input
+
+  $ cat > .security.json <<EOF
+  > {
+  >   "results":[
+  >     {
+  >       "code": "555                 subprocess.check_call(\n556                     config.smv_postbuild_command, cwd=current_cwd, shell=True\n557                 )\n558                 if config.smv_postbuild_export_pattern != \"\":\n559                     matches = find_matching_files_and_dirs(\n",
+  >       "col_offset": 16,
+  >       "end_col_offset": 17,
+  >       "filename": "/home/jami/Git/python-toolbox/exasol/toolbox/sphinx/multiversion/main.py",
+  >       "issue_confidence": "HIGH",
+  >       "issue_cwe": {
+  >         "id": 78,
+  >         "link": "https://cwe.mitre.org/data/definitions/78.html"
+  >       },
+  >       "issue_severity": "HIGH",
+  >       "issue_text": "subprocess call with shell=True identified, security issue.",
+  >       "line_number": 556,
+  >       "line_range": [
+  >         555,
+  >         556,
+  >         557
+  >       ],
+  >       "more_info": "https://bandit.readthedocs.io/en/1.7.10/plugins/b602_subprocess_popen_with_shell_equals_true.html",
+  >       "test_id": "B602",
+  >       "test_name": "subprocess_popen_with_shell_equals_true"
+  >     }
+  >   ]
+  > }
+  > EOF
+
+Run test case
+
+  $ tbx security pretty-print .security.json
+  # Security
+  
+  |File|Cve|Cwe|Details|
+  |---|:-:|:-:|---|
+  |exasol/toolbox/sphinx/multiversion/main.py:556:16:||78|https://bandit.readthedocs.io/en/1.7.10/plugins/b602_subprocess_popen_with_shell_equals_true.html ,<br>https://cwe.mitre.org/data/definitions/78.html |