You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: doc/design.rst
+191Lines changed: 191 additions & 0 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -209,3 +209,194 @@ _________________
209
209
- Description
210
210
* - python-environment
211
211
- Sets up an appropriate poetry based python environment
212
+
213
+
214
+
Known Issues
215
+
------------
216
+
217
+
This section documents flaws, sins, and known issues with the current design and/or its current implementation that were either known upfront or surfaced through the course of implementing it. Additionally, it attempts to explain why certain choices were made at the time, so one can better understand whether it may be reasonable to make changes now or in the future.
218
+
219
+
Passing files as individual arguments on the CLI
220
+
++++++++++++++++++++++++++++++++++++++++++++++++
221
+
222
+
**Description:**
223
+
224
+
As of today selection of python files for litting formatting etc. is done by passing all relevant python files as individual argument(s)
225
+
to the tools used/invoked by the python toolbox.
226
+
227
+
**Downsides:**
228
+
229
+
- Most shells have limitations on the number of arguments and their length.
230
+
- Noisey output, making it hard to decipher the actual command.
231
+
- Not ideal for all use cases.
232
+
233
+
**Rationale/History:**
234
+
235
+
- The current method of passing files as individual arguments by default offers ease in collection and filtering. It also allows users to simply provide or replace the selection mechanism fairly easily.
236
+
237
+
- Every tool used by the toolbox (e.g., `black`, `isort`) used to support passing files by argument. However, not all of them provided the same mechanism for selection or deselection patterns (e.g., "glob").
238
+
239
+
**Ideas/Solutions:**
240
+
241
+
- Develop a wrapper that allows for different selection mechanisms
242
+
243
+
244
+
Inconsistent Naming
245
+
+++++++++++++++++++
246
+
247
+
**Description:**
248
+
249
+
The naming is not consistent across the project name (python-toolbox) and the PyPI package name (exasol-toolbox).
250
+
251
+
**Downsides:**
252
+
253
+
- Misalignment between the PyPI package name and the project name causes confusion when discussing or referring to the project/package.
254
+
255
+
**Rationale/History:**
256
+
257
+
- Initially, this was a proof of concept (POC) to verify a few ideas, and the naming was not well thought out at the time.
258
+
- Later, when publishing the first package for distribution, the project name was unavailable on PyPI, resulting in a different name being used on PyPI.
0 commit comments