Switch create_major_version_tags to also be required to encourage BaseConfig

Author: ArBridgeman

exasol/toolbox/nox/_release.py

@@ -11,6 +11,7 @@
 from exasol.toolbox.nox._shared import (
     Mode,
     _version,
+    check_for_config_attribute,
 )
 from exasol.toolbox.nox.plugin import NoxTasks
 from exasol.toolbox.util.git import Git
@@ -101,10 +102,8 @@ def run(*args: str):
     run("git", "tag", str(release_version))
     run("git", "push", "origin", str(release_version))
 
-    if (
-        hasattr(project_config, "create_major_version_tags")
-        and project_config.create_major_version_tags
-    ):
+    check_for_config_attribute(project_config, "create_major_version_tags")
+    if project_config.create_major_version_tags:
         major_release_version = f"v{release_version.major}"
         run("git", "tag", "-f", str(major_release_version))
         run("git", "push", "-f", "origin", str(major_release_version))

test/unit/release_test.py

@@ -8,6 +8,7 @@
 import pytest
 
 import noxconfig
+from exasol.toolbox.config import BaseConfig
 from exasol.toolbox.nox._release import (
     ReleaseError,
     _trigger_release,
@@ -65,14 +66,14 @@ def simulate_pass(args, **kwargs):
         assert result == mock_from_poetry.return_value
 
     def test_not_creates_major_version_tag(self, mock_from_poetry):
-        class DummyConfig:
+        class DummyConfig(BaseConfig):
             pass
 
         def simulate_pass(args, **kwargs):
             return self._get_subprocess_run_mock(args)
 
         with patch("subprocess.run", side_effect=simulate_pass) as subprocess_mock:
-            result = _trigger_release(DummyConfig)
+            result = _trigger_release(DummyConfig())
             commands = [c.args[0] for c in subprocess_mock.mock_calls]
             assert commands == [
                 ("git", "remote", "show", "origin"),