Move over and simplify test for is_valid_coverage

Author: ArBridgeman

exasol/toolbox/nox/_artifacts.py

@@ -19,7 +19,7 @@
 SECURITY_JSON = ".security.json"
 
 ALL_FILES = {COVERAGE_FILE, LINT_JSON, LINT_TXT, SECURITY_JSON}
-
+COVERAGE_TABLES = {"coverage_schema", "meta", "file", "line_bits"}
 LINT_JSON_ATTRIBUTES = {
     "type",
     "module",
@@ -114,20 +114,21 @@ def _is_valid_security_json(file: Path) -> bool:
 def _is_valid_coverage(path: Path) -> bool:
     try:
         conn = sqlite3.connect(path)
+        cursor = conn.cursor()
     except sqlite3.Error as ex:
         return _handle_validation_error(
             path, f"database connection not possible, details: {ex}"
         )
-    cursor = conn.cursor()
     try:
         actual_tables = set(
             cursor.execute("select name from sqlite_schema where type == 'table'")
         )
     except sqlite3.Error as ex:
-        return _handle_validation_error(path, f"schema query not possible, details: {ex}")
-    expected = {"coverage_schema", "meta", "file", "line_bits"}
-    actual = {f[0] for f in actual_tables if (f[0] in expected)}
-    missing = expected - actual
+        return _handle_validation_error(
+            path, f"schema query not possible, details: {ex}"
+        )
+    actual = {f[0] for f in actual_tables if (f[0] in COVERAGE_TABLES)}
+    missing = COVERAGE_TABLES - actual
     if len(missing) > 0:
         return _handle_validation_error(
             path,

test/unit/lint_file_check_test.py

@@ -1,6 +1,7 @@
 import contextlib
 import json
 import re
+import sqlite3
 from dataclasses import dataclass
 from inspect import cleandoc
 from pathlib import Path
@@ -15,11 +16,13 @@
 from exasol.toolbox.nox._artifacts import (
     ALL_FILES,
     COVERAGE_FILE,
+    COVERAGE_TABLES,
     LINT_JSON,
     LINT_JSON_ATTRIBUTES,
     LINT_TXT,
     SECURITY_JSON,
     SECURITY_JSON_ATTRIBUTES,
+    _is_valid_coverage,
     _is_valid_lint_json,
     _is_valid_lint_txt,
     _is_valid_security_json,
@@ -183,6 +186,41 @@ def test_missing_attributes(self, tmp_path, capsys, missing_attributes):
         )
 
 
+class TestIsValidCoverage:
+    @staticmethod
+    def _create_coverage_file(path: Path, tables: set) -> None:
+        connection = sqlite3.connect(path)
+        cursor = connection.cursor()
+        for table in tables:
+            cursor.execute(f"CREATE TABLE IF NOT EXISTS {table} (test INTEGER)")
+
+    def test_passes_when_as_expected(self, tmp_path):
+        path = Path(tmp_path, COVERAGE_FILE)
+        self._create_coverage_file(path, COVERAGE_TABLES)
+
+        result = _is_valid_coverage(path)
+
+        assert result
+
+    @pytest.mark.parametrize(
+        "missing_table",
+        [
+            pytest.param({"coverage_schema"}, id="missing_coverage_schema"),
+        ],
+    )
+    def test_database_missing_tables(self, tmp_path, capsys, missing_table):
+        tables = COVERAGE_TABLES - missing_table
+        path = Path(tmp_path, COVERAGE_FILE)
+        self._create_coverage_file(path, tables)
+
+        result = _is_valid_coverage(path)
+
+        assert not result
+        assert (
+            f"missing the following tables {missing_table}" in capsys.readouterr().out
+        )
+
+
 class TestCopyArtifacts:
     @staticmethod
     def test_missing_files(tmp_path, capsys):