Skip to content

Commit 934ecb9

Browse files
committed
Apply suggestion from @niemyjski
Apply suggestion from @niemyjski Apply suggestion from @niemyjski Apply suggestion from @niemyjski Apply suggestion from @niemyjski ran dotnet format
1 parent 313d25f commit 934ecb9

File tree

3 files changed

+9
-11
lines changed

3 files changed

+9
-11
lines changed

src/Exceptionless.DateTimeExtensions/TimeUnit.cs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,15 +28,13 @@ public static bool TryParse(string value, out TimeSpan? time)
2828

2929
private static TimeSpan? ParseTime(string value)
3030
{
31-
if (String.IsNullOrEmpty(value))
31+
if (String.IsNullOrWhiteSpace(value))
3232
return null;
3333

3434
string normalized = value.Trim();
35-
if (String.IsNullOrEmpty(normalized))
36-
return null;
3735

3836
// bail if we have any weird characters
39-
foreach (char c in value)
37+
foreach (char c in normalized)
4038
if (!Char.IsLetterOrDigit(c) && c != '-' && c != '+' && !Char.IsWhiteSpace(c))
4139
return null;
4240

tests/Exceptionless.DateTimeExtensions.Tests/DateMathTests.cs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -571,7 +571,7 @@ public void ParseTimeZone_ExplicitDateWithoutTimezone_UsesSpecifiedTimezone()
571571
Assert.Equal(14, result.Hour);
572572
Assert.Equal(30, result.Minute);
573573
Assert.Equal(0, result.Second);
574-
574+
575575
// Should use the timezone offset from Eastern Time
576576
var expectedOffset = easternTimeZone.GetUtcOffset(new DateTime(2023, 6, 15, 14, 30, 0));
577577
Assert.Equal(expectedOffset, result.Offset);
@@ -596,7 +596,7 @@ public void ParseTimeZone_ExplicitDateWithTimezone_PreservesOriginalTimezone()
596596
Assert.Equal(14, result.Hour);
597597
Assert.Equal(30, result.Minute);
598598
Assert.Equal(0, result.Second);
599-
599+
600600
// Should preserve the original +05:00 timezone, not use Pacific
601601
Assert.Equal(TimeSpan.FromHours(5), result.Offset);
602602
}
@@ -609,7 +609,7 @@ public void ParseTimeZone_ExplicitDateWithTimezone_PreservesOriginalTimezone()
609609
public void ParseTimeZone_HourOperations_ReturnsCorrectResult(string expression, int hours)
610610
{
611611
var utcTimeZone = TimeZoneInfo.Utc;
612-
612+
613613
_logger.LogDebug("Testing Parse with TimeZoneInfo for expression: '{Expression}', TimeZone: {TimeZone}, Hours: {Hours}",
614614
expression, utcTimeZone.Id, hours);
615615

@@ -635,7 +635,7 @@ public void ParseTimeZone_HourOperations_ReturnsCorrectResult(string expression,
635635
public void ParseTimeZone_RoundingOperations_ReturnsCorrectResult(string expression, bool isUpperLimit)
636636
{
637637
var centralTimeZone = TimeZoneInfo.FindSystemTimeZoneById("US/Central");
638-
638+
639639
_logger.LogDebug("Testing Parse with TimeZoneInfo for expression: '{Expression}', TimeZone: {TimeZone}, IsUpperLimit: {IsUpperLimit}",
640640
expression, centralTimeZone.Id, isUpperLimit);
641641

@@ -693,7 +693,7 @@ public void TryParseTimeZone_ValidExpression_ReturnsTrue()
693693

694694
Assert.True(success);
695695
Assert.NotEqual(default(DateTimeOffset), result);
696-
696+
697697
// Should use Mountain Time offset
698698
var expectedOffset = mountainTimeZone.GetUtcOffset(DateTime.UtcNow);
699699
Assert.Equal(expectedOffset, result.Offset);
@@ -731,7 +731,7 @@ public void ParseTimeZone_ComplexExpression_WorksCorrectly()
731731

732732
// Should be UTC
733733
Assert.Equal(TimeSpan.Zero, result.Offset);
734-
734+
735735
// Should be rounded to start of hour
736736
Assert.Equal(0, result.Minute);
737737
Assert.Equal(0, result.Second);

tests/Exceptionless.DateTimeExtensions.Tests/TimeUnitTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ public void Parse_YearUnit_ReturnsExpectedDays(string input)
156156
var expectedDays = int.Parse(input.Substring(0, input.Length - 1)) * TimeSpanExtensions.AvgDaysInAYear;
157157

158158
// Assert
159-
Assert.True(Math.Abs(result.TotalDays - expectedDays) < 1,
159+
Assert.True(Math.Abs(result.TotalDays - expectedDays) < 1,
160160
$"Year conversion should be close to {expectedDays} days, got {result.TotalDays}");
161161
}
162162

0 commit comments

Comments
 (0)