Fix warnings

ejsmith · ejsmith · commit d08b3868022a · 2017-08-15T18:26:22.000-05:00
diff --git a/test/Exceptionless.DateTimeExtensions.Tests/DateTimeRangeTests.cs b/test/Exceptionless.DateTimeExtensions.Tests/DateTimeRangeTests.cs
@@ -43,33 +43,29 @@ public void CanParseIntoLocalTime() {
         }
 
         [Theory]
-        [MemberData("Inputs")]
+        [MemberData(nameof(Inputs))]
         public void CanParseNamedRanges(string input, DateTime start, DateTime end) {
             var range = DateTimeRange.Parse(input, _now);
             Assert.Equal(start, range.Start);
             Assert.Equal(end, range.End);
         }
 
-        public static IEnumerable<object[]> Inputs {
-            get {
-                return new[] {
-                    new object[] { "today",          _now.StartOfDay(), _now.EndOfDay() },
-                    new object[] { "yesterday",      _now.SubtractDays(1).StartOfDay(), _now.SubtractDays(1).EndOfDay() },
-                    new object[] { "tomorrow",       _now.AddDays(1).StartOfDay(), _now.AddDays(1).EndOfDay() },
-                    new object[] { "last 5 minutes", _now.SubtractMinutes(5).StartOfMinute(), _now },
-                    new object[] { "this 5 minutes", _now, _now.AddMinutes(5).EndOfMinute() },
-                    new object[] { "next 5 minutes", _now, _now.AddMinutes(5).EndOfMinute() },
-                    new object[] { "last jan",       _now.ChangeMonth(1).StartOfMonth(), _now.ChangeMonth(1).EndOfMonth() },
-                    new object[] { "jan",            _now.ChangeMonth(1).StartOfMonth(), _now.ChangeMonth(1).EndOfMonth() },
-                    new object[] { "noVemBer",       _now.StartOfMonth(), _now.EndOfMonth() },
-                    new object[] { "deC",            _now.ChangeMonth(12).StartOfMonth(), _now.ChangeMonth(12).EndOfMonth() },
-                    new object[] { "next deC",       _now.ChangeMonth(12).StartOfMonth(), _now.ChangeMonth(12).EndOfMonth() },
-                    new object[] { "next nov",       _now.AddYears(1).StartOfMonth(), _now.AddYears(1).EndOfMonth() },
-                    new object[] { "next jan",       _now.AddYears(1).ChangeMonth(1).StartOfMonth(), _now.AddYears(1).ChangeMonth(1).EndOfMonth() },
-                    new object[] { "jan-feb",        _now.ChangeMonth(1).StartOfMonth(), _now.ChangeMonth(2).EndOfMonth() },
-                    new object[] { "now-this feb",   _now, _now.AddYears(1).ChangeMonth(2).EndOfMonth() }
-                };
-            }
-        }
+        public static IEnumerable<object[]> Inputs => new[] {
+            new object[] { "today",          _now.StartOfDay(), _now.EndOfDay() },
+            new object[] { "yesterday",      _now.SubtractDays(1).StartOfDay(), _now.SubtractDays(1).EndOfDay() },
+            new object[] { "tomorrow",       _now.AddDays(1).StartOfDay(), _now.AddDays(1).EndOfDay() },
+            new object[] { "last 5 minutes", _now.SubtractMinutes(5).StartOfMinute(), _now },
+            new object[] { "this 5 minutes", _now, _now.AddMinutes(5).EndOfMinute() },
+            new object[] { "next 5 minutes", _now, _now.AddMinutes(5).EndOfMinute() },
+            new object[] { "last jan",       _now.ChangeMonth(1).StartOfMonth(), _now.ChangeMonth(1).EndOfMonth() },
+            new object[] { "jan",            _now.ChangeMonth(1).StartOfMonth(), _now.ChangeMonth(1).EndOfMonth() },
+            new object[] { "noVemBer",       _now.StartOfMonth(), _now.EndOfMonth() },
+            new object[] { "deC",            _now.ChangeMonth(12).StartOfMonth(), _now.ChangeMonth(12).EndOfMonth() },
+            new object[] { "next deC",       _now.ChangeMonth(12).StartOfMonth(), _now.ChangeMonth(12).EndOfMonth() },
+            new object[] { "next nov",       _now.AddYears(1).StartOfMonth(), _now.AddYears(1).EndOfMonth() },
+            new object[] { "next jan",       _now.AddYears(1).ChangeMonth(1).StartOfMonth(), _now.AddYears(1).ChangeMonth(1).EndOfMonth() },
+            new object[] { "jan-feb",        _now.ChangeMonth(1).StartOfMonth(), _now.ChangeMonth(2).EndOfMonth() },
+            new object[] { "now-this feb",   _now, _now.AddYears(1).ChangeMonth(2).EndOfMonth() }
+        };
     }
 }
diff --git a/test/Exceptionless.DateTimeExtensions.Tests/FormatParsers/ExplicitDateFormatParserTests.cs b/test/Exceptionless.DateTimeExtensions.Tests/FormatParsers/ExplicitDateFormatParserTests.cs
@@ -6,7 +6,7 @@
 namespace Exceptionless.DateTimeExtensions.Tests.FormatParsers {
     public class ExplicitDateFormatParserTests : FormatParserTestsBase {
         [Theory]
-        [MemberData("Inputs")]
+        [MemberData(nameof(Inputs))]
         public void ParseInput(string input, DateTime? start, DateTime? end) {
             ValidateInput(new ExplicitDateFormatParser(), input, start, end);
         }
diff --git a/test/Exceptionless.DateTimeExtensions.Tests/FormatParsers/MonthDayFormatParserTests.cs b/test/Exceptionless.DateTimeExtensions.Tests/FormatParsers/MonthDayFormatParserTests.cs
@@ -6,7 +6,7 @@
 namespace Exceptionless.DateTimeExtensions.Tests.FormatParsers {
     public class MonthDayFormatParserTests : FormatParserTestsBase {
         [Theory]
-        [MemberData("Inputs")]
+        [MemberData(nameof(Inputs))]
         public void ParseInput(string input, DateTime? start, DateTime? end) {
             ValidateInput(new MonthDayFormatParser(), input, start, end);
         }
diff --git a/test/Exceptionless.DateTimeExtensions.Tests/FormatParsers/MonthFormatParserTests.cs b/test/Exceptionless.DateTimeExtensions.Tests/FormatParsers/MonthFormatParserTests.cs
@@ -6,7 +6,7 @@
 namespace Exceptionless.DateTimeExtensions.Tests.FormatParsers {
     public class MonthFormatParserTests : FormatParserTestsBase {
         [Theory]
-        [MemberData("Inputs")]
+        [MemberData(nameof(Inputs))]
         public void ParseInput(string input, DateTime? start, DateTime? end) {
             ValidateInput(new MonthFormatParser(), input, start, end);
         }
diff --git a/test/Exceptionless.DateTimeExtensions.Tests/FormatParsers/MonthRelationFormatParserTests.cs b/test/Exceptionless.DateTimeExtensions.Tests/FormatParsers/MonthRelationFormatParserTests.cs
@@ -6,7 +6,7 @@
 namespace Exceptionless.DateTimeExtensions.Tests.FormatParsers {
     public class MonthRelationFormatParserTests : FormatParserTestsBase {
         [Theory]
-        [MemberData("Inputs")]
+        [MemberData(nameof(Inputs))]
         public void ParseInput(string input, DateTime? start, DateTime? end) {
             ValidateInput(new MonthRelationFormatParser(), input, start, end);
         }
diff --git a/test/Exceptionless.DateTimeExtensions.Tests/FormatParsers/NamedDayFormatParserTests.cs b/test/Exceptionless.DateTimeExtensions.Tests/FormatParsers/NamedDayFormatParserTests.cs
@@ -6,7 +6,7 @@
 namespace Exceptionless.DateTimeExtensions.Tests.FormatParsers {
     public class NamedDayFormatParserTests : FormatParserTestsBase {
         [Theory]
-        [MemberData("Inputs")]
+        [MemberData(nameof(Inputs))]
         public void ParseInput(string input, DateTime? start, DateTime? end) {
             ValidateInput(new NamedDayFormatParser(), input, start, end);
         }
diff --git a/test/Exceptionless.DateTimeExtensions.Tests/FormatParsers/PartParsers/AmountTimeRelationPartParserTests.cs b/test/Exceptionless.DateTimeExtensions.Tests/FormatParsers/PartParsers/AmountTimeRelationPartParserTests.cs
@@ -6,7 +6,7 @@
 namespace Exceptionless.DateTimeExtensions.Tests.FormatParsers.PartParsers {
     public class AmountTimeRelationPartParserTests : PartParserTestsBase {
         [Theory]
-        [MemberData("Inputs")]
+        [MemberData(nameof(Inputs))]
         public void ParseInput(string input, bool isUpperLimit, DateTimeOffset? expected) {
             ValidateInput(new AmountTimeRelationPartParser(), input, isUpperLimit, expected);
         }
diff --git a/test/Exceptionless.DateTimeExtensions.Tests/FormatParsers/PartParsers/ExplicitDatePartParserTests.cs b/test/Exceptionless.DateTimeExtensions.Tests/FormatParsers/PartParsers/ExplicitDatePartParserTests.cs
@@ -6,7 +6,7 @@
 namespace Exceptionless.DateTimeExtensions.Tests.FormatParsers.PartParsers {
     public class ExplicitDatePartParserTests : PartParserTestsBase {
         [Theory]
-        [MemberData("Inputs")]
+        [MemberData(nameof(Inputs))]
         public void ParseInput(string input, bool isUpperLimit, DateTimeOffset? expected) {
             ValidateInput(new ExplicitDatePartParser(), input, isUpperLimit, expected);
         }
diff --git a/test/Exceptionless.DateTimeExtensions.Tests/FormatParsers/PartParsers/MonthDayPartParserTests.cs b/test/Exceptionless.DateTimeExtensions.Tests/FormatParsers/PartParsers/MonthDayPartParserTests.cs
@@ -6,7 +6,7 @@
 namespace Exceptionless.DateTimeExtensions.Tests.FormatParsers.PartParsers {
     public class MonthDayPartParserTests : PartParserTestsBase {
         [Theory]
-        [MemberData("Inputs")]
+        [MemberData(nameof(Inputs))]
         public void ParseInput(string input, bool isUpperLimit, DateTimeOffset? expected) {
             ValidateInput(new MonthDayPartParser(), input, isUpperLimit, expected);
         }
diff --git a/test/Exceptionless.DateTimeExtensions.Tests/FormatParsers/PartParsers/MonthPartParserTests.cs b/test/Exceptionless.DateTimeExtensions.Tests/FormatParsers/PartParsers/MonthPartParserTests.cs
@@ -6,7 +6,7 @@
 namespace Exceptionless.DateTimeExtensions.Tests.FormatParsers.PartParsers {
     public class MonthPartParserTests : PartParserTestsBase {
         [Theory]
-        [MemberData("Inputs")]
+        [MemberData(nameof(Inputs))]
         public void ParseInput(string input, bool isUpperLimit, DateTimeOffset? expected) {
             ValidateInput(new MonthPartParser(), input, isUpperLimit, expected);
         }
diff --git a/test/Exceptionless.DateTimeExtensions.Tests/FormatParsers/PartParsers/MonthRelationPartParserTests.cs b/test/Exceptionless.DateTimeExtensions.Tests/FormatParsers/PartParsers/MonthRelationPartParserTests.cs
@@ -6,7 +6,7 @@
 namespace Exceptionless.DateTimeExtensions.Tests.FormatParsers.PartParsers {
     public class MonthRelationPartParserTests : PartParserTestsBase {
         [Theory]
-        [MemberData("Inputs")]
+        [MemberData(nameof(Inputs))]
         public void ParseInput(string input, bool isUpperLimit, DateTimeOffset? expected) {
             ValidateInput(new MonthRelationPartParser(), input, isUpperLimit, expected);
         }
diff --git a/test/Exceptionless.DateTimeExtensions.Tests/FormatParsers/PartParsers/NamedDayPartParserTests.cs b/test/Exceptionless.DateTimeExtensions.Tests/FormatParsers/PartParsers/NamedDayPartParserTests.cs
@@ -6,7 +6,7 @@
 namespace Exceptionless.DateTimeExtensions.Tests.FormatParsers.PartParsers {
     public class NamedDayPartParserTests : PartParserTestsBase {
         [Theory]
-        [MemberData("Inputs")]
+        [MemberData(nameof(Inputs))]
         public void ParseInput(string input, bool isUpperLimit, DateTimeOffset? expected) {
             ValidateInput(new NamedDayPartParser(), input, isUpperLimit, expected);
         }
diff --git a/test/Exceptionless.DateTimeExtensions.Tests/FormatParsers/PartParsers/SingleTimeRelationPartParserTests.cs b/test/Exceptionless.DateTimeExtensions.Tests/FormatParsers/PartParsers/SingleTimeRelationPartParserTests.cs
@@ -6,7 +6,7 @@
 namespace Exceptionless.DateTimeExtensions.Tests.FormatParsers.PartParsers {
     public class SingleTimeRelationPartParserTests : PartParserTestsBase {
         [Theory]
-        [MemberData("Inputs")]
+        [MemberData(nameof(Inputs))]
         public void ParseInput(string input, bool isUpperLimit, DateTimeOffset? expected) {
             ValidateInput(new SingleTimeRelationPartParser(), input, isUpperLimit, expected);
         }
diff --git a/test/Exceptionless.DateTimeExtensions.Tests/FormatParsers/PartParsers/YearPartParserTests.cs b/test/Exceptionless.DateTimeExtensions.Tests/FormatParsers/PartParsers/YearPartParserTests.cs
@@ -6,22 +6,18 @@
 namespace Exceptionless.DateTimeExtensions.Tests.FormatParsers.PartParsers {
     public class YearPartParserTests : PartParserTestsBase {
         [Theory]
-        [MemberData("Inputs")]
+        [MemberData(nameof(Inputs))]
         public void ParseInput(string input, bool isUpperLimit, DateTimeOffset? expected) {
             ValidateInput(new YearPartParser(), input, isUpperLimit, expected);
         }
 
-        public static IEnumerable<object[]> Inputs {
-            get {
-                return new[] {
-                    new object[] { "2013",      false, _now.ChangeYear(2013).StartOfYear() },
-                    new object[] { "2013",      true,  _now.ChangeYear(2013).EndOfYear() },
-                    new object[] { "2012",      false, _now.ChangeYear(2012).StartOfYear() },
-                    new object[] { "2012",      true,  _now.ChangeYear(2012).EndOfYear() },
-                    new object[] { "blah",      false, null },
-                    new object[] { "blah blah", true,  null }
-                };
-            }
-        }
+        public static IEnumerable<object[]> Inputs => new[] {
+            new object[] { "2013",      false, _now.ChangeYear(2013).StartOfYear() },
+            new object[] { "2013",      true,  _now.ChangeYear(2013).EndOfYear() },
+            new object[] { "2012",      false, _now.ChangeYear(2012).StartOfYear() },
+            new object[] { "2012",      true,  _now.ChangeYear(2012).EndOfYear() },
+            new object[] { "blah",      false, null },
+            new object[] { "blah blah", true,  null }
+        };
     }
 }
diff --git a/test/Exceptionless.DateTimeExtensions.Tests/FormatParsers/RelationAmountTimeFormatParserTests.cs b/test/Exceptionless.DateTimeExtensions.Tests/FormatParsers/RelationAmountTimeFormatParserTests.cs
@@ -6,7 +6,7 @@
 namespace Exceptionless.DateTimeExtensions.Tests.FormatParsers {
     public class RelationAmountTimeFormatParserTests : FormatParserTestsBase {
         [Theory]
-        [MemberData("Inputs")]
+        [MemberData(nameof(Inputs))]
         public void ParseInput(string input, DateTime? start, DateTime? end) {
             ValidateInput(new RelationAmountTimeFormatParser(), input, start, end);
         }
diff --git a/test/Exceptionless.DateTimeExtensions.Tests/FormatParsers/SingleTimeRelationFormatParserTests.cs b/test/Exceptionless.DateTimeExtensions.Tests/FormatParsers/SingleTimeRelationFormatParserTests.cs
@@ -6,7 +6,7 @@
 namespace Exceptionless.DateTimeExtensions.Tests.FormatParsers {
     public class SingleTimeRelationFormatParserTests : FormatParserTestsBase {
         [Theory]
-        [MemberData("Inputs")]
+        [MemberData(nameof(Inputs))]
         public void ParseInput(string input, DateTime? start, DateTime? end) {
             ValidateInput(new SingleTimeRelationFormatParser(), input, start, end);
         }
diff --git a/test/Exceptionless.DateTimeExtensions.Tests/FormatParsers/TwoPartFormatParserTests.cs b/test/Exceptionless.DateTimeExtensions.Tests/FormatParsers/TwoPartFormatParserTests.cs
@@ -6,7 +6,7 @@
 namespace Exceptionless.DateTimeExtensions.Tests.FormatParsers {
     public class TwoPartFormatParserTests : FormatParserTestsBase {
         [Theory]
-        [MemberData("Inputs")]
+        [MemberData(nameof(Inputs))]
         public void ParseInput(string input, DateTime? start, DateTime? end) {
             ValidateInput(new TwoPartFormatParser(), input, start, end);
         }
diff --git a/test/Exceptionless.DateTimeExtensions.Tests/FormatParsers/YearFormatParserTests.cs b/test/Exceptionless.DateTimeExtensions.Tests/FormatParsers/YearFormatParserTests.cs
@@ -6,7 +6,7 @@
 namespace Exceptionless.DateTimeExtensions.Tests.FormatParsers {
     public class YearFormatParserTests : FormatParserTestsBase {
         [Theory]
-        [MemberData("Inputs")]
+        [MemberData(nameof(Inputs))]
         public void ParseInput(string input, DateTime? start, DateTime? end) {
             ValidateInput(new YearFormatParser(), input, start, end);
         }

Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@`
`6`	`6`	`namespace Exceptionless.DateTimeExtensions.Tests.FormatParsers {`
`7`	`7`	`public class ExplicitDateFormatParserTests : FormatParserTestsBase {`
`8`	`8`	`[Theory]`
`9`		`- [MemberData("Inputs")]`
	`9`	`+ [MemberData(nameof(Inputs))]`
`10`	`10`	`public void ParseInput(string input, DateTime? start, DateTime? end) {`
`11`	`11`	`ValidateInput(new ExplicitDateFormatParser(), input, start, end);`
`12`	`12`	`}`
Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@`
`6`	`6`	`namespace Exceptionless.DateTimeExtensions.Tests.FormatParsers {`
`7`	`7`	`public class MonthDayFormatParserTests : FormatParserTestsBase {`
`8`	`8`	`[Theory]`
`9`		`- [MemberData("Inputs")]`
	`9`	`+ [MemberData(nameof(Inputs))]`
`10`	`10`	`public void ParseInput(string input, DateTime? start, DateTime? end) {`
`11`	`11`	`ValidateInput(new MonthDayFormatParser(), input, start, end);`
`12`	`12`	`}`
Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@`
`6`	`6`	`namespace Exceptionless.DateTimeExtensions.Tests.FormatParsers {`
`7`	`7`	`public class MonthFormatParserTests : FormatParserTestsBase {`
`8`	`8`	`[Theory]`
`9`		`- [MemberData("Inputs")]`
	`9`	`+ [MemberData(nameof(Inputs))]`
`10`	`10`	`public void ParseInput(string input, DateTime? start, DateTime? end) {`
`11`	`11`	`ValidateInput(new MonthFormatParser(), input, start, end);`
`12`	`12`	`}`
Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@`
`6`	`6`	`namespace Exceptionless.DateTimeExtensions.Tests.FormatParsers {`
`7`	`7`	`public class MonthRelationFormatParserTests : FormatParserTestsBase {`
`8`	`8`	`[Theory]`
`9`		`- [MemberData("Inputs")]`
	`9`	`+ [MemberData(nameof(Inputs))]`
`10`	`10`	`public void ParseInput(string input, DateTime? start, DateTime? end) {`
`11`	`11`	`ValidateInput(new MonthRelationFormatParser(), input, start, end);`
`12`	`12`	`}`
Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@`
`6`	`6`	`namespace Exceptionless.DateTimeExtensions.Tests.FormatParsers {`
`7`	`7`	`public class NamedDayFormatParserTests : FormatParserTestsBase {`
`8`	`8`	`[Theory]`
`9`		`- [MemberData("Inputs")]`
	`9`	`+ [MemberData(nameof(Inputs))]`
`10`	`10`	`public void ParseInput(string input, DateTime? start, DateTime? end) {`
`11`	`11`	`ValidateInput(new NamedDayFormatParser(), input, start, end);`
`12`	`12`	`}`
Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@`
`6`	`6`	`namespace Exceptionless.DateTimeExtensions.Tests.FormatParsers.PartParsers {`
`7`	`7`	`public class AmountTimeRelationPartParserTests : PartParserTestsBase {`
`8`	`8`	`[Theory]`
`9`		`- [MemberData("Inputs")]`
	`9`	`+ [MemberData(nameof(Inputs))]`
`10`	`10`	`public void ParseInput(string input, bool isUpperLimit, DateTimeOffset? expected) {`
`11`	`11`	`ValidateInput(new AmountTimeRelationPartParser(), input, isUpperLimit, expected);`
`12`	`12`	`}`
Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@`
`6`	`6`	`namespace Exceptionless.DateTimeExtensions.Tests.FormatParsers.PartParsers {`
`7`	`7`	`public class ExplicitDatePartParserTests : PartParserTestsBase {`
`8`	`8`	`[Theory]`
`9`		`- [MemberData("Inputs")]`
	`9`	`+ [MemberData(nameof(Inputs))]`
`10`	`10`	`public void ParseInput(string input, bool isUpperLimit, DateTimeOffset? expected) {`
`11`	`11`	`ValidateInput(new ExplicitDatePartParser(), input, isUpperLimit, expected);`
`12`	`12`	`}`
Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@`
`6`	`6`	`namespace Exceptionless.DateTimeExtensions.Tests.FormatParsers.PartParsers {`
`7`	`7`	`public class MonthDayPartParserTests : PartParserTestsBase {`
`8`	`8`	`[Theory]`
`9`		`- [MemberData("Inputs")]`
	`9`	`+ [MemberData(nameof(Inputs))]`
`10`	`10`	`public void ParseInput(string input, bool isUpperLimit, DateTimeOffset? expected) {`
`11`	`11`	`ValidateInput(new MonthDayPartParser(), input, isUpperLimit, expected);`
`12`	`12`	`}`
Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@`
`6`	`6`	`namespace Exceptionless.DateTimeExtensions.Tests.FormatParsers.PartParsers {`
`7`	`7`	`public class MonthPartParserTests : PartParserTestsBase {`
`8`	`8`	`[Theory]`
`9`		`- [MemberData("Inputs")]`
	`9`	`+ [MemberData(nameof(Inputs))]`
`10`	`10`	`public void ParseInput(string input, bool isUpperLimit, DateTimeOffset? expected) {`
`11`	`11`	`ValidateInput(new MonthPartParser(), input, isUpperLimit, expected);`
`12`	`12`	`}`