Small fixes

Author: pc9795

src/main/java/com/prashantchaubey/exceptionlessclient/ExceptionlessClient.java

@@ -43,6 +43,14 @@ public void run() {
         },
         UPDATE_SETTINGS_TIMER_INITIAL_DELAY,
         configurationManager.getConfiguration().getUpdateSettingsWhenIdleInterval());
+
+    configurationManager.onChanged(
+        ignored -> configurationManager.getSettingsManager().updateSettingsThreadSafe());
+    configurationManager
+        .getQueue()
+        .onEventsPosted(
+            (ignored1, ignored2) ->
+                configurationManager.getSettingsManager().updateSettingsThreadSafe());
   }
 
   public static ExceptionlessClient from(String apiKey, String serverUrl) {
@@ -138,6 +146,7 @@ private Event.EventBuilder createEvent() {
         .date(LocalDate.now());
   }
 
+  //todo this should be async
   private void submitEvent(
       EventPluginContext eventPluginContext, Consumer<EventPluginContext> handler) {
     eventPluginRunner.run(
@@ -163,8 +172,8 @@ public void submitSessionEnd(String sessionOrUserId) {
     configurationManager.getSubmissionClient().sendHeartBeat(sessionOrUserId, true);
   }
 
-  public void updateEmailAndDescription(
-      String referenceId, String email, String description, Consumer<SubmissionResponse> handler) {
+  public SubmissionResponse updateEmailAndDescription(
+      String referenceId, String email, String description) {
     SubmissionResponse response =
         configurationManager
             .getSubmissionClient()
@@ -178,7 +187,8 @@ public void updateEmailAndDescription(
               String.format(
                   "Failed to submit user email and description for event: %s", referenceId));
     }
-    handler.accept(response);
+
+    return response;
   }
 
   public String getLastReferenceId() {

src/main/java/com/prashantchaubey/exceptionlessclient/models/Event.java

@@ -169,18 +169,18 @@ public EventBuilder tags(Set<String> tags) {
     }
 
     public EventBuilder tags(String... tags) {
+      return tags(new HashSet<>(Arrays.asList(tags)));
+    }
+
+    public EventBuilder markAsCritical() {
       if (super.tags == null) {
-        return tags(new HashSet<>(Arrays.asList(tags)));
+        super.tags = new HashSet<>();
       }
 
-      super.tags.addAll(new HashSet<>(Arrays.asList(tags)));
+      super.tags.add(EventTag.CRITICAL.value());
       return this;
     }
 
-    public EventBuilder markAsCritical() {
-      return tags(EventTag.CRITICAL.value());
-    }
-
     @Override
     public EventBuilder message(String message) {
       super.message(message);