Skip to content

Commit c808e0c

Browse files
committed
Renamed ConfigurationManager to Configuration
1 parent 210d534 commit c808e0c

29 files changed

+207
-213
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,10 +46,10 @@ _Example: Customizing your Event Queue implementation_
4646
EventQueueIF queue = //get your implementation
4747
Configuration configuration =
4848
Configuration.builder().serverUrl("http://your-server-url").apiKey("your-api-key").build();
49-
ConfigurationManager configurationManager =
49+
ConfigurationManager configuration =
5050
ConfigurationManager.builder().queue(queue).configuration(configuration).build();
5151
ExceptionlessClient client =
52-
ExceptionlessClient.builder().configurationManager(configurationManager).build();
52+
ExceptionlessClient.builder().configuration(configuration).build();
5353
```
5454

5555
In this library we have made sure that all the values which are not set by builders fallback to reasonable defaults. So

src/main/java/com/exceptionless/exceptionlessclient/ExceptionlessClient.java

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package com.exceptionless.exceptionlessclient;
22

3-
import com.exceptionless.exceptionlessclient.configuration.ConfigurationManager;
3+
import com.exceptionless.exceptionlessclient.configuration.Configuration;
44
import com.exceptionless.exceptionlessclient.enums.EventPropertyKey;
55
import com.exceptionless.exceptionlessclient.enums.EventType;
66
import com.exceptionless.exceptionlessclient.models.Event;
@@ -27,27 +27,27 @@ public class ExceptionlessClient {
2727
private static final int UPDATE_SETTINGS_TIMER_INITIAL_DELAY = 5000;
2828
private static final Integer DEFAULT_NTHREADS = 10;
2929

30-
@Getter private final ConfigurationManager configurationManager;
30+
@Getter private final Configuration configuration;
3131
private final EventPluginRunner eventPluginRunner;
3232
private final Timer updateSettingsTimer;
3333
private final ExecutorService executorService;
3434

3535
@Builder
36-
public ExceptionlessClient(ConfigurationManager configurationManager, Integer nThreads) {
36+
public ExceptionlessClient(Configuration configuration, Integer nThreads) {
3737
this(
38-
configurationManager,
38+
configuration,
3939
UPDATE_SETTINGS_TIMER_INITIAL_DELAY,
4040
nThreads == null ? DEFAULT_NTHREADS : nThreads);
4141
}
4242

4343
@VisibleForTesting
4444
ExceptionlessClient(
45-
ConfigurationManager configurationManager,
45+
Configuration configuration,
4646
long updateSettingsTimerInitialDelay,
4747
Integer nThreads) {
48-
this.configurationManager = configurationManager;
48+
this.configuration = configuration;
4949
this.eventPluginRunner =
50-
EventPluginRunner.builder().configurationManager(this.configurationManager).build();
50+
EventPluginRunner.builder().configuration(this.configuration).build();
5151
this.updateSettingsTimer = new Timer(UPDATE_SETTINGS_TIMER_NAME);
5252
this.executorService = Executors.newFixedThreadPool(nThreads);
5353
init(updateSettingsTimerInitialDelay);
@@ -59,27 +59,27 @@ private void init(long delay) {
5959
@Override
6060
public void run() {
6161
try {
62-
configurationManager.getSettingsManager().updateSettings();
62+
configuration.getSettingsManager().updateSettings();
6363
} catch (Exception e) {
6464
log.error("Error in updating settings", e);
6565
}
6666
}
6767
},
6868
delay,
69-
configurationManager.getUpdateSettingsWhenIdleInterval().get());
69+
configuration.getUpdateSettingsWhenIdleInterval().get());
7070

71-
configurationManager.onChanged(
72-
ignored -> configurationManager.getSettingsManager().updateSettings());
73-
configurationManager
71+
configuration.onChanged(
72+
ignored -> configuration.getSettingsManager().updateSettings());
73+
configuration
7474
.getQueue()
7575
.onEventsPosted(
76-
(ignored1, ignored2) -> configurationManager.getSettingsManager().updateSettings());
76+
(ignored1, ignored2) -> configuration.getSettingsManager().updateSettings());
7777
}
7878

7979
public static ExceptionlessClient from(String apiKey, String serverUrl) {
8080
return ExceptionlessClient.builder()
81-
.configurationManager(
82-
ConfigurationManager.builder().apiKey(apiKey).serverUrl(serverUrl).build())
81+
.configuration(
82+
Configuration.builder().apiKey(apiKey).serverUrl(serverUrl).build())
8383
.build();
8484
}
8585

@@ -221,7 +221,7 @@ public Event.EventBuilder createSessionStart() {
221221

222222
public Event.EventBuilder createEvent() {
223223
return Event.builder()
224-
.dataExclusions(configurationManager.getDataExclusions())
224+
.dataExclusions(configuration.getDataExclusions())
225225
.date(LocalDate.now());
226226
}
227227

@@ -249,7 +249,7 @@ public CompletableFuture<Void> submitSessionEndAsync(String sessionOrUserId) {
249249

250250
public void submitSessionEnd(String sessionOrUserId) {
251251
log.info(String.format("Submitting session end: %s", sessionOrUserId));
252-
configurationManager.getSubmissionClient().sendHeartBeat(sessionOrUserId, true);
252+
configuration.getSubmissionClient().sendHeartBeat(sessionOrUserId, true);
253253
}
254254

255255
public CompletableFuture<SubmissionResponse> updateEmailAndDescriptionAsync(
@@ -261,7 +261,7 @@ public CompletableFuture<SubmissionResponse> updateEmailAndDescriptionAsync(
261261
public SubmissionResponse updateEmailAndDescription(
262262
String referenceId, String email, String description) {
263263
SubmissionResponse response =
264-
configurationManager
264+
configuration
265265
.getSubmissionClient()
266266
.postUserDescription(
267267
referenceId,
@@ -282,6 +282,6 @@ public SubmissionResponse updateEmailAndDescription(
282282
}
283283

284284
public String getLastReferenceId() {
285-
return configurationManager.getLastReferenceIdManager().getLast();
285+
return configuration.getLastReferenceIdManager().getLast();
286286
}
287287
}

src/main/java/com/exceptionless/exceptionlessclient/configuration/ConfigurationManager.java renamed to src/main/java/com/exceptionless/exceptionlessclient/configuration/Configuration.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
import java.util.function.Consumer;
3535

3636
@Slf4j
37-
public class ConfigurationManager {
37+
public class Configuration {
3838
private static final Integer API_KEY_MIN_LENGTH = 11;
3939
private static final Integer DEFAULT_HEART_BEAT_INTERVAL_IN_SECS = 30;
4040
private static final String DEFAULT_SERVER_URL = "https://collector.exceptionless.io";
@@ -63,7 +63,7 @@ public static class Property {
6363
@Getter private final EventQueueIF queue;
6464
@Getter private final Set<String> defaultTags;
6565
@Getter private final Map<String, Object> defaultData;
66-
private final List<Consumer<ConfigurationManager>> onChangedHandlers;
66+
private final List<Consumer<Configuration>> onChangedHandlers;
6767
@Getter private final SettingsManager settingsManager;
6868
private final Set<String> userAgentBotPatterns;
6969
@Getter private final PrivateInformationInclusions privateInformationInclusions;
@@ -81,7 +81,7 @@ public static class Property {
8181
private final PropertyChangeSupport propertyChangeSupport;
8282

8383
@Builder
84-
public ConfigurationManager(
84+
public Configuration(
8585
LastReferenceIdManagerIF lastReferenceIdManager,
8686
LogCapturerIF logCatpurer,
8787
SubmissionClientIF submissionClient,
@@ -301,14 +301,14 @@ public void addPlugin(EventPluginIF eventPlugin) {
301301
pluginManager.addPlugin(eventPlugin);
302302
}
303303

304-
public void addPlugin(BiConsumer<EventPluginContext, ConfigurationManager> pluginAction) {
304+
public void addPlugin(BiConsumer<EventPluginContext, Configuration> pluginAction) {
305305
pluginManager.addPlugin(pluginAction);
306306
}
307307

308308
public void addPlugin(
309309
String name,
310310
int priority,
311-
BiConsumer<EventPluginContext, ConfigurationManager> pluginAction) {
311+
BiConsumer<EventPluginContext, Configuration> pluginAction) {
312312
pluginManager.addPlugin(name, priority, pluginAction);
313313
}
314314

@@ -344,12 +344,12 @@ public void useSessions(int heartbeatIntervalInSecs) {
344344
addPlugin(HeartbeatPlugin.builder().heartbeatIntervalInSecs(heartbeatIntervalInSecs).build());
345345
}
346346

347-
public void onChanged(Consumer<ConfigurationManager> onChangedHandler) {
347+
public void onChanged(Consumer<Configuration> onChangedHandler) {
348348
onChangedHandlers.add(onChangedHandler);
349349
}
350350

351351
private void changed() {
352-
for (Consumer<ConfigurationManager> onChangedHandler : onChangedHandlers) {
352+
for (Consumer<Configuration> onChangedHandler : onChangedHandlers) {
353353
try {
354354
onChangedHandler.accept(this);
355355
} catch (Exception e) {
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package com.exceptionless.exceptionlessclient.plugins;
22

3-
import com.exceptionless.exceptionlessclient.configuration.ConfigurationManager;
3+
import com.exceptionless.exceptionlessclient.configuration.Configuration;
44
import com.exceptionless.exceptionlessclient.models.EventPluginContext;
55

66
public interface EventPluginIF {
@@ -10,5 +10,5 @@ default String getName() {
1010
return getClass().getName();
1111
}
1212

13-
void run(EventPluginContext eventPluginContext, ConfigurationManager configurationManager);
13+
void run(EventPluginContext eventPluginContext, Configuration configuration);
1414
}

src/main/java/com/exceptionless/exceptionlessclient/plugins/EventPluginRunner.java

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,21 @@
11
package com.exceptionless.exceptionlessclient.plugins;
22

3-
import com.exceptionless.exceptionlessclient.configuration.ConfigurationManager;
3+
import com.exceptionless.exceptionlessclient.configuration.Configuration;
44
import com.exceptionless.exceptionlessclient.models.EventPluginContext;
55
import lombok.Builder;
66
import lombok.extern.slf4j.Slf4j;
77

88
@Slf4j
99
public class EventPluginRunner {
10-
private final ConfigurationManager configurationManager;
10+
private final Configuration configuration;
1111

1212
@Builder
13-
public EventPluginRunner(ConfigurationManager configurationManager) {
14-
this.configurationManager = configurationManager;
13+
public EventPluginRunner(Configuration configuration) {
14+
this.configuration = configuration;
1515
}
1616

1717
public void run(EventPluginContext eventPluginContext) {
18-
configurationManager
18+
configuration
1919
.getPlugins()
2020
.forEach(
2121
plugin -> {
@@ -24,7 +24,7 @@ public void run(EventPluginContext eventPluginContext) {
2424
}
2525

2626
try {
27-
plugin.run(eventPluginContext, configurationManager);
27+
plugin.run(eventPluginContext, configuration);
2828

2929
} catch (Exception e) {
3030
log.error(
@@ -44,8 +44,8 @@ public void run(EventPluginContext eventPluginContext) {
4444
return;
4545
}
4646

47-
configurationManager.getQueue().enqueue(eventPluginContext.getEvent());
48-
configurationManager
47+
configuration.getQueue().enqueue(eventPluginContext.getEvent());
48+
configuration
4949
.getLastReferenceIdManager()
5050
.setLast(eventPluginContext.getEvent().getReferenceId());
5151
}

src/main/java/com/exceptionless/exceptionlessclient/plugins/PluginManager.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package com.exceptionless.exceptionlessclient.plugins;
22

3-
import com.exceptionless.exceptionlessclient.configuration.ConfigurationManager;
3+
import com.exceptionless.exceptionlessclient.configuration.Configuration;
44
import com.exceptionless.exceptionlessclient.models.EventPluginContext;
55
import com.exceptionless.exceptionlessclient.plugins.preconfigured.*;
66
import lombok.Builder;
@@ -53,14 +53,14 @@ private void sortPlugins() {
5353
plugins.sort((o1, o2) -> o2.getPriority() - o1.getPriority());
5454
}
5555

56-
public void addPlugin(BiConsumer<EventPluginContext, ConfigurationManager> pluginAction) {
56+
public void addPlugin(BiConsumer<EventPluginContext, Configuration> pluginAction) {
5757
addPlugin(UUID.randomUUID().toString(), DEFAULT_PLUGIN_PRIORITY, pluginAction);
5858
}
5959

6060
public void addPlugin(
6161
String name,
6262
int priority,
63-
BiConsumer<EventPluginContext, ConfigurationManager> pluginAction) {
63+
BiConsumer<EventPluginContext, Configuration> pluginAction) {
6464
addPlugin(
6565
new EventPluginIF() {
6666
@Override
@@ -75,8 +75,8 @@ public String getName() {
7575

7676
@Override
7777
public void run(
78-
EventPluginContext eventPluginContext, ConfigurationManager configurationManager) {
79-
pluginAction.accept(eventPluginContext, configurationManager);
78+
EventPluginContext eventPluginContext, Configuration configuration) {
79+
pluginAction.accept(eventPluginContext, configuration);
8080
}
8181
});
8282
}

src/main/java/com/exceptionless/exceptionlessclient/plugins/preconfigured/ConfigurationDefaultsPlugin.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package com.exceptionless.exceptionlessclient.plugins.preconfigured;
22

3-
import com.exceptionless.exceptionlessclient.configuration.ConfigurationManager;
3+
import com.exceptionless.exceptionlessclient.configuration.Configuration;
44
import com.exceptionless.exceptionlessclient.models.Event;
55
import com.exceptionless.exceptionlessclient.models.EventPluginContext;
66
import com.exceptionless.exceptionlessclient.plugins.EventPluginIF;
@@ -19,12 +19,12 @@ public int getPriority() {
1919

2020
@Override
2121
public void run(
22-
EventPluginContext eventPluginContext, ConfigurationManager configurationManager) {
22+
EventPluginContext eventPluginContext, Configuration configuration) {
2323
Event event = eventPluginContext.getEvent();
24-
for (String tag : configurationManager.getDefaultTags()) {
24+
for (String tag : configuration.getDefaultTags()) {
2525
event.addTags(tag);
2626
}
2727

28-
event.addData(configurationManager.getDefaultData(), configurationManager.getDataExclusions());
28+
event.addData(configuration.getDefaultData(), configuration.getDataExclusions());
2929
}
3030
}

src/main/java/com/exceptionless/exceptionlessclient/plugins/preconfigured/DuplicateCheckerPlugin.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package com.exceptionless.exceptionlessclient.plugins.preconfigured;
22

3-
import com.exceptionless.exceptionlessclient.configuration.ConfigurationManager;
3+
import com.exceptionless.exceptionlessclient.configuration.Configuration;
44
import com.exceptionless.exceptionlessclient.models.Event;
55
import com.exceptionless.exceptionlessclient.models.EventPluginContext;
66
import com.exceptionless.exceptionlessclient.plugins.EventPluginIF;
@@ -65,7 +65,7 @@ public int getPriority() {
6565

6666
@Override
6767
public void run(
68-
EventPluginContext eventPluginContext, ConfigurationManager configurationManager) {
68+
EventPluginContext eventPluginContext, Configuration configuration) {
6969
Event event = eventPluginContext.getEvent();
7070
long hash = getHash(event);
7171
Optional<MergedEvent> maybeMergedEvent =
@@ -92,7 +92,7 @@ public void run(
9292
mergedEvents.add(
9393
MergedEvent.builder()
9494
.event(event)
95-
.eventQueue(configurationManager.getQueue())
95+
.eventQueue(configuration.getQueue())
9696
.hash(hash)
9797
.build());
9898
eventPluginContext.getContext().setEventCancelled(true);

src/main/java/com/exceptionless/exceptionlessclient/plugins/preconfigured/EnvironmentInfoPlugin.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package com.exceptionless.exceptionlessclient.plugins.preconfigured;
22

3-
import com.exceptionless.exceptionlessclient.configuration.ConfigurationManager;
3+
import com.exceptionless.exceptionlessclient.configuration.Configuration;
44
import com.exceptionless.exceptionlessclient.enums.EnvironmentInfoPropertyKey;
55
import com.exceptionless.exceptionlessclient.models.EnvironmentInfo;
66
import com.exceptionless.exceptionlessclient.models.Event;
@@ -53,16 +53,16 @@ public int getPriority() {
5353

5454
@Override
5555
public void run(
56-
EventPluginContext eventPluginContext, ConfigurationManager configurationManager) {
56+
EventPluginContext eventPluginContext, Configuration configuration) {
5757
Event event = eventPluginContext.getEvent();
5858
if (event.getEnvironmentInfo().isEmpty()) {
5959
event.addEnvironmentInfo(
6060
getEnvironmentInfo(
6161
EnvironmentInfoGetArgs.builder()
6262
.includeIpAddress(
63-
configurationManager.getPrivateInformationInclusions().getIpAddress())
63+
configuration.getPrivateInformationInclusions().getIpAddress())
6464
.includeMachineName(
65-
configurationManager.getPrivateInformationInclusions().getMachineName())
65+
configuration.getPrivateInformationInclusions().getMachineName())
6666
.build()));
6767
}
6868
}

src/main/java/com/exceptionless/exceptionlessclient/plugins/preconfigured/ErrorPlugin.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package com.exceptionless.exceptionlessclient.plugins.preconfigured;
22

3-
import com.exceptionless.exceptionlessclient.configuration.ConfigurationManager;
3+
import com.exceptionless.exceptionlessclient.configuration.Configuration;
44
import com.exceptionless.exceptionlessclient.enums.EventPropertyKey;
55
import com.exceptionless.exceptionlessclient.enums.EventType;
66
import com.exceptionless.exceptionlessclient.models.Event;
@@ -26,7 +26,7 @@ public int getPriority() {
2626

2727
@Override
2828
public void run(
29-
EventPluginContext eventPluginContext, ConfigurationManager configurationManager) {
29+
EventPluginContext eventPluginContext, Configuration configuration) {
3030
Exception exception = eventPluginContext.getContext().getException();
3131
if (exception == null) {
3232
return;
@@ -40,7 +40,7 @@ public void run(
4040

4141
event.addError(parse(exception));
4242

43-
Set<String> dataExclusions = new HashSet<>(configurationManager.getDataExclusions());
43+
Set<String> dataExclusions = new HashSet<>(configuration.getDataExclusions());
4444
event.addData(Map.of(EventPropertyKey.EXTRA.value(), exception), dataExclusions);
4545
}
4646

0 commit comments

Comments
 (0)