Skip to content

Commit 30ddd53

Browse files
committed
Renamed session plugin based on feedback
1 parent d2bee52 commit 30ddd53

File tree

7 files changed

+32
-19
lines changed

7 files changed

+32
-19
lines changed

Source/Extras/Exceptionless.Extras.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@
5454
<Compile Include="Plugins\ErrorPlugin.cs" />
5555
<Compile Include="Plugins\PrivateInformationPlugin.cs" />
5656
<Compile Include="Plugins\TraceLogPlugin.cs" />
57-
<Compile Include="Plugins\SingleSessionPlugin.cs" />
57+
<Compile Include="Plugins\SessionIdManagerPlugin.cs" />
5858
<Compile Include="Plugins\VersionPlugin.cs" />
5959
<Compile Include="ExceptionlessSection.cs" />
6060
<Compile Include="Extensions\EventBuilderExtensions.cs" />

Source/Extras/Extensions/ExceptionlessExtraConfigurationExtensions.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,8 @@ public static void UseErrorPlugin(this ExceptionlessConfiguration config) {
3333
/// Ensures only a single user session will be created unless you specify a session id via the event builder.
3434
/// NOTE: This should only be used on deskop applications. Using this in web farm scenarios is not advisable.
3535
/// </summary>
36-
public static void UseSingleSessionPlugin(this ExceptionlessConfiguration config) {
37-
config.AddPlugin<SingleSessionPlugin>();
36+
public static void UseSessionIdManagementPlugin(this ExceptionlessConfiguration config) {
37+
config.AddPlugin<SessionIdManagerPlugin>();
3838
}
3939

4040
public static void UseIsolatedStorage(this ExceptionlessConfiguration config) {
Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
using System;
2+
using System.Collections.Concurrent;
3+
4+
namespace Exceptionless.Plugins {
5+
[Priority(90)]
6+
public class SessionIdManagerPlugin : IEventPlugin {
7+
private ConcurrentDictionary<string, string> _sessionIdMap = new ConcurrentDictionary<string, string>();
8+
9+
public void Run(EventPluginContext context) {
10+
string sessionId;
11+
12+
if (context.Event.IsSessionStart()) {
13+
// remove old session
14+
// add new session id
15+
} if (context.Event.IsSessionEnd()) {
16+
// remove old session
17+
}
18+
19+
20+
// check to see if the user changed the sessionid..
21+
22+
//if (String.IsNullOrEmpty(context.Event.SessionId))
23+
// context.Event.SessionId = sessionId;
24+
}
25+
}
26+
}

Source/Extras/Plugins/SingleSessionPlugin.cs

Lines changed: 0 additions & 13 deletions
This file was deleted.

Source/Platforms/Console/ExceptionlessExtensions.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ public static class ExceptionlessExtensions {
1111
/// </summary>
1212
/// <param name="client">The ExceptionlessClient.</param>
1313
public static void Register(this ExceptionlessClient client) {
14-
client.Configuration.UseSingleSessionPlugin();
14+
client.Configuration.UseSessionIdManagementPlugin();
1515
client.Startup();
1616
client.SubmitSessionStart();
1717

Source/Platforms/Windows/ExceptionlessWindowsExtensions.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ public static class ExceptionlessWindowsExtensions {
1515
/// <param name="client">The ExceptionlessClient.</param>
1616
/// <param name="showDialog">Controls whether a dialog is shown when an unhandled exception occurs.</param>
1717
public static void Register(this ExceptionlessClient client, bool showDialog = true) {
18-
client.Configuration.UseSingleSessionPlugin();
18+
client.Configuration.UseSessionIdManagementPlugin();
1919
client.Startup();
2020
client.SubmitSessionStart();
2121
client.RegisterApplicationThreadExceptionHandler();

Source/Platforms/Wpf/ExceptionlessWpfExtensions.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ public static class ExceptionlessWpfExtensions {
1616
/// <param name="client">The ExceptionlessClient.</param>
1717
/// <param name="showDialog">Controls whether a dialog is shown when an unhandled exception occurs.</param>
1818
public static void Register(this ExceptionlessClient client, bool showDialog = true) {
19-
client.Configuration.UseSingleSessionPlugin();
19+
client.Configuration.UseSessionIdManagementPlugin();
2020
client.Startup();
2121
client.SubmitSessionStart();
2222
client.RegisterApplicationThreadExceptionHandler();

0 commit comments

Comments
 (0)