Added a check to ensure that configuration isn't locked

Author: niemyjski

Source/Platforms/NLog/ExceptionlessTarget.cs

@@ -32,6 +32,9 @@ protected override void InitializeTarget() {
         }
 
         protected override void Write(AsyncLogEventInfo info) {
+            if (!_client.Configuration.IsValid)
+                return;
+
             var builder = _client.CreateFromLogEvent(info.LogEvent);
             foreach (var field in Fields) {
                 var renderedField = field.Layout.Render(info.LogEvent);

Source/Shared/Configuration/ExceptionlessConfiguration.cs

@@ -42,8 +42,7 @@ internal void LockConfig() {
                 return;
 
             _configLocked = true;
-            _validationResult = Validate();
-            Enabled = Enabled && _validationResult.IsValid;
+            Enabled = Enabled && IsValid;
         }
 
         /// <summary>
@@ -58,6 +57,7 @@ public string ServerUrl {
                 if (_configLocked)
                     throw new ArgumentException("ServerUrl can't be changed after the client has been initialized.");
 
+                _validationResult = null;
                 _serverUrl = value;
             }
         }
@@ -79,6 +79,7 @@ public string ApiKey {
                 if (_configLocked)
                     throw new ArgumentException("ApiKey can't be changed after the client has been initialized.");
 
+                _validationResult = null;
                 _apiKey = value;
             }
         }
@@ -230,6 +231,15 @@ public void RemoveEnrichment(string key) {
 
         #endregion
 
+        public bool IsValid {
+            get {
+                if (_validationResult == null)
+                    _validationResult = Validate();
+
+                return _validationResult.IsValid;
+            }
+        }
+
         public ValidationResult Validate() {
             if (_validationResult != null)
                 return _validationResult;

Source/Shared/ExceptionlessClient.cs

@@ -69,7 +69,7 @@ public bool UpdateUserEmailAndDescription(string referenceId, string email, stri
 
             if (!Configuration.IsLocked) {
                 Configuration.LockConfig();
-                if (!Configuration.Validate().IsValid) {
+                if (!Configuration.IsValid) {
                     _log.Value.FormattedError(typeof(ExceptionlessClient), "Disabling client due to invalid configuration: {0}", String.Join(", ", Configuration.Validate().Messages));
                     return false;
                 }
@@ -98,7 +98,7 @@ public Task ProcessQueueAsync() {
 
             if (!Configuration.IsLocked) {
                 Configuration.LockConfig();
-                if (!Configuration.Validate().IsValid) {
+                if (!Configuration.IsValid) {
                     _log.Value.FormattedError(typeof(ExceptionlessClient), "Disabling client due to invalid configuration: {0}", String.Join(", ", Configuration.Validate().Messages));
                     return Threading.Tasks.TaskExtensions.FromResult(0);
                 }
@@ -133,7 +133,7 @@ public void SubmitEvent(Event ev, ContextData enrichmentContextData = null) {
 
             if (!Configuration.IsLocked) {
                 Configuration.LockConfig();
-                if (!Configuration.Validate().IsValid) {
+                if (!Configuration.IsValid) {
                     _log.Value.FormattedError(typeof(ExceptionlessClient), "Disabling client due to invalid configuration: {0}", String.Join(", ", Configuration.Validate().Messages));
                     return;
                 }