Skip to content

Commit 472d8d9

Browse files
wu-yafengniemyjski
authored andcommitted
Resolve conversation
- Use 2.2 logging component - fix some typo - remove regions
1 parent ca220cb commit 472d8d9

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

src/Platforms/Exceptionless.Extensions.Logging/Exceptionless.Extensions.Logging.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
</ItemGroup>
1616

1717
<ItemGroup Label="Package References">
18-
<PackageReference Include="Microsoft.Extensions.Logging" Version="3.1.2" />
18+
<PackageReference Include="Microsoft.Extensions.Logging" Version="2.2.0" />
1919
</ItemGroup>
2020

2121
<ItemGroup>

src/Platforms/Exceptionless.Extensions.Logging/ExceptionlessLoggerExtensions.cs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ public static ExceptionlessLogLevel ToLogLevel(this LogLevel level) {
2727
/// Adds Exceptionless to the logging pipeline using the <see cref="ExceptionlessClient.Default"/>.
2828
/// </summary>
2929
/// <param name="builder">The <see cref="ILoggingBuilder"/>.</param>
30-
/// <param name="client">If a client is not specified then the <see cref="ExceptionlessClient.Default"/> wil be used.</param>
30+
/// <param name="client">If a client is not specified then the <see cref="ExceptionlessClient.Default"/> will be used.</param>
3131
/// <returns>The <see cref="ILoggingBuilder"/>.</returns>
3232
public static ILoggingBuilder AddExceptionless(this ILoggingBuilder builder, ExceptionlessClient client = null) {
3333
builder.AddProvider(new ExceptionlessLoggerProvider(client ?? ExceptionlessClient.Default));
@@ -65,12 +65,11 @@ public static ILoggingBuilder AddExceptionless(this ILoggingBuilder builder, Act
6565
builder.AddProvider(new ExceptionlessLoggerProvider(configure));
6666
return builder;
6767
}
68-
#region Obsolute
6968
/// <summary>
7069
/// Adds Exceptionless to the logging pipeline using the <see cref="ExceptionlessClient.Default"/>.
7170
/// </summary>
7271
/// <param name="factory">The <see cref="ILoggerFactory"/>.</param>
73-
/// <param name="client">If a client is not specified then the <see cref="ExceptionlessClient.Default"/> wil be used.</param>
72+
/// <param name="client">If a client is not specified then the <see cref="ExceptionlessClient.Default"/> will be used.</param>
7473
/// <returns>The <see cref="ILoggerFactory"/>.</returns>
7574
[Obsolete("Use ExceptionlessLoggerExtensions.AddExceptionless(ILoggingBuilder,ExceptionlessClient) instead.")]
7675
public static ILoggerFactory AddExceptionless(this ILoggerFactory factory, ExceptionlessClient client = null) {
@@ -113,6 +112,5 @@ public static ILoggerFactory AddExceptionless(this ILoggerFactory factory, Actio
113112
factory.AddProvider(new ExceptionlessLoggerProvider(configure));
114113
return factory;
115114
}
116-
#endregion
117115
}
118116
}

0 commit comments

Comments
 (0)