Fix Exception.HResult is not being mapped to error.code property (#274)

* Fixes Exception.HResult is not being mapped to error.code property #273

* Refactor to make a bit more clean

Co-authored-by: Blake Niemyjski <[email protected]>

Author: elachlan

src/Exceptionless/Extensions/ToErrorModelExtensions.cs

@@ -54,7 +54,7 @@ private static Error ToErrorModelInternal(Exception exception, ExceptionlessClie
             error.PopulateStackTrace(error, exception, log);
 
             try {
-                PropertyInfo info = type.GetProperty("HResult", BindingFlags.NonPublic | BindingFlags.Instance);
+                PropertyInfo info = type.GetProperty("HResult", BindingFlags.Public | BindingFlags.Instance);
                 if (info != null)
                     error.Code = info.GetValue(exception, null).ToString();
             } catch (Exception) { }

test/Exceptionless.Tests/Plugins/020_ErrorPluginTests.cs

@@ -286,5 +286,21 @@ public void WillUnwrapExceptionTypeName() {
                     Assert.Equal(type, context.Event.GetSimpleError().Type);
             }
         }
+
+        [Fact]
+        public void TrackException() {
+            var plugin = new ErrorPlugin();
+            var client = CreateClient();
+            var context = new EventPluginContext(client, new Event());
+            var exception = new TestOutOfMemoryException("Test");
+            context.ContextData.SetException(exception);
+            plugin.Run(context);
+            Assert.False(context.Cancel);
+            Assert.Equal(Event.KnownTypes.Error, context.Event.Type);
+            var error = context.Event.GetError();
+            if (error != null) {
+                Assert.Equal(E_OUTOFMEMORY.ToString(), error.Code);
+            }
+        }
     }
 }

test/Exceptionless.Tests/Plugins/PluginTestBase.cs

@@ -90,5 +90,18 @@ public enum ErrorCategory {
             FirstErrorBucket,
             SecondErrorBucket,
         }
+
+        /// <summary>
+        /// Hresult for 'Failed to allocate necessary memory'.
+        /// <see href="https://docs.microsoft.com/en-us/windows/win32/seccrypto/common-hresult-values"/>
+        /// </summary>
+        public const int E_OUTOFMEMORY = unchecked((int)0x8007000E);
+
+        public class TestOutOfMemoryException : Exception {
+            public TestOutOfMemoryException(string message) : base(message) {
+                // Out of Memory Exception
+                HResult = E_OUTOFMEMORY;
+            }
+        }
     }
 }