Skip to content

Commit 4df268f

Browse files
committed
Fixed #63 Fixed an issue where dictionary keys names were being changed.
#63
1 parent 64a67a6 commit 4df268f

File tree

4 files changed

+3
-8
lines changed

4 files changed

+3
-8
lines changed

Source/Samples/SampleMvc/Controllers/HomeController.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ public ViewResult CustomError() {
3535
}
3636

3737
[HttpGet]
38-
public ViewResult ManualStacking() {
38+
public ViewResult ManualStacking(string myId) {
3939
ExceptionlessClient.Default.CreateLog(nameof(HomeController), "Random Log message")
4040
.SetManualStackingInfo("Manual Stacked Log Messages", new Dictionary<string, string> {
4141
{ "Controller", nameof(HomeController) },

Source/Samples/SampleMvc/Views/Home/Index.cshtml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
@Html.ActionLink("Boom!", "Boom")
44
@Html.ActionLink("Custom Boom!", "CustomBoom")
55
@Html.ActionLink("Boom 25!", "Boom25")
6-
@Html.ActionLink("Manual Stacking", "ManualStacking")
6+
@Html.ActionLink("Manual Stacking", "ManualStacking", new { myId = "123456789" })
77

88
<a href="javascript:doAjax()">Ajax Boom</a>
99

Source/Shared/Serializer/ExceptionlessContractResolver.cs

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
using System;
22
using System.Reflection;
3-
using Exceptionless.Models;
43
using Exceptionless.Json;
54
using Exceptionless.Json.Serialization;
65
using Exceptionless.Extensions;
@@ -24,9 +23,6 @@ protected override JsonProperty CreateProperty(MemberInfo member, MemberSerializ
2423
}
2524

2625
protected override JsonDictionaryContract CreateDictionaryContract(Type objectType) {
27-
if (objectType != typeof(DataDictionary) && objectType != typeof(SettingsDictionary))
28-
return base.CreateDictionaryContract(objectType);
29-
3026
JsonDictionaryContract contract = base.CreateDictionaryContract(objectType);
3127
contract.PropertyNameResolver = propertyName => propertyName;
3228
return contract;

Source/Tests/Plugins/PluginTests.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -153,8 +153,7 @@ public void HandleAggregateExceptionsPlugin_SingleInnerException() {
153153
context = new EventPluginContext(client, new Event());
154154
context.ContextData.SetException(new AggregateException(exceptionOne, exceptionTwo));
155155
plugin.Run(context);
156-
Assert.False(context.Cancel);
157-
Assert.Equal(exceptionOne, context.ContextData.GetException());
156+
Assert.True(context.Cancel);
158157
}
159158

160159
[Fact]

0 commit comments

Comments
 (0)