Fixes #50 Preserve extended data on 404's

niemyjski · niemyjski · commit 5538bda97297 · 2015-11-23T17:47:17.000-06:00
diff --git a/Source/Platforms/Nancy/ExceptionlessNancyPlugin.cs b/Source/Platforms/Nancy/ExceptionlessNancyPlugin.cs
@@ -28,10 +28,8 @@ public void Run(EventPluginContext context) {
             if (requestInfo == null)
                 return;
 
-            if (context.Event.Type == Event.KnownTypes.NotFound) {
+            if (context.Event.Type == Event.KnownTypes.NotFound)
                 context.Event.Source = requestInfo.GetFullPath(includeHttpMethod: true, includeHost: false, includeQueryString: false);
-                context.Event.Data.Clear();
-            }
 
             context.Event.AddRequestInfo(requestInfo);
         }
diff --git a/Source/Platforms/Web/ExceptionlessWebPlugin.cs b/Source/Platforms/Web/ExceptionlessWebPlugin.cs
@@ -47,7 +47,6 @@ public void Run(EventPluginContext context) {
                 if (httpCode == 404) {
                     context.Event.Type = Event.KnownTypes.NotFound;
                     context.Event.Source = requestInfo.GetFullPath(includeHttpMethod: true, includeHost: false, includeQueryString: false);
-                    context.Event.Data.Clear();
                 }
             }
 
diff --git a/Source/Platforms/WebApi/ExceptionlessWebApiPlugin.cs b/Source/Platforms/WebApi/ExceptionlessWebApiPlugin.cs
@@ -41,7 +41,6 @@ public void Run(EventPluginContext context) {
             if (error != null && error.Code == "404") {
                 context.Event.Type = Event.KnownTypes.NotFound;
                 context.Event.Source = requestInfo.GetFullPath(includeHttpMethod: true, includeHost: false, includeQueryString: false);
-                context.Event.Data.Clear();
             }
 
             context.Event.AddRequestInfo(requestInfo);

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,6 @@ public void Run(EventPluginContext context) {`
`47`	`47`	`if (httpCode == 404) {`
`48`	`48`	`context.Event.Type = Event.KnownTypes.NotFound;`
`49`	`49`	`context.Event.Source = requestInfo.GetFullPath(includeHttpMethod: true, includeHost: false, includeQueryString: false);`
`50`		`- context.Event.Data.Clear();`
`51`	`50`	`}`
`52`	`51`	`}`
`53`	`52`
Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,6 @@ public void Run(EventPluginContext context) {`
`41`	`41`	`if (error != null && error.Code == "404") {`
`42`	`42`	`context.Event.Type = Event.KnownTypes.NotFound;`
`43`	`43`	`context.Event.Source = requestInfo.GetFullPath(includeHttpMethod: true, includeHost: false, includeQueryString: false);`
`44`		`- context.Event.Data.Clear();`
`45`	`44`	`}`
`46`	`45`
`47`	`46`	`context.Event.AddRequestInfo(requestInfo);`