Add ability to configure default client through lambda in UseExceptionless method. Fix some null references.

Author: ejsmith

samples/Exceptionless.SampleAspNetCore/Startup.cs

@@ -31,13 +31,13 @@ public void ConfigureServices(IServiceCollection services) {
         public void Configure(IApplicationBuilder app, IWebHostEnvironment env, ILoggerFactory loggerFactory) {
             app.UseExceptionless(Configuration);
             //OR
-            //app.UseExceptionless(new ExceptionlessClient(c => c.ReadFromConfiguration(Configuration)));
+            //app.UseExceptionless(c => c.ReadFromConfiguration(Configuration));
             //OR
             //app.UseExceptionless("API_KEY_HERE");
             //OR
             //loggerFactory.AddExceptionless("API_KEY_HERE");
             //OR
-            //loggerFactory.AddExceptionless((c) => c.ReadFromConfiguration(Configuration));
+            //loggerFactory.AddExceptionless(c => c.ReadFromConfiguration(Configuration));
 
             //loggerFactory.AddExceptionless();
             app.UseRouting();

src/Exceptionless/Extensions/ExceptionlessClientExtensions.cs

@@ -5,8 +5,6 @@
 using Exceptionless.Plugins;
 using Exceptionless.Logging;
 using Exceptionless.Models;
-using Exceptionless.Services;
-using Exceptionless.Submission;
 
 namespace Exceptionless {
     public static class ExceptionlessClientExtensions {

src/Exceptionless/Plugins/Default/080_VersionPlugin.cs

@@ -114,10 +114,13 @@ private Assembly GetEntryAssembly(IExceptionlessLog log) {
         }
 
         private bool IsUserAssembly(Assembly assembly) {
+            if (assembly == null)
+                return false;
+
             if (!String.IsNullOrEmpty(assembly.FullName) && (assembly.FullName.StartsWith("System.") || assembly.FullName.StartsWith("Microsoft.")))
                 return false;
 
-            string company = assembly.GetCompany();
+            string company = assembly.GetCompany() ?? String.Empty;
             string[] nonUserCompanies = new[] { "Exceptionless", "Microsoft" };
             if (nonUserCompanies.Any(c => company.IndexOf(c, StringComparison.OrdinalIgnoreCase) >= 0))
                 return false;

src/Platforms/Exceptionless.AspNetCore/ExceptionlessExtensions.cs

@@ -20,7 +20,7 @@ namespace Exceptionless {
     public static class ExceptionlessExtensions {
         public static IApplicationBuilder UseExceptionless(this IApplicationBuilder app, ExceptionlessClient client = null) {
             if (client == null)
-                client = ExceptionlessClient.Default;
+                client = app.ApplicationServices.GetService<ExceptionlessClient>() ?? ExceptionlessClient.Default;
 
             // Can be registered in Startup.ConfigureServices via services.AddHttpContextAccessor();
             // this is necessary to obtain Session and Request information outside of ExceptionlessMiddleware
@@ -40,6 +40,11 @@ public static IApplicationBuilder UseExceptionless(this IApplicationBuilder app,
             return app.UseMiddleware<ExceptionlessMiddleware>(client);
         }
 
+        public static IApplicationBuilder UseExceptionless(this IApplicationBuilder app, Action<ExceptionlessConfiguration> configure) {
+            configure?.Invoke(ExceptionlessClient.Default.Configuration);
+            return app.UseExceptionless(ExceptionlessClient.Default);
+        }
+
         public static IApplicationBuilder UseExceptionless(this IApplicationBuilder app, IConfiguration configuration) {
             ExceptionlessClient.Default.Configuration.ReadFromConfiguration(configuration);
             return app.UseExceptionless(ExceptionlessClient.Default);

src/Platforms/Exceptionless.Extensions.Logging/ExceptionlessLoggerExtensions.cs

@@ -23,6 +23,7 @@ public static ExceptionlessLogLevel ToLogLevel(this LogLevel level) {
 
             return ExceptionlessLogLevel.Off;
         }
+
         /// <summary>
         /// Adds Exceptionless to the logging pipeline using the <see cref="ExceptionlessClient.Default"/>.
         /// </summary>
@@ -33,6 +34,7 @@ public static ILoggingBuilder AddExceptionless(this ILoggingBuilder builder, Exc
             builder.AddProvider(new ExceptionlessLoggerProvider(client ?? ExceptionlessClient.Default));
             return builder;
         }
+
         /// <summary>
         /// Adds Exceptionless to the logging pipeline using a new client with the provided api key.
         /// </summary>
@@ -55,6 +57,7 @@ public static ILoggingBuilder AddExceptionless(this ILoggingBuilder builder, str
 
             return builder;
         }
+
         /// <summary>
         /// Adds Exceptionless to the logging pipeline using a new client configured with the provided action.
         /// </summary>
@@ -65,6 +68,7 @@ public static ILoggingBuilder AddExceptionless(this ILoggingBuilder builder, Act
             builder.AddProvider(new ExceptionlessLoggerProvider(configure));
             return builder;
         }
+
         /// <summary>
         /// Adds Exceptionless to the logging pipeline using the <see cref="ExceptionlessClient.Default"/>.
         /// </summary>

src/Platforms/Exceptionless.Extensions.Logging/ExceptionlessLoggerProvider.cs

@@ -18,10 +18,8 @@ public ExceptionlessLoggerProvider(ExceptionlessClient client) {
         /// </summary>
         /// <param name="configure">An <see cref="Action{ExceptionlessConfiguration}"/> which will be used to configure created loggers.</param>
         public ExceptionlessLoggerProvider(Action<ExceptionlessConfiguration> configure) {
-            if (configure == null)
-                throw new ArgumentNullException(nameof(configure));
-
-            _client = new ExceptionlessClient(configure);
+            configure?.Invoke(ExceptionlessClient.Default.Configuration);
+            _client = ExceptionlessClient.Default;
             _shouldDispose = true;
         }