#183 Added some better optimizations / checks around SettingsManager.Apply

Author: niemyjski

src/Exceptionless/Configuration/SettingsManager.cs

@@ -88,10 +88,8 @@ public static void UpdateSettings(ExceptionlessConfiguration config, int? versio
 
                 // TODO: Store snapshot of settings after reading from config and attributes and use that to revert to defaults.
                 // Remove any existing server settings that are not in the new server settings.
-                foreach (string key in savedServerSettings.Keys.Except(response.Settings.Keys)) {
-                    if (config.Settings.ContainsKey(key))
-                        config.Settings.Remove(key);
-                }
+                foreach (string key in savedServerSettings.Keys.Except(response.Settings.Keys))
+                    config.Settings.Remove(key);
 
                 var persistedClientData = config.Resolver.Resolve<PersistedDictionary>();
                 persistedClientData[String.Concat(config.GetQueueName(), "-ServerConfigVersion")] = response.SettingsVersion.ToString();

src/Exceptionless/Models/Collections/SettingsDictionary.cs

@@ -319,7 +319,11 @@ public void Apply(IEnumerable<KeyValuePair<string, string>> values) {
                 return;
 
             foreach (var v in values) {
-                if (!ContainsKey(v.Key) || v.Value != this[v.Key])
+                if (v.Key == null)
+                    continue;
+
+                string temp;
+                if (!TryGetValue(v.Key, out temp) || v.Value != temp)
                     this[v.Key] = v.Value;
             }
         }