Added flag to see if the configuration is currently updating

Config header checks can force an update as well as the settings timer running on the client at the same time.

One problem with this is that SettingsManager is stateless and could have mutliple clients using it. This change can prevent multiple clients from updating at the same time. There are already checks in the client instance but they are not visible to the submission client

Author: niemyjski

src/Exceptionless/Configuration/SettingsManager.cs

@@ -8,6 +8,8 @@
 
 namespace Exceptionless.Configuration {
     public static class SettingsManager {
+        private static bool _isUpdatingSettings = false;
+
         public static void ApplySavedServerSettings(ExceptionlessConfiguration config) {
             if (config == null)
                 return;
@@ -33,7 +35,7 @@ private static SettingsDictionary GetSavedServerSettings(ExceptionlessConfigurat
                 var fileStorage = config.Resolver.GetFileStorage();
                 if (!fileStorage.Exists(configPath))
                     return new SettingsDictionary();
-            
+
                 return fileStorage.GetObject<SettingsDictionary>(configPath);
             } catch (Exception ex) {
                 config.Resolver.GetLog().FormattedError(typeof(SettingsManager), ex, "Unable to read and apply saved server settings: {0}", ex.Message);
@@ -69,10 +71,11 @@ public static void CheckVersion(int version, ExceptionlessConfiguration config)
         }
 
         public static void UpdateSettings(ExceptionlessConfiguration config, int? version = null) {
-            if (config == null || !config.IsValid || !config.Enabled)
+            if (config == null || !config.IsValid || !config.Enabled || _isUpdatingSettings)
                 return;
 
             try {
+                _isUpdatingSettings = true;
                 if (!version.HasValue || version < 0)
                     version = GetVersion(config);
 
@@ -98,6 +101,8 @@ public static void UpdateSettings(ExceptionlessConfiguration config, int? versio
                 fileStorage.SaveObject(GetConfigPath(config), response.Settings);
             } catch (Exception ex) {
                 config.Resolver.GetLog().Error(typeof(SettingsManager), ex, "Error occurred updating settings.");
+            } finally {
+                _isUpdatingSettings = false;
             }
         }