Fixed an issue where events wouldn't be submitted due to a large batch size.

Author: niemyjski

Source/Shared/Configuration/ExceptionlessConfiguration.cs

@@ -10,22 +10,25 @@ namespace Exceptionless {
     public class ExceptionlessConfiguration {
         private const string DEFAULT_SERVER_URL = "https://collector.exceptionless.io";
         private const string DEFAULT_USER_AGENT = "exceptionless/" + ThisAssembly.AssemblyFileVersion;
+        private const int DEFAULT_SUBMISSION_BATCH_SIZE = 50;
+
         private readonly IDependencyResolver _resolver;
         private bool _configLocked;
         private string _apiKey;
         private string _serverUrl;
+        private int _submissionBatchSize;
         private ValidationResult _validationResult;
         private readonly List<string> _exclusions = new List<string>(); 
 
         public ExceptionlessConfiguration(IDependencyResolver resolver) {
             ServerUrl = DEFAULT_SERVER_URL;
             UserAgent = DEFAULT_USER_AGENT;
+            SubmissionBatchSize = DEFAULT_SUBMISSION_BATCH_SIZE;
             Enabled = true;
             EnableSSL = true;
             DefaultTags = new TagSet();
             DefaultData = new DataDictionary();
             Settings = new SettingsDictionary();
-            SubmissionBatchSize = 50;
             if (resolver == null)
                 throw new ArgumentNullException("resolver");
             _resolver = resolver;
@@ -120,7 +123,13 @@ public string ApiKey {
         /// <summary>
         /// Maximum number of events that should be sent to the server together in a batch. (Defaults to 50)
         /// </summary>
-        public int SubmissionBatchSize { get; set; }
+        public int SubmissionBatchSize {
+            get { return _submissionBatchSize; }
+            set {
+                if (value > 0)
+                    _submissionBatchSize = value;
+            }
+        }
 
         /// <summary>
         /// A list of exclusion patterns that will automatically remove any data that matches them from any data submitted to the server.

Source/Shared/Queue/DefaultEventQueue.cs

@@ -65,7 +65,8 @@ public void Process() {
                 _storage.ReleaseStaleLocks(_config.GetQueueName());
 
                 DateTime maxCreatedDate = DateTime.Now;
-                var batch = _storage.GetEventBatch(_config.GetQueueName(), _serializer, _config.SubmissionBatchSize, maxCreatedDate);
+                int batchSize = _config.SubmissionBatchSize;
+                var batch = _storage.GetEventBatch(_config.GetQueueName(), _serializer, batchSize, maxCreatedDate);
                 while (batch.Any()) {
                     bool deleteBatch = true;
 
@@ -90,6 +91,14 @@ public void Process() {
                             // The service end point could not be found.
                             _log.FormattedError(typeof(DefaultEventQueue), "Error while trying to submit data: {0}", response.Message);
                             SuspendProcessing(TimeSpan.FromHours(4));
+                        } else if (response.RequestEntityTooLarge) {
+                            if (batchSize > 1) {
+                                _log.Error(typeof(DefaultEventQueue), "Event submission discarded for being too large. The event will be retried with a smaller batch size.");
+                                batchSize = Math.Max(1, (int)Math.Round(batchSize / 1.5d, 0));
+                                deleteBatch = false;
+                            } else {
+                                _log.Error(typeof(DefaultEventQueue), "Event submission discarded for being too large. The event will not be submitted.");
+                            }
                         } else if (!response.Success) {
                             _log.Error(typeof(DefaultEventQueue), String.Format("An error occurred while submitting events: {0}", response.Message));
                             SuspendProcessing();
@@ -113,7 +122,7 @@ public void Process() {
                     if (!deleteBatch || IsQueueProcessingSuspended)
                         break;
 
-                    batch = _storage.GetEventBatch(_config.GetQueueName(), _serializer, _config.SubmissionBatchSize, maxCreatedDate);
+                    batch = _storage.GetEventBatch(_config.GetQueueName(), _serializer, batchSize, maxCreatedDate);
                 }
             } catch (Exception ex) {
                 _log.Error(typeof(DefaultEventQueue), ex, String.Concat("An error occurred while processing the queue: ", ex.Message));

Source/Shared/Submission/SubmissionResponse.cs

@@ -22,6 +22,7 @@ public SubmissionResponse(int statusCode, string message = null) {
             PaymentRequired = (HttpStatusCode)statusCode == HttpStatusCode.PaymentRequired;
             UnableToAuthenticate = (HttpStatusCode)statusCode == HttpStatusCode.Unauthorized || (HttpStatusCode)statusCode == HttpStatusCode.Forbidden;
             NotFound = (HttpStatusCode)statusCode == HttpStatusCode.NotFound;
+            RequestEntityTooLarge = (HttpStatusCode)statusCode == HttpStatusCode.RequestEntityTooLarge;
         }
 
         public bool Success { get; private set; }
@@ -30,6 +31,7 @@ public SubmissionResponse(int statusCode, string message = null) {
         public bool PaymentRequired { get; private set; }
         public bool UnableToAuthenticate { get; private set; }
         public bool NotFound { get; private set; }
+        public bool RequestEntityTooLarge { get; private set; }
 
         public int StatusCode { get; private set; }
         public string Message { get; private set; }