Fixed an issue where submission clients would make requests when the configuration was invalid.

Author: niemyjski

src/Exceptionless/Extensions/ExceptionlessClientExtensions.cs

@@ -16,7 +16,9 @@ public static class ExceptionlessClientExtensions {
         /// <param name="client">The ExceptionlessClient.</param>
         /// <param name="apiKey">The API key that will be used when sending events to the server.</param>
         public static void Startup(this ExceptionlessClient client, string apiKey = null) {
-            client.Configuration.ApiKey = apiKey;
+            if (!String.IsNullOrEmpty(apiKey))
+                client.Configuration.ApiKey = apiKey;
+            
             client.Configuration.ReadAllConfig();
 
 #if !PORTABLE && !NETSTANDARD1_2

src/Exceptionless/Extensions/HttpClientExtensions.cs

@@ -0,0 +1,12 @@
+using System;
+using System.Net.Http;
+using System.Net.Http.Headers;
+using Exceptionless.Submission.Net;
+
+namespace Exceptionless.Extensions {
+    internal static class HttpClientExtensions {
+        public static void AddAuthorizationHeader(this HttpClient client, string apiKey) {
+            client.DefaultRequestHeaders.Authorization = new AuthenticationHeaderValue(ExceptionlessHeaders.Bearer, apiKey);
+        }
+    }
+}

src/Exceptionless/Submission/DefaultSubmissionClient.cs

@@ -18,10 +18,13 @@ public class DefaultSubmissionClient : ISubmissionClient, IDisposable {
         private readonly HttpClient _client;
 
         public DefaultSubmissionClient(ExceptionlessConfiguration config) {
-            _client = CreateHttpClient(config);
+            _client = CreateHttpClient(config.UserAgent);
         }
 
         public SubmissionResponse PostEvents(IEnumerable<Event> events, ExceptionlessConfiguration config, IJsonSerializer serializer) {
+            if (!config.IsValid)
+                return new SubmissionResponse(500, message: "Invalid client configuration settings");
+
             string data = serializer.Serialize(events);
             string url = String.Format("{0}/events", GetServiceEndPoint(config));
 
@@ -33,6 +36,7 @@ public SubmissionResponse PostEvents(IEnumerable<Event> events, ExceptionlessCon
                 if (data.Length > 1024 * 4)
                     content = new GzipContent(content);
 
+                _client.AddAuthorizationHeader(config.ApiKey);
                 response = _client.PostAsync(url, content).ConfigureAwait(false).GetAwaiter().GetResult();
             } catch (Exception ex) {
                 return new SubmissionResponse(500, message: ex.Message);
@@ -46,6 +50,9 @@ public SubmissionResponse PostEvents(IEnumerable<Event> events, ExceptionlessCon
         }
 
         public SubmissionResponse PostUserDescription(string referenceId, UserDescription description, ExceptionlessConfiguration config, IJsonSerializer serializer) {
+            if (!config.IsValid)
+                return new SubmissionResponse(500, message: "Invalid client configuration settings.");
+
             string data = serializer.Serialize(description);
             string url = String.Format("{0}/events/by-ref/{1}/user-description", GetServiceEndPoint(config), referenceId);
 
@@ -57,6 +64,7 @@ public SubmissionResponse PostUserDescription(string referenceId, UserDescriptio
                 if (data.Length > 1024 * 4)
                     content = new GzipContent(content);
 
+                _client.AddAuthorizationHeader(config.ApiKey);
                 response = _client.PostAsync(url, content).ConfigureAwait(false).GetAwaiter().GetResult();
             } catch (Exception ex) {
                 return new SubmissionResponse(500, message: ex.Message);
@@ -69,11 +77,15 @@ public SubmissionResponse PostUserDescription(string referenceId, UserDescriptio
             return new SubmissionResponse((int)response.StatusCode, GetResponseMessage(response));
         }
 
-        public SettingsResponse GetSettings(ExceptionlessConfiguration config, int version,  IJsonSerializer serializer) {
+        public SettingsResponse GetSettings(ExceptionlessConfiguration config, int version, IJsonSerializer serializer) {
+            if (!config.IsValid)
+                return new SettingsResponse(false, message: "Invalid client configuration settings.");
+
             string url = String.Format("{0}/projects/config?v={1}", GetServiceEndPoint(config), version);
 
             HttpResponseMessage response;
             try {
+                _client.AddAuthorizationHeader(config.ApiKey);
                 response = _client.GetAsync(url).ConfigureAwait(false).GetAwaiter().GetResult();
             } catch (Exception ex) {
                 var message = String.Concat("Unable to retrieve configuration settings. Exception: ", ex.GetMessage());
@@ -95,16 +107,20 @@ public SettingsResponse GetSettings(ExceptionlessConfiguration config, int versi
         }
 
         public void SendHeartbeat(string sessionIdOrUserId, bool closeSession, ExceptionlessConfiguration config) {
+            if (!config.IsValid)
+                return;
+
             string url = String.Format("{0}/events/session/heartbeat?id={1}&close={2}", GetHeartbeatServiceEndPoint(config), sessionIdOrUserId, closeSession);
             try {
+                _client.AddAuthorizationHeader(config.ApiKey);
                 _client.GetAsync(url).ConfigureAwait(false).GetAwaiter().GetResult();
             } catch (Exception ex) {
                 var log = config.Resolver.GetLog();
                 log.Error(String.Concat("Error submitting heartbeat: ", ex.GetMessage()));
             }
         }
 
-        private HttpClient CreateHttpClient(ExceptionlessConfiguration config) {
+        private HttpClient CreateHttpClient(string userAgent) {
 #if !NET45
             var handler = new HttpClientHandler { UseDefaultCredentials = true };
 
@@ -123,9 +139,8 @@ private HttpClient CreateHttpClient(ExceptionlessConfiguration config) {
 
             var client = new HttpClient(handler, true);
             client.DefaultRequestHeaders.Accept.Add(new MediaTypeWithQualityHeaderValue("application/json"));
-            client.DefaultRequestHeaders.Authorization = new AuthenticationHeaderValue(ExceptionlessHeaders.Bearer, config.ApiKey);
             client.DefaultRequestHeaders.ExpectContinue = false;
-            client.DefaultRequestHeaders.UserAgent.ParseAdd(config.UserAgent);
+            client.DefaultRequestHeaders.UserAgent.ParseAdd(userAgent);
 
             return client;
         }