Tweaked factory extensions.

Author: moogle001

src/Exceptionless.Extensions.Logging/ExceptionlessLoggerExtensions.cs

@@ -7,34 +7,29 @@ namespace Exceptionless
     public static class ExceptionlessLoggerExtensions
     {
         /// <summary>
-        /// Adds Exceptionless to the logging pipeline.
+        /// Adds Exceptionless to the logging pipeline using the default client.
         /// </summary>
         /// <param name="factory">The <see cref="ILoggerFactory"/>.</param>
-        /// <param name="apiKey">The project api key.</param>
         /// <returns>The <see cref="ILoggerFactory"/>.</returns>
-        public static ILoggerFactory AddExceptionless(this ILoggerFactory factory, string apiKey)
-        {
-            ExceptionlessConfiguration config = new ExceptionlessConfiguration(ExceptionlessClient.Default.Configuration.Resolver);
-            config.ApiKey = apiKey;
-
-            factory.AddProvider(new ExceptionlessLoggerProvider(config));
+        public static ILoggerFactory AddExceptionless(this ILoggerFactory factory) {
+            factory.AddProvider(new ExceptionlessLoggerProvider(ExceptionlessClient.Default));
             return factory;
         }
 
         /// <summary>
-        /// Adds Exceptionless to the logging pipeline.
+        /// Adds Exceptionless to the logging pipeline using a new client with the provided api key.
         /// </summary>
         /// <param name="factory">The <see cref="ILoggerFactory"/>.</param>
-        /// <param name="config">An <see cref="ExceptionlessConfiguration"/> containing additional settings and plugins. The project api key must be specified.</param>
+        /// <param name="apiKey">The project api key.</param>
         /// <returns>The <see cref="ILoggerFactory"/>.</returns>
-        public static ILoggerFactory AddExceptionless(this ILoggerFactory factory, ExceptionlessConfiguration config)
+        public static ILoggerFactory AddExceptionless(this ILoggerFactory factory, string apiKey)
         {
-            factory.AddProvider(new ExceptionlessLoggerProvider(config));
+            factory.AddProvider(new ExceptionlessLoggerProvider((config) => config.ApiKey = apiKey));
             return factory;
         }
 
         /// <summary>
-        /// Adds Exceptionless to the logging pipeline.
+        /// Adds Exceptionless to the logging pipeline using a new client configured with the provided action.
         /// </summary>
         /// <param name="factory">The <see cref="ILoggerFactory"/>.</param>
         /// <param name="configure">An <see cref="Action{ExceptionlessConfiguration}"/> that applies additional settings and plugins. The project api key must be specified.</param>

src/Exceptionless.Extensions.Logging/ExceptionlessLoggerProvider.cs

@@ -6,18 +6,18 @@ namespace Exceptionless.Extensions.Logging
     public class ExceptionlessLoggerProvider : ILoggerProvider
     {
         ExceptionlessClient _Client;
+        bool _ShouldDisposeClient;
 
         /// <summary>
         /// Initializes a new instance of the <see cref="ExceptionlessLoggerProvider"/> class.
         /// </summary>
         /// <param name="config">An <see cref="ExceptionlessConfiguration"/> which will be provided to created loggers.</param>
-        public ExceptionlessLoggerProvider(ExceptionlessConfiguration config)
-        {
-            if (config == null)
-                throw new ArgumentNullException(nameof(config));
+        public ExceptionlessLoggerProvider(ExceptionlessClient client) {
+            if (client == null)
+                throw new ArgumentNullException(nameof(client));
 
-            _Client = new ExceptionlessClient(config);
-            _Client.Startup();
+            _Client = client;
+            _ShouldDisposeClient = false;
         }
 
         /// <summary>
@@ -30,6 +30,7 @@ public ExceptionlessLoggerProvider(Action<ExceptionlessConfiguration> configure)
 
             _Client = new ExceptionlessClient(configure);
             _Client.Startup();
+            _ShouldDisposeClient = true;
         }
 
         /// <summary>
@@ -44,8 +45,12 @@ public ILogger CreateLogger(string categoryName)
 
         public void Dispose()
         {
-            _Client.Shutdown();
-            ((IDisposable)_Client).Dispose();
+            _Client.ProcessQueue();
+            if (_ShouldDisposeClient) 
+            {
+                _Client.Shutdown();
+                ((IDisposable)_Client).Dispose();
+            }
         }
     }
 }