Fixes #15 AggregateException that contained more than one inner exception would be discarded.

Author: niemyjski

Source/Shared/Exceptionless.Portable.csproj

@@ -71,6 +71,7 @@
     <Compile Include="Plugins\Default\040_ReferenceIdPlugin.cs" />
     <Compile Include="Plugins\Default\020_SimpleErrorPlugin.cs" />
     <Compile Include="Plugins\Default\050_EnvironmentInfoPlugin.cs" />
+    <Compile Include="Plugins\Default\015_HandleAggregateExceptionsPlugin.cs" />
     <Compile Include="Plugins\PriortyAttribute.cs" />
     <Compile Include="EventBuilder.cs" />
     <Compile Include="Events\ConfigurationUpdatedEventArgs.cs" />

Source/Shared/Plugins/Default/015_HandleAggregateExceptionsPlugin.cs

@@ -0,0 +1,30 @@
+using System;
+using Exceptionless.Dependency;
+using Exceptionless.Models;
+
+namespace Exceptionless.Plugins {
+    [Priority(15)]
+    public class HandleAggregateExceptionsPlugin : IEventPlugin {
+        public void Run(EventPluginContext context) {
+            var aggregateException = context.ContextData.GetException() as AggregateException;
+            if (aggregateException == null)
+                return;
+
+            var exception = aggregateException.Flatten();
+            if (exception.InnerExceptions.Count == 1) {
+                context.ContextData.SetException(exception.InnerException);
+                return;
+            }
+
+            foreach (var ex in exception.InnerExceptions) {
+                var ctx = new ContextData(context.ContextData);
+                ctx.SetException(ex);
+
+                var serializer = context.Resolver.GetJsonSerializer();
+                context.Client.SubmitEvent(serializer.Deserialize(serializer.Serialize(context.Event), typeof(Event)) as Event, ctx);
+            }
+
+            context.Cancel = true;
+        }
+    }
+}

Source/Shared/Plugins/EventPluginManager.cs

@@ -25,6 +25,7 @@ public static void Run(EventPluginContext context) {
 
         public static void AddDefaultPlugins(ExceptionlessConfiguration config) {
             config.AddPlugin<ConfigurationDefaultsPlugin>();
+            config.AddPlugin<HandleAggregateExceptionsPlugin>();
             config.AddPlugin<SimpleErrorPlugin>();
             config.AddPlugin<DuplicateCheckerPlugin>();
             config.AddPlugin<EnvironmentInfoPlugin>();

Source/Tests/Plugins/PluginTests.cs

@@ -8,6 +8,7 @@
 using Exceptionless.Plugins.Default;
 using Exceptionless.Models;
 using Exceptionless.Models.Data;
+using Exceptionless.Submission;
 using Exceptionless.Tests.Utility;
 using Xunit;
 using Xunit.Abstractions;
@@ -41,7 +42,7 @@ public void ConfigurationDefaults_EnsureNoDuplicateTagsOrData() {
             }
         }
 
-         [Fact]
+        [Fact]
         public void ConfigurationDefaults_IgnoredProperties() {
             var client = new ExceptionlessClient();
             client.Configuration.DefaultData.Add("Message", "Test");
@@ -58,6 +59,73 @@ public void ConfigurationDefaults_IgnoredProperties() {
             Assert.Equal(1, context.Event.Data.Count);
             Assert.Equal("Test", context.Event.Data["Message"]);
         }
+        
+        [Fact]
+        public void IgnoreUserAgentPlugin_DiscardBot() {
+            var client = new ExceptionlessClient();
+            client.Configuration.AddUserAgentBotPatterns("*Bot*");
+            var plugin = new IgnoreUserAgentPlugin();
+
+            var ev = new Event();
+            var context = new EventPluginContext(client, ev);
+            plugin.Run(context);
+            Assert.False(context.Cancel);
+
+            ev.AddRequestInfo(new RequestInfo { UserAgent = "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_3) AppleWebKit/601.4.4 (KHTML, like Gecko) Version/9.0.3 Safari/601.4.4" });
+            context = new EventPluginContext(client, ev);
+            plugin.Run(context);
+            Assert.False(context.Cancel);
+
+            ev.AddRequestInfo(new RequestInfo { UserAgent = "Mozilla/5.0 (compatible; bingbot/2.0 +http://www.bing.com/bingbot.htm)" });
+            context = new EventPluginContext(client, ev);
+            plugin.Run(context);
+            Assert.True(context.Cancel);
+        }
+
+        [Fact]
+        public void HandleAggregateExceptionsPlugin_SingleInnerException() {
+            var client = new ExceptionlessClient();
+            var plugin = new HandleAggregateExceptionsPlugin();
+            
+            var exceptionOne = new Exception("one");
+            var exceptionTwo = new Exception("two");
+
+            var context = new EventPluginContext(client, new Event());
+            context.ContextData.SetException(exceptionOne);
+            plugin.Run(context);
+            Assert.False(context.Cancel);
+            
+            context = new EventPluginContext(client, new Event());
+            context.ContextData.SetException(new AggregateException(exceptionOne));
+            plugin.Run(context);
+            Assert.False(context.Cancel);
+            Assert.Equal(exceptionOne, context.ContextData.GetException());
+
+            context = new EventPluginContext(client, new Event());
+            context.ContextData.SetException(new AggregateException(exceptionOne, exceptionTwo));
+            plugin.Run(context);
+            Assert.False(context.Cancel);
+            Assert.Equal(exceptionOne, context.ContextData.GetException());
+        }
+
+        [Fact]
+        public void HandleAggregateExceptionsPlugin_MultipleInnerException() {
+            var submissionClient = new InMemorySubmissionClient();
+            var client = new ExceptionlessClient("LhhP1C9gijpSKCslHHCvwdSIz298twx271n1l6xw");
+            client.Configuration.Resolver.Register<ISubmissionClient>(submissionClient);
+            
+            var plugin = new HandleAggregateExceptionsPlugin();
+            var exceptionOne = new Exception("one");
+            var exceptionTwo = new Exception("two");
+            
+            var context = new EventPluginContext(client, new Event());
+            context.ContextData.SetException(new AggregateException(exceptionOne, exceptionTwo));
+            plugin.Run(context);
+            Assert.True(context.Cancel);
+
+            client.ProcessQueue();
+            Assert.Equal(2, submissionClient.Events.Count);
+        }
 
         [Fact]
         public void ErrorPlugin_DiscardDuplicates() {
@@ -143,7 +211,7 @@ public void ErrorPlugin_CanProcessDifferentExceptionDataDictionaryTypes(IDiction
                 Assert.Equal(processedDataItemCount, error.Data.Count);
             }
         }
-
+        
         [Fact]
         public void ErrorPlugin_CopyExceptionDataToRootErrorData() {
             var errorPlugins = new List<IEventPlugin> {