Skip to content

Commit 9f956b5

Browse files
committed
Updated the default heartbeat interval to 5 minutes based on feedback.
1 parent 0878bfb commit 9f956b5

File tree

4 files changed

+8
-5
lines changed

4 files changed

+8
-5
lines changed

Exceptionless.Net.sln.DotSettings

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -542,6 +542,7 @@
542542
<s:Boolean x:Key="/Default/Environment/SettingsMigration/IsMigratorApplied/=JetBrains_002EReSharper_002EPsi_002ECSharp_002ECodeStyle_002ESettingsUpgrade_002EMigrateBlankLinesAroundFieldToBlankLinesAroundProperty/@EntryIndexedValue">True</s:Boolean>
543543
<s:Boolean x:Key="/Default/Environment/SettingsMigration/IsMigratorApplied/=JetBrains_002EReSharper_002EPsi_002ECSharp_002ECodeStyle_002ESettingsUpgrade_002EMigrateThisQualifierSettings/@EntryIndexedValue">True</s:Boolean>
544544
<s:Boolean x:Key="/Default/Environment/SettingsMigration/IsMigratorApplied/=JetBrains_002EReSharper_002EPsi_002EJavaScript_002ECodeStyle_002ESettingsUpgrade_002EJsCodeFormatterSettingsUpgrader/@EntryIndexedValue">True</s:Boolean>
545+
<s:Boolean x:Key="/Default/Environment/SettingsMigration/IsMigratorApplied/=JetBrains_002EReSharper_002EPsi_002EJavaScript_002ECodeStyle_002ESettingsUpgrade_002EJsWrapperSettingsUpgrader/@EntryIndexedValue">True</s:Boolean>
545546
<s:String x:Key="/Default/Environment/UnitTesting/JavaScriptUnitTestProviders/BrowserLocation/@EntryValue">C:\Users\Blake\AppData\Local\Google\Chrome\Application\chrome.exe</s:String>
546547
<s:Boolean x:Key="/Default/Environment/UnitTesting/SaveSessionState/@EntryValue">False</s:Boolean>
547548
<s:Boolean x:Key="/Default/Environment/UserInterface/CyclicSelectionInLists/@EntryValue">False</s:Boolean>

Source/Shared/Extensions/ExceptionlessConfigurationExtensions.cs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -92,16 +92,18 @@ public static string GetInstallId(this ExceptionlessConfiguration config) {
9292
/// </summary>
9393
/// <param name="config">Exceptionless configuration</param>
9494
/// <param name="sendHeartbeats">Controls whether heartbeat events are sent on an interval.</param>
95-
/// <param name="heartbeatInterval">The interval at which heartbeats are sent after the last sent event. The default is 30 seconds.</param>
95+
/// <param name="heartbeatInterval">The interval at which heartbeats are sent after the last sent event. The default is 5 minutes.</param>
9696
/// <param name="useSessionIdManagement">Allows you to manually control the session id. This is only recommended for single user desktop environments.</param>
9797
public static void UseSessions(this ExceptionlessConfiguration config, bool sendHeartbeats = true, TimeSpan? heartbeatInterval = null, bool useSessionIdManagement = false) {
9898
config.SessionsEnabled = true;
9999

100-
if (useSessionIdManagement)
100+
if (useSessionIdManagement)
101101
config.AddPlugin<SessionIdManagementPlugin>();
102102

103103
if (sendHeartbeats)
104104
config.AddPlugin(new HeartbeatPlugin(heartbeatInterval));
105+
else
106+
config.RemovePlugin<HeartbeatPlugin>();
105107
}
106108

107109
public static InMemoryExceptionlessLog UseInMemoryLogger(this ExceptionlessConfiguration config, LogLevel minLogLevel = LogLevel.Info) {

Source/Shared/Models/Client/Event.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ public Event() {
4444
public decimal? Value { get; set; }
4545

4646
/// <summary>
47-
/// The number of duplicated events
47+
/// The number of duplicated events.
4848
/// </summary>
4949
public int? Count { get; set; }
5050

Source/Shared/Plugins/Default/100_HeartbeatPlugin.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,9 @@ public class HeartbeatPlugin : IEventPlugin, IDisposable {
1212
/// <summary>
1313
/// Controls whether session heartbeats are sent.
1414
/// </summary>
15-
/// <param name="interval">The interval at which heartbeats are sent after the last sent event. The default is 30 seconds.</param>
15+
/// <param name="interval">The interval at which heartbeats are sent after the last sent event. The default is 5 minutes.</param>
1616
public HeartbeatPlugin(TimeSpan? interval = null) {
17-
_interval = interval.HasValue && interval.Value.Ticks > 0 ? interval.Value : TimeSpan.FromSeconds(30);
17+
_interval = interval.HasValue && interval.Value.Ticks > 0 ? interval.Value : TimeSpan.FromMinutes(5);
1818
}
1919

2020
public void Run(EventPluginContext context) {

0 commit comments

Comments
 (0)