Added plugin to cancel any session heartbeats that don't have an identity set

Author: niemyjski

Source/Shared/Exceptionless.Portable.csproj

@@ -62,7 +62,8 @@
     <Compile Include="Events\EventSubmittedEventArgs.cs" />
     <Compile Include="Plugins\Default\030_DuplicateCheckerPlugin.cs" />
     <Compile Include="Plugins\ContextData.cs" />
-    <Compile Include="Plugins\Default\100 _HeartbeatPlugin.cs" />
+    <Compile Include="Plugins\Default\1000_CancelSessionsWithNoUserPlugin.cs" />
+    <Compile Include="Plugins\Default\100_HeartbeatPlugin.cs" />
     <Compile Include="Plugins\Default\ActionPlugin.cs" />
     <Compile Include="Plugins\Default\010_ConfigurationDefaultsPlugin.cs" />
     <Compile Include="Plugins\Default\090_SubmissionMethodPlugin.cs" />

Source/Shared/Extensions/ExceptionlessConfigurationExtensions.cs

@@ -88,10 +88,12 @@ public static string GetInstallId(this ExceptionlessConfiguration config) {
         }
 
         public static void UseSessions(this ExceptionlessConfiguration config, bool sendHeartbeats = true) {
-           if (sendHeartbeats)
+            config.AddPlugin<CancelSessionsWithNoUserPlugin>();
+
+            if (sendHeartbeats)
                 config.AddPlugin<HeartbeatPlugin>();
         }
-        
+
         public static void UseDebugLogger(this ExceptionlessConfiguration config, LogLevel minLogLevel = LogLevel.Info) {
             config.Resolver.Register<IExceptionlessLog>(new DebugExceptionlessLog { MinimumLogLevel = minLogLevel });
         }

Source/Shared/Plugins/Default/1000_CancelSessionsWithNoUserPlugin.cs

@@ -0,0 +1,18 @@
+using System;
+
+namespace Exceptionless.Plugins.Default {
+    [Priority(1000)]
+    public class CancelSessionsWithNoUserPlugin : IEventPlugin {
+        public void Run(EventPluginContext context) {
+            if (!context.Event.IsSessionStart() && !context.Event.IsSessionEnd() && !context.Event.IsSessionHeartbeat())
+                return;
+
+            var user = context.Event.GetUserIdentity();
+            if (user != null && !String.IsNullOrEmpty(user.Identity))
+                return;
+
+            context.Log.Info("Cancelling session event as no user identity was specified.");
+            context.Cancel = true;
+        }
+    }
+}

Source/Shared/Plugins/Default/100 _HeartbeatPlugin.cs renamed to Source/Shared/Plugins/Default/100_HeartbeatPlugin.cs

@@ -95,21 +95,6 @@ public void ErrorPlugin_IgnoredProperties() {
             }
         }
 
-        [Theory(Skip = "TODO: This needs to be skipped until the client is sending session start and end.")]
-        [InlineData(Event.KnownTypes.Error)]
-        [InlineData(Event.KnownTypes.FeatureUsage)]
-        [InlineData(Event.KnownTypes.Log)]
-        [InlineData(Event.KnownTypes.NotFound)]
-        [InlineData(Event.KnownTypes.SessionEnd)]
-        public void EnvironmentInfo_IncorrectEventType(string eventType) {
-            var client = new ExceptionlessClient();
-            var context = new EventPluginContext(client, new Event { Type = eventType });
-
-            var plugin = new EnvironmentInfoPlugin();
-            plugin.Run(context);
-            Assert.Equal(0, context.Event.Data.Count);
-        }
-
         [Fact]
         public void EnvironmentInfo_CanRunInParallel() {
             var client = new ExceptionlessClient();
@@ -193,7 +178,27 @@ public void PrivateInformation_WillNotUpdateIdentity() {
             Assert.Equal("Blake", user.Name);
         }
 
-
+        [Theory]
+        [InlineData(Event.KnownTypes.Error, null, false)]
+        [InlineData(Event.KnownTypes.FeatureUsage, null, false)]
+        [InlineData(Event.KnownTypes.Log, null, false)]
+        [InlineData(Event.KnownTypes.NotFound, null, false)]
+        [InlineData(Event.KnownTypes.Session, null, true)]
+        [InlineData(Event.KnownTypes.Session, "123456789", false)]
+        [InlineData(Event.KnownTypes.SessionEnd, null, true)]
+        [InlineData(Event.KnownTypes.SessionEnd, "123456789", false)]
+        [InlineData(Event.KnownTypes.SessionHeartbeat, null, true)]
+        [InlineData(Event.KnownTypes.SessionHeartbeat, "123456789", false)]
+        public void CancelSessionsWithNoUserTest(string eventType, string identity, bool cancelled) {
+            var ev = new Event { Type = eventType };
+            ev.SetUserIdentity(identity);
+
+            var context = new EventPluginContext(new ExceptionlessClient(), ev);
+            var plugin = new CancelSessionsWithNoUserPlugin();
+            plugin.Run(context);
+            Assert.Equal(cancelled, context.Cancel);
+        }
+        
         [Fact]
         public void LazyLoadAndRemovePlugin() {
             var configuration = new ExceptionlessConfiguration(DependencyResolver.Default);