Added UpdateSettingsWhenIdleInterval to allow the configuration to always be up-to-date.

Author: niemyjski

Source/Shared/Configuration/ExceptionlessConfiguration.cs

@@ -22,6 +22,7 @@ public class ExceptionlessConfiguration {
         private string _serverUrl;
         private int _submissionBatchSize;
         private ValidationResult _validationResult;
+        private TimeSpan _updateSettingsWhenIdleInterval;
         private readonly List<string> _exclusions = new List<string>();
         private readonly List<string> _userAgentBotPatterns = new List<string>();
         private readonly List<Func<Event, bool>> _eventExclusions = new List<Func<Event, bool>>();
@@ -41,6 +42,7 @@ public ExceptionlessConfiguration(IDependencyResolver resolver) {
             DefaultData = new DataDictionary();
             Settings = new SettingsDictionary();
             IncludePrivateInformation = true;
+            _updateSettingsWhenIdleInterval = TimeSpan.FromMinutes(2);
 
             _resolver = resolver;
 
@@ -152,6 +154,21 @@ public string ApiKey {
         /// </summary>
         public SettingsDictionary Settings { get; private set; }
 
+        /// <summary>
+        /// How often the client should check for updated server settings when idle. The default is every 2 minutes. 
+        /// </summary>
+        public TimeSpan UpdateSettingsWhenIdleInterval {
+            get { return _updateSettingsWhenIdleInterval; }
+            set {
+                if (value > TimeSpan.Zero && value < TimeSpan.FromSeconds(15))
+                    _updateSettingsWhenIdleInterval = TimeSpan.FromSeconds(15);
+                else if (value <= TimeSpan.Zero)
+                    _updateSettingsWhenIdleInterval = TimeSpan.FromMilliseconds(-1);
+                else
+                    _updateSettingsWhenIdleInterval = value;
+            }
+        }
+
         /// <summary>
         /// Gets or sets a value indicating whether to include private information about the local machine.
         /// </summary>

Source/Shared/Exceptionless.Portable.csproj

@@ -76,7 +76,6 @@
     <Compile Include="Plugins\Default\050_EnvironmentInfoPlugin.cs" />
     <Compile Include="Plugins\Default\005_HandleAggregateExceptionsPlugin.cs" />
     <Compile Include="Plugins\Default\010_EventExclusionPlugin.cs" />
-    <Compile Include="Plugins\Default\1020_UpdateConfigurationSettingsWhileIdlePlugin.cs" />
     <Compile Include="Plugins\PriortyAttribute.cs" />
     <Compile Include="EventBuilder.cs" />
     <Compile Include="Events\ConfigurationUpdatedEventArgs.cs" />

Source/Shared/ExceptionlessClient.cs

@@ -1,5 +1,7 @@
 using System;
+using System.Threading;
 using System.Threading.Tasks;
+using Exceptionless.Configuration;
 using Exceptionless.Dependency;
 using Exceptionless.Plugins;
 using Exceptionless.Logging;
@@ -10,6 +12,7 @@
 
 namespace Exceptionless {
     public class ExceptionlessClient : IDisposable {
+        private readonly Timer _updateSettingsTimer;
         private readonly Lazy<IExceptionlessLog> _log;
         private readonly Lazy<IEventQueue> _queue;
         private readonly Lazy<ISubmissionClient> _submissionClient;
@@ -41,6 +44,9 @@ public ExceptionlessClient(ExceptionlessConfiguration configuration) {
 
             _submissionClient = new Lazy<ISubmissionClient>(() => Configuration.Resolver.GetSubmissionClient());
             _lastReferenceIdManager = new Lazy<ILastReferenceIdManager>(() => Configuration.Resolver.GetLastReferenceIdManager());
+
+            var initialDelay = configuration.UpdateSettingsWhenIdleInterval > TimeSpan.Zero ? TimeSpan.FromSeconds(5) : TimeSpan.FromMilliseconds(-1);
+            _updateSettingsTimer = new Timer(state => SettingsManager.UpdateSettings(Configuration), null, initialDelay, configuration.UpdateSettingsWhenIdleInterval);
         }
 
         public ExceptionlessConfiguration Configuration { get; private set; }
@@ -175,6 +181,7 @@ public void SubmitEvent(Event ev, ContextData pluginContextData = null) {
             }
 
             OnSubmittedEvent(new EventSubmittedEventArgs(this, ev, pluginContextData));
+            _updateSettingsTimer.Change(Configuration.UpdateSettingsWhenIdleInterval, Configuration.UpdateSettingsWhenIdleInterval);
         }
 
         /// <summary>Creates a new instance of <see cref="Event" />.</summary>

Source/Shared/Plugins/Default/1020_UpdateConfigurationSettingsWhileIdlePlugin.cs

@@ -32,7 +32,6 @@ public static void AddDefaultPlugins(ExceptionlessConfiguration config) {
             config.AddPlugin<EnvironmentInfoPlugin>();
             config.AddPlugin<SubmissionMethodPlugin>();
             config.AddPlugin<CancelSessionsWithNoUserPlugin>();
-            config.AddPlugin<UpdateConfigurationSettingsWhileIdlePlugin>(new UpdateConfigurationSettingsWhileIdlePlugin(config));
         }
     }
 }

Source/Shared/Plugins/EventPluginManager.cs

@@ -52,12 +52,12 @@ public void Process() {
             if (_processingQueue)
                 return;
 
-            _log.Trace(typeof(DefaultEventQueue), "Processing queue...");
             if (!_config.Enabled) {
                 _log.Info(typeof(DefaultEventQueue), "Configuration is disabled. The queue will not be processed.");
                 return;
             }
 
+            _log.Trace(typeof(DefaultEventQueue), "Processing queue...");
             _processingQueue = true;
 
             try {