Revert all the equality compare changes.

Edward Meng · Edward Meng · commit b101554270e0 · 2017-11-14T05:29:42.000+08:00
diff --git a/src/Exceptionless/Extensions/CollectionEqualityExtensions.cs b/src/Exceptionless/Extensions/CollectionEqualityExtensions.cs
@@ -40,18 +40,6 @@ public static bool CollectionEquals<T>(this IEnumerable<T> source, IEnumerable<T
         }
 
         public static bool CollectionEquals<TKey,TValue>(this IDictionary<TKey, TValue> source, IDictionary<TKey, TValue> other) {
-            if (ReferenceEquals(null, source) && ReferenceEquals(null, other)) {
-                return true;
-            }
-
-            if (ReferenceEquals(null, source) || ReferenceEquals(null, other)) {
-                return false;
-            }
-
-            if (ReferenceEquals(source, other)) {
-                return true;
-            }
-
             if (source.Count != other.Count) {
                 return false;
             }
diff --git a/src/Exceptionless/Models/Client/Data/EnvironmentInfo.cs b/src/Exceptionless/Models/Client/Data/EnvironmentInfo.cs
@@ -101,7 +101,7 @@ public EnvironmentInfo() {
         public DataDictionary Data { get; set; }
 
         protected bool Equals(EnvironmentInfo other) {
-            return ProcessorCount == other.ProcessorCount && TotalPhysicalMemory == other.TotalPhysicalMemory && AvailablePhysicalMemory == other.AvailablePhysicalMemory && string.Equals(CommandLine, other.CommandLine) && string.Equals(ProcessName, other.ProcessName) && string.Equals(ProcessId, other.ProcessId) && ProcessMemorySize == other.ProcessMemorySize && string.Equals(ThreadName, other.ThreadName) && string.Equals(ThreadId, other.ThreadId) && string.Equals(Architecture, other.Architecture) && string.Equals(OSName, other.OSName) && string.Equals(OSVersion, other.OSVersion) && string.Equals(IpAddress, other.IpAddress) && string.Equals(MachineName, other.MachineName) && string.Equals(InstallId, other.InstallId) && string.Equals(RuntimeVersion, other.RuntimeVersion) && Data.CollectionEquals(other.Data);
+            return ProcessorCount == other.ProcessorCount && TotalPhysicalMemory == other.TotalPhysicalMemory && AvailablePhysicalMemory == other.AvailablePhysicalMemory && string.Equals(CommandLine, other.CommandLine) && string.Equals(ProcessName, other.ProcessName) && string.Equals(ProcessId, other.ProcessId) && ProcessMemorySize == other.ProcessMemorySize && string.Equals(ThreadName, other.ThreadName) && string.Equals(ThreadId, other.ThreadId) && string.Equals(Architecture, other.Architecture) && string.Equals(OSName, other.OSName) && string.Equals(OSVersion, other.OSVersion) && string.Equals(IpAddress, other.IpAddress) && string.Equals(MachineName, other.MachineName) && string.Equals(InstallId, other.InstallId) && string.Equals(RuntimeVersion, other.RuntimeVersion) && Equals(Data, other.Data);
         }
 
         public override bool Equals(object obj) {
diff --git a/src/Exceptionless/Models/Client/Data/InnerError.cs b/src/Exceptionless/Models/Client/Data/InnerError.cs
@@ -43,7 +43,7 @@ public InnerError() {
         public Method TargetMethod { get; set; }
 
         protected bool Equals(InnerError other) {
-            return string.Equals(Message, other.Message) && string.Equals(Type, other.Type) && string.Equals(Code, other.Code) && Data.CollectionEquals(other.Data) && Equals(Inner, other.Inner) && StackTrace.CollectionEquals(other.StackTrace) && Equals(TargetMethod, other.TargetMethod);
+            return string.Equals(Message, other.Message) && string.Equals(Type, other.Type) && string.Equals(Code, other.Code) && Equals(Data, other.Data) && Equals(Inner, other.Inner) && StackTrace.CollectionEquals(other.StackTrace) && Equals(TargetMethod, other.TargetMethod);
         }
 
         public override bool Equals(object obj) {
diff --git a/src/Exceptionless/Models/Client/Data/ManualStackingInfo.cs b/src/Exceptionless/Models/Client/Data/ManualStackingInfo.cs
@@ -29,25 +29,5 @@ public ManualStackingInfo(IDictionary<string, string> signatureData) : this(null
         /// Key value pair that determines how the event is stacked.
         /// </summary>
         public IDictionary<string, string> SignatureData { get; set; }
-
-        protected bool Equals(ManualStackingInfo other) {
-            return string.Equals(Title, other.Title) && SignatureData.CollectionEquals(other.SignatureData);
-        }
-
-        public override bool Equals(object obj) {
-            if (ReferenceEquals(null, obj))
-                return false;
-            if (ReferenceEquals(this, obj))
-                return true;
-            if (obj.GetType() != this.GetType())
-                return false;
-            return Equals((ManualStackingInfo)obj);
-        }
-
-        public override int GetHashCode() {
-            unchecked {
-                return ((Title != null ? Title.GetHashCode() : 0) * 397) ^ (SignatureData != null ? SignatureData.GetCollectionHashCode() : 0);
-            }
-        }
     }
 }
diff --git a/src/Exceptionless/Models/Client/Data/Method.cs b/src/Exceptionless/Models/Client/Data/Method.cs
@@ -20,7 +20,7 @@ public Method() {
         public ParameterCollection Parameters { get; set; }
 
         protected bool Equals(Method other) {
-            return IsSignatureTarget == other.IsSignatureTarget && string.Equals(DeclaringNamespace, other.DeclaringNamespace) && string.Equals(DeclaringType, other.DeclaringType) && string.Equals(Name, other.Name) && Data.CollectionEquals(other.Data) && GenericArguments.CollectionEquals(other.GenericArguments) && Parameters.CollectionEquals(other.Parameters);
+            return IsSignatureTarget == other.IsSignatureTarget && string.Equals(DeclaringNamespace, other.DeclaringNamespace) && string.Equals(DeclaringType, other.DeclaringType) && string.Equals(Name, other.Name) && Equals(Data, other.Data) && GenericArguments.CollectionEquals(other.GenericArguments) && Parameters.CollectionEquals(other.Parameters);
         }
 
         public override bool Equals(object obj) {
diff --git a/src/Exceptionless/Models/Client/Data/Module.cs b/src/Exceptionless/Models/Client/Data/Module.cs
@@ -27,7 +27,7 @@ public override string ToString() {
         }
 
         protected bool Equals(Module other) {
-            return ModuleId == other.ModuleId && string.Equals(Name, other.Name) && string.Equals(Version, other.Version) && IsEntry == other.IsEntry && CreatedDate.Equals(other.CreatedDate) && ModifiedDate.Equals(other.ModifiedDate) && Data.CollectionEquals(other.Data);
+            return ModuleId == other.ModuleId && string.Equals(Name, other.Name) && string.Equals(Version, other.Version) && IsEntry == other.IsEntry && CreatedDate.Equals(other.CreatedDate) && ModifiedDate.Equals(other.ModifiedDate) && Equals(Data, other.Data);
         }
 
         public override bool Equals(object obj) {
diff --git a/src/Exceptionless/Models/Client/Data/Parameter.cs b/src/Exceptionless/Models/Client/Data/Parameter.cs
@@ -15,7 +15,7 @@ public Parameter() {
         public GenericArguments GenericArguments { get; set; }
 
         protected bool Equals(Parameter other) {
-            return string.Equals(Name, other.Name) && string.Equals(Type, other.Type) && string.Equals(TypeNamespace, other.TypeNamespace) && Data.CollectionEquals(other.Data) && GenericArguments.CollectionEquals(other.GenericArguments);
+            return string.Equals(Name, other.Name) && string.Equals(Type, other.Type) && string.Equals(TypeNamespace, other.TypeNamespace) && Equals(Data, other.Data) && GenericArguments.CollectionEquals(other.GenericArguments);
         }
 
         public override bool Equals(object obj) {
diff --git a/src/Exceptionless/Models/Client/Data/RequestInfo.cs b/src/Exceptionless/Models/Client/Data/RequestInfo.cs
@@ -70,7 +70,7 @@ public RequestInfo() {
         public DataDictionary Data { get; set; }
 
         protected bool Equals(RequestInfo other) {
-            return string.Equals(UserAgent, other.UserAgent) && string.Equals(HttpMethod, other.HttpMethod) && IsSecure == other.IsSecure && string.Equals(Host, other.Host) && Port == other.Port && string.Equals(Path, other.Path) && string.Equals(Referrer, other.Referrer) && string.Equals(ClientIpAddress, other.ClientIpAddress) && Cookies.CollectionEquals(other.Cookies) && QueryString.CollectionEquals(other.QueryString) && Data.CollectionEquals(other.Data);
+            return string.Equals(UserAgent, other.UserAgent) && string.Equals(HttpMethod, other.HttpMethod) && IsSecure == other.IsSecure && string.Equals(Host, other.Host) && Port == other.Port && string.Equals(Path, other.Path) && string.Equals(Referrer, other.Referrer) && string.Equals(ClientIpAddress, other.ClientIpAddress) && Cookies.CollectionEquals(other.Cookies) && QueryString.CollectionEquals(other.QueryString) && Equals(Data, other.Data);
         }
 
         public override bool Equals(object obj) {
diff --git a/src/Exceptionless/Models/Client/Data/SimpleError.cs b/src/Exceptionless/Models/Client/Data/SimpleError.cs
@@ -32,7 +32,7 @@ public SimpleError() {
         public SimpleError Inner { get; set; }
 
         protected bool Equals(SimpleError other) {
-            return string.Equals(Message, other.Message) && string.Equals(Type, other.Type) && string.Equals(StackTrace, other.StackTrace) && Data.CollectionEquals(other.Data) && Equals(Inner, other.Inner);
+            return string.Equals(Message, other.Message) && string.Equals(Type, other.Type) && string.Equals(StackTrace, other.StackTrace) && Equals(Data, other.Data) && Equals(Inner, other.Inner);
         }
 
         public override bool Equals(object obj) {
diff --git a/src/Exceptionless/Models/Client/Data/StackFrame.cs b/src/Exceptionless/Models/Client/Data/StackFrame.cs
@@ -7,7 +7,7 @@ public class StackFrame : Method {
         public int Column { get; set; }
 
         protected bool Equals(StackFrame other) {
-            return base.Equals(other) && string.Equals(FileName, other.FileName) && LineNumber == other.LineNumber && Column == other.Column;
+            return base.Equals(other) && string.Equals(FileName, other.FileName);
         }
 
         public override bool Equals(object obj) {
@@ -24,8 +24,6 @@ public override int GetHashCode() {
             unchecked {
                 int hashCode = base.GetHashCode();
                 hashCode = (hashCode * 397) ^ (FileName == null ? 0 : FileName.GetHashCode());
-                hashCode = (hashCode * 397) ^ LineNumber.GetHashCode();
-                hashCode = (hashCode * 397) ^ Column.GetHashCode();
                 return hashCode;
             }
         }
diff --git a/src/Exceptionless/Models/Client/Data/UserDescription.cs b/src/Exceptionless/Models/Client/Data/UserDescription.cs
@@ -23,7 +23,7 @@ public UserDescription(string emailAddress, string description) : this() {
         public DataDictionary Data { get; set; }
 
         protected bool Equals(UserDescription other) {
-            return string.Equals(EmailAddress, other.EmailAddress) && string.Equals(Description, other.Description) && Data.CollectionEquals(other.Data);
+            return string.Equals(EmailAddress, other.EmailAddress) && string.Equals(Description, other.Description) && Equals(Data, other.Data);
         }
 
         public override bool Equals(object obj) {
diff --git a/src/Exceptionless/Models/Client/Data/UserInfo.cs b/src/Exceptionless/Models/Client/Data/UserInfo.cs
@@ -32,7 +32,7 @@ public UserInfo(string identity, string name) : this(identity) {
         public DataDictionary Data { get; set; }
 
         protected bool Equals(UserInfo other) {
-            return string.Equals(Identity, other.Identity) && string.Equals(Name, other.Name) && Data.CollectionEquals(other.Data);
+            return string.Equals(Identity, other.Identity) && string.Equals(Name, other.Name) && Equals(Data, other.Data);
         }
 
         public override bool Equals(object obj) {
diff --git a/src/Exceptionless/Models/Client/Event.cs b/src/Exceptionless/Models/Client/Event.cs
@@ -59,7 +59,7 @@ public Event() {
         public string ReferenceId { get; set; }
 
         protected bool Equals(Event other) {
-            return string.Equals(Type, other.Type) && string.Equals(Source, other.Source) && Tags.CollectionEquals(other.Tags) && string.Equals(Message, other.Message) && string.Equals(Geo, other.Geo) && Value == other.Value && Data.CollectionEquals(other.Data);
+            return string.Equals(Type, other.Type) && string.Equals(Source, other.Source) && Tags.CollectionEquals(other.Tags) && string.Equals(Message, other.Message) && string.Equals(Geo, other.Geo) && Value == other.Value && Equals(Data, other.Data);
         }
 
         public override bool Equals(object obj) {
diff --git a/test/Exceptionless.TestHarness/Serializer/EventEqualityComparer.cs b/test/Exceptionless.TestHarness/Serializer/EventEqualityComparer.cs
diff --git a/test/Exceptionless.TestHarness/Serializer/StorageSerializerTestBase.cs b/test/Exceptionless.TestHarness/Serializer/StorageSerializerTestBase.cs
@@ -55,7 +55,7 @@ private void AssertEventSerialize(Event evt) {
                 newEvent = serializer.Deserialize<Event>(memory);
             }
 
-            Assert.Equal(evt, newEvent,new EventEqualityComparer());
+            Assert.Equal(evt, newEvent);
         }
 
         [Fact]
diff --git a/test/Exceptionless.Tests/Plugins/PluginTests.cs b/test/Exceptionless.Tests/Plugins/PluginTests.cs
@@ -856,69 +856,6 @@ public void VerifyDeduplicationFromFiles() {
             }
         }
 
-        [Fact(Skip = "The duplicate checker verify events with hash code is not accurate.")]
-        public void VerifyDeduplicationWithSameHashCode() {
-            var client = CreateClient();
-            using (var duplicateCheckerPlugin = new DuplicateCheckerPlugin(TimeSpan.FromMilliseconds(40))) {
-                int firstEventHashCode;
-                {
-                    var builder = client.CreateEvent().SetMessage("Test123");
-                    firstEventHashCode = builder.Target.GetHashCode();
-                    var context = new EventPluginContext(client, builder.Target, builder.PluginContextData);
-                    duplicateCheckerPlugin.Run(context);
-                    Assert.False(context.Cancel);
-                    Assert.Null(context.Event.Count);
-                }
-                {
-                    var builder = client.CreateEvent().SetMessage("Test");
-                    // Calculate the property value for event that will generate the same hashcode.
-                    int propertyValue;
-                    unchecked {
-                        var secondEventHashCode = builder.Target.Type?.GetHashCode() ?? 0;
-                        secondEventHashCode = (secondEventHashCode * 397) ^ (builder.Target.Source?.GetHashCode() ?? 0);
-                        secondEventHashCode = (secondEventHashCode * 397) ^ (builder.Target.Tags?.GetCollectionHashCode() ?? 0);
-                        secondEventHashCode = (secondEventHashCode * 397) ^ (builder.Target.Message?.GetHashCode() ?? 0);
-                        secondEventHashCode = (secondEventHashCode * 397) ^ (builder.Target.Geo?.GetHashCode() ?? 0);
-                        secondEventHashCode = (secondEventHashCode * 397) ^ builder.Target.Value.GetHashCode();
-
-                        var hashCode = firstEventHashCode ^ (secondEventHashCode * 397);
-                        var assemblyQualifiedName = typeof(object).AssemblyQualifiedName;
-                        var assemblyHashCode = assemblyQualifiedName?.GetHashCode() ?? 0;
-                        var kvpHash = hashCode ^ (assemblyHashCode * 397);
-                        var keyHash = "Value".GetHashCode();
-                        propertyValue = kvpHash ^ (keyHash * 397);
-                    }
-
-                    builder.SetProperty("Value", propertyValue);
-                    var context = new EventPluginContext(client, builder.Target, builder.PluginContextData);
-                    duplicateCheckerPlugin.Run(context);
-                    Assert.False(context.Cancel);
-                    Assert.Null(context.Event.Count);
-                }
-            }
-        }
-
-        [Fact(Skip = "The duplicate checker does not support List value of data dictionary.")]
-        public void VerifyDeduplicationWithSameListData() {
-            var client = CreateClient();
-            using (var duplicateCheckerPlugin = new DuplicateCheckerPlugin(TimeSpan.FromMilliseconds(40))) {
-                for (int index = 0; index < 3; index++) {
-                    var builder = client.CreateEvent().SetMessage("Test").SetProperty("Values",new List<int>(){1,2,3});
-                    var context = new EventPluginContext(client, builder.Target, builder.PluginContextData);
-                    duplicateCheckerPlugin.Run(context);
-                    if (index == 0) {
-                        Assert.False(context.Cancel);
-                        Assert.Null(context.Event.Count);
-                    }
-                    else {
-                        Assert.True(context.Cancel);
-                        Thread.Sleep(50);
-                        Assert.Equal(1, context.Event.Count);
-                    }
-                }
-            }
-        }
-
         private ExceptionWithOverriddenStackTrace GetExceptionWithOverriddenStackTrace(string message = "Test") {
             try {
                 throw new ExceptionWithOverriddenStackTrace(message);

Original file line number	Diff line number	Diff line change
`@@ -101,7 +101,7 @@ public EnvironmentInfo() {`
`101`	`101`	`public DataDictionary Data { get; set; }`
`102`	`102`
`103`	`103`	`protected bool Equals(EnvironmentInfo other) {`
`104`		- return ProcessorCount == other.ProcessorCount && TotalPhysicalMemory == other.TotalPhysicalMemory && AvailablePhysicalMemory == other.AvailablePhysicalMemory && string.Equals(CommandLine, other.CommandLine) && string.Equals(ProcessName, other.ProcessName) && string.Equals(ProcessId, other.ProcessId) && ProcessMemorySize == other.ProcessMemorySize && string.Equals(ThreadName, other.ThreadName) && string.Equals(ThreadId, other.ThreadId) && string.Equals(Architecture, other.Architecture) && string.Equals(OSName, other.OSName) && string.Equals(OSVersion, other.OSVersion) && string.Equals(IpAddress, other.IpAddress) && string.Equals(MachineName, other.MachineName) && string.Equals(InstallId, other.InstallId) && string.Equals(RuntimeVersion, other.RuntimeVersion) && Data.CollectionEquals(other.Data);
	`104`	+ return ProcessorCount == other.ProcessorCount && TotalPhysicalMemory == other.TotalPhysicalMemory && AvailablePhysicalMemory == other.AvailablePhysicalMemory && string.Equals(CommandLine, other.CommandLine) && string.Equals(ProcessName, other.ProcessName) && string.Equals(ProcessId, other.ProcessId) && ProcessMemorySize == other.ProcessMemorySize && string.Equals(ThreadName, other.ThreadName) && string.Equals(ThreadId, other.ThreadId) && string.Equals(Architecture, other.Architecture) && string.Equals(OSName, other.OSName) && string.Equals(OSVersion, other.OSVersion) && string.Equals(IpAddress, other.IpAddress) && string.Equals(MachineName, other.MachineName) && string.Equals(InstallId, other.InstallId) && string.Equals(RuntimeVersion, other.RuntimeVersion) && Equals(Data, other.Data);
`105`	`105`	`}`
`106`	`106`
`107`	`107`	`public override bool Equals(object obj) {`
Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ public InnerError() {`
`43`	`43`	`public Method TargetMethod { get; set; }`
`44`	`44`
`45`	`45`	`protected bool Equals(InnerError other) {`
`46`		`- return string.Equals(Message, other.Message) && string.Equals(Type, other.Type) && string.Equals(Code, other.Code) && Data.CollectionEquals(other.Data) && Equals(Inner, other.Inner) && StackTrace.CollectionEquals(other.StackTrace) && Equals(TargetMethod, other.TargetMethod);`
	`46`	`+ return string.Equals(Message, other.Message) && string.Equals(Type, other.Type) && string.Equals(Code, other.Code) && Equals(Data, other.Data) && Equals(Inner, other.Inner) && StackTrace.CollectionEquals(other.StackTrace) && Equals(TargetMethod, other.TargetMethod);`
`47`	`47`	`}`
`48`	`48`
`49`	`49`	`public override bool Equals(object obj) {`
Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@ public Method() {`
`20`	`20`	`public ParameterCollection Parameters { get; set; }`
`21`	`21`
`22`	`22`	`protected bool Equals(Method other) {`
`23`		`- return IsSignatureTarget == other.IsSignatureTarget && string.Equals(DeclaringNamespace, other.DeclaringNamespace) && string.Equals(DeclaringType, other.DeclaringType) && string.Equals(Name, other.Name) && Data.CollectionEquals(other.Data) && GenericArguments.CollectionEquals(other.GenericArguments) && Parameters.CollectionEquals(other.Parameters);`
	`23`	`+ return IsSignatureTarget == other.IsSignatureTarget && string.Equals(DeclaringNamespace, other.DeclaringNamespace) && string.Equals(DeclaringType, other.DeclaringType) && string.Equals(Name, other.Name) && Equals(Data, other.Data) && GenericArguments.CollectionEquals(other.GenericArguments) && Parameters.CollectionEquals(other.Parameters);`
`24`	`24`	`}`
`25`	`25`
`26`	`26`	`public override bool Equals(object obj) {`
Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ public override string ToString() {`
`27`	`27`	`}`
`28`	`28`
`29`	`29`	`protected bool Equals(Module other) {`
`30`		`- return ModuleId == other.ModuleId && string.Equals(Name, other.Name) && string.Equals(Version, other.Version) && IsEntry == other.IsEntry && CreatedDate.Equals(other.CreatedDate) && ModifiedDate.Equals(other.ModifiedDate) && Data.CollectionEquals(other.Data);`
	`30`	`+ return ModuleId == other.ModuleId && string.Equals(Name, other.Name) && string.Equals(Version, other.Version) && IsEntry == other.IsEntry && CreatedDate.Equals(other.CreatedDate) && ModifiedDate.Equals(other.ModifiedDate) && Equals(Data, other.Data);`
`31`	`31`	`}`
`32`	`32`
`33`	`33`	`public override bool Equals(object obj) {`
Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,7 @@ public Parameter() {`
`15`	`15`	`public GenericArguments GenericArguments { get; set; }`
`16`	`16`
`17`	`17`	`protected bool Equals(Parameter other) {`
`18`		`- return string.Equals(Name, other.Name) && string.Equals(Type, other.Type) && string.Equals(TypeNamespace, other.TypeNamespace) && Data.CollectionEquals(other.Data) && GenericArguments.CollectionEquals(other.GenericArguments);`
	`18`	`+ return string.Equals(Name, other.Name) && string.Equals(Type, other.Type) && string.Equals(TypeNamespace, other.TypeNamespace) && Equals(Data, other.Data) && GenericArguments.CollectionEquals(other.GenericArguments);`
`19`	`19`	`}`
`20`	`20`
`21`	`21`	`public override bool Equals(object obj) {`
Original file line number	Diff line number	Diff line change
`@@ -70,7 +70,7 @@ public RequestInfo() {`
`70`	`70`	`public DataDictionary Data { get; set; }`
`71`	`71`
`72`	`72`	`protected bool Equals(RequestInfo other) {`
`73`		`- return string.Equals(UserAgent, other.UserAgent) && string.Equals(HttpMethod, other.HttpMethod) && IsSecure == other.IsSecure && string.Equals(Host, other.Host) && Port == other.Port && string.Equals(Path, other.Path) && string.Equals(Referrer, other.Referrer) && string.Equals(ClientIpAddress, other.ClientIpAddress) && Cookies.CollectionEquals(other.Cookies) && QueryString.CollectionEquals(other.QueryString) && Data.CollectionEquals(other.Data);`
	`73`	`+ return string.Equals(UserAgent, other.UserAgent) && string.Equals(HttpMethod, other.HttpMethod) && IsSecure == other.IsSecure && string.Equals(Host, other.Host) && Port == other.Port && string.Equals(Path, other.Path) && string.Equals(Referrer, other.Referrer) && string.Equals(ClientIpAddress, other.ClientIpAddress) && Cookies.CollectionEquals(other.Cookies) && QueryString.CollectionEquals(other.QueryString) && Equals(Data, other.Data);`
`74`	`74`	`}`
`75`	`75`
`76`	`76`	`public override bool Equals(object obj) {`
Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ public SimpleError() {`
`32`	`32`	`public SimpleError Inner { get; set; }`
`33`	`33`
`34`	`34`	`protected bool Equals(SimpleError other) {`
`35`		`- return string.Equals(Message, other.Message) && string.Equals(Type, other.Type) && string.Equals(StackTrace, other.StackTrace) && Data.CollectionEquals(other.Data) && Equals(Inner, other.Inner);`
	`35`	`+ return string.Equals(Message, other.Message) && string.Equals(Type, other.Type) && string.Equals(StackTrace, other.StackTrace) && Equals(Data, other.Data) && Equals(Inner, other.Inner);`
`36`	`36`	`}`
`37`	`37`
`38`	`38`	`public override bool Equals(object obj) {`
Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@ public class StackFrame : Method {`
`7`	`7`	`public int Column { get; set; }`
`8`	`8`
`9`	`9`	`protected bool Equals(StackFrame other) {`
`10`		`- return base.Equals(other) && string.Equals(FileName, other.FileName) && LineNumber == other.LineNumber && Column == other.Column;`
	`10`	`+ return base.Equals(other) && string.Equals(FileName, other.FileName);`
`11`	`11`	`}`
`12`	`12`
`13`	`13`	`public override bool Equals(object obj) {`
`@@ -24,8 +24,6 @@ public override int GetHashCode() {`
`24`	`24`	`unchecked {`
`25`	`25`	`int hashCode = base.GetHashCode();`
`26`	`26`	`hashCode = (hashCode * 397) ^ (FileName == null ? 0 : FileName.GetHashCode());`
`27`		`- hashCode = (hashCode * 397) ^ LineNumber.GetHashCode();`
`28`		`- hashCode = (hashCode * 397) ^ Column.GetHashCode();`
`29`	`27`	`return hashCode;`
`30`	`28`	`}`
`31`	`29`	`}`