Fixed an issue where the correct exceptionless client wasn't used for logging

Author: niemyjski

Source/Platforms/WebApi/ExceptionlessHandleErrorAttribute.cs

@@ -10,17 +10,14 @@ namespace Exceptionless.WebApi {
     public class ExceptionlessHandleErrorAttribute : IExceptionFilter {
         private readonly ExceptionlessClient _client;
 
-        public bool HasWrappedFilter { get { return WrappedFilter != null; } }
+        public bool HasWrappedFilter => WrappedFilter != null;
 
         public IExceptionFilter WrappedFilter { get; set; }
-        public bool AllowMultiple { get { return HasWrappedFilter && WrappedFilter.AllowMultiple; } }
 
-        public ExceptionlessHandleErrorAttribute() : this(ExceptionlessClient.Default) {
-            
-        }
+        public bool AllowMultiple => HasWrappedFilter && WrappedFilter.AllowMultiple;
 
-        public ExceptionlessHandleErrorAttribute(ExceptionlessClient client) {
-            _client = client;
+        public ExceptionlessHandleErrorAttribute(ExceptionlessClient client = null) {
+            _client = client ?? ExceptionlessClient.Default;
         }
 
         public virtual void OnHttpException(HttpActionExecutedContext actionExecutedContext, CancellationToken cancellationToken) {
@@ -32,13 +29,13 @@ public virtual void OnHttpException(HttpActionExecutedContext actionExecutedCont
             contextData.SetSubmissionMethod("ExceptionHttpFilter");
             contextData.Add("HttpActionContext", actionExecutedContext.ActionContext);
 
-            actionExecutedContext.Exception.ToExceptionless(contextData, client: _client).Submit();
+            actionExecutedContext.Exception.ToExceptionless(contextData, _client).Submit();
         }
 
         public Task ExecuteExceptionFilterAsync(HttpActionExecutedContext actionExecutedContext, CancellationToken cancellationToken) {
-            ExceptionlessClient.Default.Configuration.Resolver.GetLog().Trace("ExecuteExceptionFilterAsync executing...");
+            _client.Configuration.Resolver.GetLog().Trace("ExecuteExceptionFilterAsync executing...");
             if (actionExecutedContext == null)
-                throw new ArgumentNullException("actionExecutedContext");
+                throw new ArgumentNullException(nameof(actionExecutedContext));
 
             OnHttpException(actionExecutedContext, cancellationToken);
             return TaskExtensions.Completed();

Source/Platforms/WebApi/ExceptionlessWebApiExtensions.cs

@@ -37,9 +37,9 @@ public static void UnregisterWebApi(this ExceptionlessClient client) {
             client.Configuration.RemovePlugin<ExceptionlessWebApiPlugin>();
         }
 
-        private static void ReplaceHttpErrorHandler(HttpConfiguration config, ExceptionlessClient exceptionlessClient) {
+        private static void ReplaceHttpErrorHandler(HttpConfiguration config, ExceptionlessClient client) {
             FilterInfo filter = config.Filters.FirstOrDefault(f => f.Instance is IExceptionFilter);
-            var handler = new ExceptionlessHandleErrorAttribute(exceptionlessClient);
+            var handler = new ExceptionlessHandleErrorAttribute(client);
 
             if (filter != null) {
                 if (filter.Instance is ExceptionlessHandleErrorAttribute)

Source/Platforms/WebApi/ExceptionlessWebApiPlugin.cs

@@ -48,7 +48,7 @@ public void Run(EventPluginContext context) {
 
         private static IPrincipal GetPrincipal(HttpRequestMessage request) {
             if (request == null)
-                throw new ArgumentNullException("request");
+                throw new ArgumentNullException(nameof(request));
 
             const string RequestContextKey = "MS_RequestContext";