Made the UpdateSettingsWhenIdleInterval nullable so we know if you changed the value.

Author: niemyjski

Source/Extras/Extensions/ExceptionlessClientExtensions.cs

@@ -27,6 +27,9 @@ public static void Startup(this ExceptionlessClient client, AppDomain appDomain
             client.Configuration.UseTraceLogEntriesPlugin();
             client.Configuration.AddPlugin<VersionPlugin>();
 
+            if (client.Configuration.UpdateSettingsWhenIdleInterval == null)
+                client.Configuration.UpdateSettingsWhenIdleInterval = TimeSpan.FromMinutes(2);
+
             client.RegisterAppDomainUnhandledExceptionHandler(appDomain);
             client.RegisterTaskSchedulerUnobservedTaskExceptionHandler();
         }

Source/Shared/Configuration/ExceptionlessConfiguration.cs

@@ -22,7 +22,7 @@ public class ExceptionlessConfiguration {
         private string _serverUrl;
         private int _submissionBatchSize;
         private ValidationResult _validationResult;
-        private TimeSpan _updateSettingsWhenIdleInterval;
+        private TimeSpan? _updateSettingsWhenIdleInterval;
         private readonly List<string> _exclusions = new List<string>();
         private readonly List<string> _userAgentBotPatterns = new List<string>();
         private readonly List<Func<Event, bool>> _eventExclusions = new List<Func<Event, bool>>();
@@ -42,7 +42,6 @@ public ExceptionlessConfiguration(IDependencyResolver resolver) {
             DefaultData = new DataDictionary();
             Settings = new SettingsDictionary();
             IncludePrivateInformation = true;
-            _updateSettingsWhenIdleInterval = TimeSpan.FromMinutes(2);
 
             _resolver = resolver;
 
@@ -160,15 +159,15 @@ public string ApiKey {
         /// <summary>
         /// How often the client should check for updated server settings when idle. The default is every 2 minutes. 
         /// </summary>
-        public TimeSpan UpdateSettingsWhenIdleInterval {
+        public TimeSpan? UpdateSettingsWhenIdleInterval {
             get { return _updateSettingsWhenIdleInterval; }
             set {
                 if (_updateSettingsWhenIdleInterval == value)
                     return;
 
-                if (value > TimeSpan.Zero && value < TimeSpan.FromSeconds(15))
+                if (value.HasValue && value > TimeSpan.Zero && value < TimeSpan.FromSeconds(15))
                     _updateSettingsWhenIdleInterval = TimeSpan.FromSeconds(15);
-                else if (value <= TimeSpan.Zero)
+                else if (value.HasValue && value <= TimeSpan.Zero)
                     _updateSettingsWhenIdleInterval = TimeSpan.FromMilliseconds(-1);
                 else
                     _updateSettingsWhenIdleInterval = value;
@@ -472,8 +471,12 @@ public void Dispose() {
         public event EventHandler Changed;
 
         protected virtual void OnChanged() {
+            try {
             if (Changed != null)
                 Changed.Invoke(this, EventArgs.Empty);
+            } catch (Exception ex) {
+                Resolver.GetLog().Error(typeof(ExceptionlessConfiguration), ex, "Error while calling OnChanged event handlers.");
+            }
         }
     }
 }

Source/Shared/ExceptionlessClient.cs

@@ -49,19 +49,21 @@ public ExceptionlessClient(ExceptionlessConfiguration configuration) {
 
             _submissionClient = new Lazy<ISubmissionClient>(() => Configuration.Resolver.GetSubmissionClient());
             _lastReferenceIdManager = new Lazy<ILastReferenceIdManager>(() => Configuration.Resolver.GetLastReferenceIdManager());
-            _updateSettingsTimer = new Timer(state => SettingsManager.UpdateSettings(Configuration), null, GetInitialSettingsDelay(), Configuration.UpdateSettingsWhenIdleInterval);
+            _updateSettingsTimer = new Timer(state => SettingsManager.UpdateSettings(Configuration), null, GetInitialSettingsDelay(), Configuration.UpdateSettingsWhenIdleInterval ?? TimeSpan.FromMilliseconds(-1));
         }
 
         private TimeSpan GetInitialSettingsDelay() {
-            return Configuration.UpdateSettingsWhenIdleInterval > TimeSpan.Zero ? TimeSpan.FromSeconds(5) : TimeSpan.FromMilliseconds(-1);
+            return Configuration.UpdateSettingsWhenIdleInterval != null && Configuration.UpdateSettingsWhenIdleInterval > TimeSpan.Zero ? TimeSpan.FromSeconds(5) : TimeSpan.FromMilliseconds(-1);
         }
 
         private void OnQueueEventsPosted(object sender, EventsPostedEventArgs args) {
-            _updateSettingsTimer.Change(Configuration.UpdateSettingsWhenIdleInterval, Configuration.UpdateSettingsWhenIdleInterval);
+            var interval = Configuration.UpdateSettingsWhenIdleInterval ?? TimeSpan.FromMilliseconds(-1);
+            _updateSettingsTimer.Change(interval, interval);
         }
 
         private void OnConfigurationChanged(object sender, EventArgs e) {
-            _updateSettingsTimer.Change(!_queue.IsValueCreated ? GetInitialSettingsDelay() : Configuration.UpdateSettingsWhenIdleInterval, Configuration.UpdateSettingsWhenIdleInterval);
+            var interval = Configuration.UpdateSettingsWhenIdleInterval ?? TimeSpan.FromMilliseconds(-1);
+            _updateSettingsTimer.Change(!_queue.IsValueCreated ? GetInitialSettingsDelay() : interval, interval);
         }
 
         public ExceptionlessConfiguration Configuration { get; private set; }

Source/Shared/Queue/DefaultEventQueue.cs

@@ -147,7 +147,7 @@ public void SuspendProcessing(TimeSpan? duration = null, bool discardFutureQueue
             if (!duration.HasValue)
                 duration = TimeSpan.FromMinutes(5);
 
-            _log.Info(typeof(ExceptionlessClient), String.Format("Suspending processing for: {0}.", duration.Value));
+            _log.Info(typeof(DefaultEventQueue), String.Format("Suspending processing for: {0}.", duration.Value));
             _suspendProcessingUntil = DateTime.Now.Add(duration.Value);
             _queueTimer.Change(duration.Value, _processQueueInterval);
 
@@ -168,8 +168,12 @@ public void SuspendProcessing(TimeSpan? duration = null, bool discardFutureQueue
         public event EventHandler<EventsPostedEventArgs> EventsPosted;
 
         protected virtual void OnEventsPosted(EventsPostedEventArgs e) {
-            if (EventsPosted != null)
-                EventsPosted.Invoke(this, e);
+            try {
+                if (EventsPosted != null)
+                    EventsPosted.Invoke(this, e);
+            } catch (Exception ex) {
+                _log.Error(typeof(DefaultEventQueue), ex, "Error while calling OnEventsPosted event handlers.");
+            }
         }
 
         private bool IsQueueProcessingSuspended {