Skip to content

Commit cd6402b

Browse files
committed
Updates to session heartbeats
1 parent df5422a commit cd6402b

File tree

3 files changed

+10
-14
lines changed

3 files changed

+10
-14
lines changed

Source/Shared/Plugins/Default/050_EnvironmentInfoPlugin.cs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,9 @@ public void Run(EventPluginContext context) {
1010
if (context.Event.Data.ContainsKey(Event.KnownDataKeys.EnvironmentInfo))
1111
return;
1212

13+
if (!String.IsNullOrEmpty(context.Event.SessionId) && context.Event.IsSessionEnd() || context.Event.IsSessionHeartbeat())
14+
return;
15+
1316
try {
1417
var collector = context.Resolver.GetEnvironmentInfoCollector();
1518
if (collector == null)

Source/Shared/Plugins/Default/100_SessionManagerPlugin.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ public void Run(EventPluginContext context) {
1616
if (String.IsNullOrEmpty(identity))
1717
return;
1818

19-
string sessionId = null;
19+
string sessionId;
2020

2121
if (context.Event.IsSessionStart()) {
2222
sessionId = sessionManager.StartSession(identity);

Source/Shared/Plugins/Default/110 _HeartbeatPlugin.cs

Lines changed: 6 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -13,15 +13,14 @@ public class HeartbeatPlugin : IEventPlugin, IDisposable {
1313
public void Run(EventPluginContext context) {
1414
if (context.Event.IsSessionHeartbeat())
1515
return;
16-
17-
var user = context.Event.GetUserIdentity();
18-
var sessionIdentifier = context.Event.SessionId ?? user?.Identity;
16+
17+
var sessionIdentifier = context.Event.SessionId;
1918
if (String.IsNullOrEmpty(sessionIdentifier))
2019
return;
2120

2221
lock (_lock) {
2322
if (!_sessionHeartbeats.ContainsKey(sessionIdentifier)) {
24-
_sessionHeartbeats.Add(sessionIdentifier, new SessionHeartbeat(context.Event.SessionId, user, context.Client));
23+
_sessionHeartbeats.Add(sessionIdentifier, new SessionHeartbeat(sessionIdentifier, context.Client));
2524
} else if (context.Event.IsSessionEnd()) {
2625
_sessionHeartbeats[sessionIdentifier].Dispose();
2726
_sessionHeartbeats.Remove(sessionIdentifier);
@@ -51,21 +50,15 @@ public SessionHeartbeat(string sessionId, ExceptionlessClient client) {
5150
_client = client;
5251
_timer = new Timer(SendHeartbeat, null, _interval, _interval);
5352
}
54-
55-
public SessionHeartbeat(string sessionId, UserInfo user, ExceptionlessClient client) : this(sessionId, client) {
56-
UserInfo = user;
57-
}
58-
53+
5954
public string SessionId { get; set; }
60-
61-
public UserInfo UserInfo { get; set; }
62-
55+
6356
public void DelayNext() {
6457
_timer.Change(_interval, _interval);
6558
}
6659

6760
private void SendHeartbeat(object state) {
68-
_client.CreateSessionHeartbeat(SessionId).SetUserIdentity(UserInfo?.Identity, UserInfo?.Name).Submit();
61+
_client.SubmitSessionHeartbeat(SessionId);
6962
}
7063

7164
public void Dispose() {

0 commit comments

Comments
 (0)