Skip to content

Commit cff7d29

Browse files
committed
Fixed a bug where the mvc client wasn't unregistering the http application error handler
1 parent 88b8edd commit cff7d29

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

src/Platforms/Exceptionless.Mvc/ExceptionlessModule.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ public virtual void Init(HttpApplication app) {
1717
ExceptionlessClient.Default.Configuration.AddPlugin<ExceptionlessWebPlugin>();
1818
ExceptionlessClient.Default.Configuration.AddPlugin<IgnoreUserAgentPlugin>();
1919
ExceptionlessClient.Default.Configuration.Resolver.Register<ILastReferenceIdManager, WebLastReferenceIdManager>();
20-
20+
2121
_app = app;
2222

2323
if (!GlobalFilters.Filters.Any(f => f.Instance is ExceptionlessSendErrorsAttribute))
@@ -26,7 +26,7 @@ public virtual void Init(HttpApplication app) {
2626

2727
public void Dispose() {
2828
ExceptionlessClient.Default.Shutdown();
29-
ExceptionlessClient.Default.RegisterHttpApplicationErrorHandler(_app);
29+
ExceptionlessClient.Default.UnregisterHttpApplicationErrorHandler(_app);
3030
}
3131
}
3232
}

src/Platforms/Exceptionless.Web/ExceptionlessClientExtensions.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ public static void RegisterHttpApplicationErrorHandler(this ExceptionlessClient
3737
}
3838
}
3939

40-
public static void UnregisterHttpApplicationErrorExceptionHandler(this ExceptionlessClient client, HttpApplication app) {
40+
public static void UnregisterHttpApplicationErrorHandler(this ExceptionlessClient client, HttpApplication app) {
4141
if (client == null)
4242
throw new ArgumentNullException(nameof(client));
4343

src/Platforms/Exceptionless.Web/ExceptionlessModule.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,13 @@ public virtual void Init(HttpApplication app) {
1414
ExceptionlessClient.Default.Configuration.AddPlugin<ExceptionlessWebPlugin>();
1515
ExceptionlessClient.Default.Configuration.AddPlugin<IgnoreUserAgentPlugin>();
1616
ExceptionlessClient.Default.Configuration.Resolver.Register<ILastReferenceIdManager, WebLastReferenceIdManager>();
17-
17+
1818
_app = app;
1919
}
2020

2121
public void Dispose() {
2222
ExceptionlessClient.Default.Shutdown();
23-
ExceptionlessClient.Default.UnregisterHttpApplicationErrorExceptionHandler(_app);
23+
ExceptionlessClient.Default.UnregisterHttpApplicationErrorHandler(_app);
2424
}
2525
}
2626
}

0 commit comments

Comments
 (0)