Make the log4net appender work better.

Author: ejsmith

Source/Platforms/Log4net/ExceptionlessAppender.cs

@@ -4,7 +4,7 @@
 
 namespace Exceptionless.Log4net {
     public class ExceptionlessAppender : AppenderSkeleton {
-        private ExceptionlessClient _client;
+        private ExceptionlessClient _client = ExceptionlessClient.Default;
 
         public string ApiKey { get; set; }
         public string ServerUrl { get; set; }
@@ -18,8 +18,6 @@ public override void ActivateOptions() {
                         config.ServerUrl = ServerUrl;
                     config.UseInMemoryStorage();
                 });
-            else
-                _client = ExceptionlessClient.Default;
         }
 
         protected override void Append(LoggingEvent loggingEvent) {

Source/Platforms/Log4net/ExceptionlessClientExtensions.cs

@@ -16,8 +16,12 @@ public static EventBuilder CreateFromLogEvent(this ExceptionlessClient client, L
                 builder.SetSource(ev.LoggerName);
 
             var props = ev.GetProperties();
-            foreach (var key in props.GetKeys().Where(key => !_ignoredEventProperties.Contains(key, StringComparer.OrdinalIgnoreCase)))
-                builder.SetProperty(key, props[key]);
+            foreach (var key in props.GetKeys().Where(key => !_ignoredEventProperties.Contains(key, StringComparer.OrdinalIgnoreCase))) {
+                string propName = key;
+                if (propName.StartsWith("log4net:"))
+                    propName = propName.Substring(8);
+                builder.SetProperty(propName, props[key]);
+            }
 
             return builder;
         }

Source/Platforms/Log4net/NuGet/readme.txt

@@ -20,10 +20,14 @@ and viewing your project configuration page.
 
 Here is an example log.config file that shows how to use the Exceptionless log4net appender.
 
-<appender name="ExceptionlessAppender" type="Exceptionless.Log4net.ExceptionlessAppender, Exceptionless.Log4net">
+<appender name="exceptionless" type="Exceptionless.Log4net.ExceptionlessAppender,Exceptionless.Log4net" />
+
+By default, the appender will use the settings from the Exceptionless config section, but
+you can also set it on the appender like this:
+
+<appender name="exceptionless" type="Exceptionless.Log4net.ExceptionlessAppender, Exceptionless.Log4net">
     <apiKey value="API_KEY_HERE" />
 </appender>
-
 -------------------------------------
 	  Documentation and Support
 -------------------------------------

Source/Platforms/NLog/NuGet/readme.txt

@@ -18,7 +18,8 @@ and viewing your project configuration page.
 		 NLog Integration
 -------------------------------------
 
-Here is an example NLog.config file that shows how to use the Exceptionless NLog target.
+Here is an example NLog.config file that shows how to use the Exceptionless NLog target. The apiKey attribute
+is optional and will be picked up from your Exceptionless config section by default.
 
 <nlog>
   <extensions>

Source/Samples/SampleConsole/App.config

@@ -2,6 +2,7 @@
 <configuration>
   <configSections>
     <section name="exceptionless" type="Exceptionless.ExceptionlessSection, Exceptionless.Extras"/>
+    <section name="log4net" type="log4net.Config.Log4NetConfigurationSectionHandler,log4net" />
   </configSections>
 
   <exceptionless apiKey="LhhP1C9gijpSKCslHHCvwdSIz298twx271n1l6xw" serverUrl="http://localhost:50000" enableSSL="false" tags="Tag1,Tag2" enableLogging="true">
@@ -18,6 +19,19 @@
     </registrations>-->
   </exceptionless>
 
+  <log4net>
+    <appender name="exceptionless" type="Exceptionless.Log4net.ExceptionlessAppender,Exceptionless.Log4net">
+      <layout type="log4net.Layout.PatternLayout">
+        <conversionPattern value="%-4timestamp [%thread] %-5level %logger %ndc - %message%newline" />
+      </layout>
+    </appender>
+
+    <root>
+      <level value="DEBUG" />
+      <appender-ref ref="exceptionless" />
+    </root>
+  </log4net>
+  
   <startup>
     <supportedRuntime version="v4.0" sku=".NETFramework,Version=v4.5.1"/>
   </startup>

Source/Samples/SampleConsole/Program.cs

@@ -24,6 +24,7 @@
 using Exceptionless.Models;
 using log4net;
 using log4net.Config;
+using log4net.Core;
 using NLog.Fluent;
 
 namespace SampleConsole {
@@ -55,10 +56,13 @@ private static void Main() {
             ExceptionlessClient.Default.Register();
 
             // test NLog
-            Log.Info().Message("Hi").Write();
+            NLog.GlobalDiagnosticsContext.Set("GlobalProp", "GlobalValue");
+            Log.Info().Message("Hi").Property("LocalProp", "LocalValue").Write();
 
             // test log4net
-            BasicConfigurator.Configure(new ExceptionlessAppender());
+            XmlConfigurator.Configure();
+            GlobalContext.Properties["GlobalProp"] = "GlobalValue";
+            ThreadContext.Properties["LocalProp"] = "LocalValue";
             _log4net.Info("Hi");
 
             var tokenSource = new CancellationTokenSource();