Added Extension method for ToBoolean

Author: niemyjski

Source/Shared/Extensions/StringExtensions.cs

@@ -63,7 +63,26 @@ public static bool IsPatternMatch(this string value, string pattern, bool ignore
 
             return value.Equals(pattern);
         }
-        
+
+        public static bool ToBoolean(this string input, bool @default = false) {
+            if (String.IsNullOrEmpty(input))
+                return @default;
+
+            input = input.ToLowerInvariant().Trim();
+
+            bool value;
+            if (bool.TryParse(input, out value))
+                return value;
+
+            if (String.Equals(input, "yes") || String.Equals(input, "1"))
+                return true;
+
+            if (String.Equals(input, "no") || String.Equals(input, "0"))
+                return false;
+
+            return @default;
+        }
+
         public static string ToHex(this IEnumerable<byte> bytes) {
             var sb = new StringBuilder();
             foreach (byte b in bytes)

Source/Shared/Models/Collections/SettingsDictionary.cs

@@ -38,20 +38,8 @@ public bool GetBoolean(string name, bool @default) {
 
             if (String.IsNullOrEmpty(temp))
                 return @default;
-
-            temp = temp.ToLowerInvariant().Trim();
-
-            bool value;
-            if (bool.TryParse(temp, out value))
-                return value;
-
-            if (String.Equals(temp, "yes") || String.Equals(temp, "1"))
-                return true;
 
-            if (String.Equals(temp, "no") || String.Equals(temp, "0"))
-                return false;
-
-            return @default;
+            return temp.ToBoolean(@default);
         }
 
         public int GetInt32(string name) {
@@ -230,11 +218,7 @@ public bool GetTypeAndSourceEnabled(string type, string source) {
                     return sourceEnabled;
             }
 
-            var setting = GetTypeAndSourceSetting(type, source, "true");
-            if (!Boolean.TryParse(setting, out sourceEnabled))
-                sourceEnabled = true;
-
-            return sourceEnabled;
+            return GetTypeAndSourceSetting(type, source, "true").ToBoolean(true);
         }
 
         private readonly Dictionary<string, string> _eventTypes = new Dictionary<string, string>(StringComparer.OrdinalIgnoreCase);