Skip to content

Commit de848c1

Browse files
committed
Respect the IncludePrivateInformation setting set on configuration
Previously this was set to false and then various plugins turned it on. Now we turn it to on and you disable it if you don't want it. (It just controls whether machine name is submitted).
1 parent 619870c commit de848c1

File tree

6 files changed

+3
-6
lines changed

6 files changed

+3
-6
lines changed

Source/Platforms/Mvc/ExceptionlessModule.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ public class ExceptionlessModule : IHttpModule {
1313
public virtual void Init(HttpApplication app) {
1414
ExceptionlessClient.Default.Startup();
1515
ExceptionlessClient.Default.RegisterHttpApplicationErrorHandler(app);
16-
ExceptionlessClient.Default.Configuration.IncludePrivateInformation = true;
1716
ExceptionlessClient.Default.Configuration.AddPlugin<ExceptionlessWebPlugin>();
1817
ExceptionlessClient.Default.Configuration.Resolver.Register<ILastReferenceIdManager, WebLastReferenceIdManager>();
1918

Source/Platforms/Nancy/ExceptionlessNancyExtensions.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ public static class ExceptionlessNancyExtensions {
1919
/// <param name="pipelines">The IPipelines instance.</param>
2020
public static void RegisterNancy(this ExceptionlessClient client, IPipelines pipelines) {
2121
client.Startup();
22-
client.Configuration.IncludePrivateInformation = true;
2322
client.Configuration.AddPlugin<ExceptionlessNancyPlugin>();
2423

2524
pipelines.OnError += OnError;

Source/Platforms/Web/ExceptionlessModule.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ public class ExceptionlessModule : IHttpModule {
1010
public virtual void Init(HttpApplication app) {
1111
ExceptionlessClient.Default.Startup();
1212
ExceptionlessClient.Default.RegisterHttpApplicationErrorHandler(app);
13-
ExceptionlessClient.Default.Configuration.IncludePrivateInformation = true;
1413
ExceptionlessClient.Default.Configuration.AddPlugin<ExceptionlessWebPlugin>();
1514
ExceptionlessClient.Default.Configuration.Resolver.Register<ILastReferenceIdManager, WebLastReferenceIdManager>();
1615

Source/Platforms/WebApi/ExceptionlessWebApiExtensions.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ public static class ExceptionlessWebApiExtensions {
1919
public static void RegisterWebApi(this ExceptionlessClient client, HttpConfiguration config) {
2020
client.Startup();
2121
client.Configuration.AddPlugin<ExceptionlessWebApiPlugin>();
22-
client.Configuration.IncludePrivateInformation = true;
2322

2423
#if WEBAPI21
2524
config.Services.Add(typeof(IExceptionLogger), new ExceptionlessExceptionLogger());

Source/Shared/Configuration/ExceptionlessConfiguration.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ public ExceptionlessConfiguration(IDependencyResolver resolver) {
3535
DefaultTags = new TagSet();
3636
DefaultData = new DataDictionary();
3737
Settings = new SettingsDictionary();
38+
IncludePrivateInformation = true;
3839

3940
_resolver = resolver;
4041

Source/Tests/Plugins/PluginTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,7 @@ public void ShouldUseReferenceIds() {
168168

169169
[Fact]
170170
public void PrivateInformation_WillSetIdentity() {
171-
var client = new ExceptionlessClient(c => c.IncludePrivateInformation = true);
171+
var client = new ExceptionlessClient();
172172
var plugin = new PrivateInformationPlugin();
173173

174174
var context = new EventPluginContext(client, new Event { Type = Event.KnownTypes.Log, Message = "test" });
@@ -180,7 +180,7 @@ public void PrivateInformation_WillSetIdentity() {
180180

181181
[Fact]
182182
public void PrivateInformation_WillNotUpdateIdentity() {
183-
var client = new ExceptionlessClient(c => c.IncludePrivateInformation = true);
183+
var client = new ExceptionlessClient();
184184
var plugin = new PrivateInformationPlugin();
185185

186186
var ev = new Event { Type = Event.KnownTypes.Log, Message = "test" };

0 commit comments

Comments
 (0)