Fixed a bug were ASP.NET Core 404's were not being logged

Author: niemyjski

src/Exceptionless/EventBuilder.cs

@@ -18,7 +18,7 @@ public EventBuilder(Event ev, ExceptionlessClient client = null, ContextData plu
         public ContextData PluginContextData { get; private set; }
 
         public ExceptionlessClient Client { get; set; }
-        
+
         public Event Target { get; private set; }
 
         /// <summary>
@@ -38,7 +38,7 @@ public EventBuilder SetSource(string source) {
             Target.Source = source;
             return this;
         }
-        
+
         /// <summary>
         /// Sets the event reference id.
         /// </summary>
@@ -57,7 +57,7 @@ public EventBuilder SetEventReference(string name, string id) {
             Target.SetEventReference(name, id);
             return this;
         }
-        
+
         /// <summary>
         /// Sets the event message.
         /// </summary>
@@ -132,7 +132,7 @@ public EventBuilder SetProperty(string name, object value, int? maxDepth = null,
         public EventBuilder AddObject(object data, string name = null, int? maxDepth = null, ICollection<string> excludedPropertyNames = null, bool ignoreSerializationErrors = false) {
             if (data != null)
                 Target.AddObject(data, name, maxDepth, excludedPropertyNames, ignoreSerializationErrors);
-            
+
             return this;
         }
 

src/Exceptionless/ExceptionlessClient.cs

@@ -169,7 +169,7 @@ public void SubmitEvent(Event ev, ContextData pluginContextData = null) {
                 _log.Value.Info(typeof(ExceptionlessClient), "Configuration is disabled. The event will not be submitted.");
                 return;
             }
-            
+
             if (!Configuration.IsValid) {
                 _log.Value.FormattedInfo(typeof(ExceptionlessClient), "Configuration is invalid: {0}. The event will not be submitted.", String.Join(", ", Configuration.Validate().Messages));
                 return;

src/Exceptionless/Plugins/Default/010_EventExclusionPlugin.cs

@@ -35,7 +35,7 @@ public void Run(EventPluginContext context) {
                 context.Cancel = true;
                 return;
             }
-            
+
             try {
                 var exception = context.ContextData.GetException();
                 while (exception != null) {

src/Platforms/Exceptionless.AspNetCore/ExceptionlessAspNetCorePlugin.cs

@@ -15,7 +15,7 @@ public void Run(EventPluginContext context) {
             var serializer = context.Client.Configuration.Resolver.GetJsonSerializer();
             if (context.Client.Configuration.IncludePrivateInformation)
                 AddUser(context, httpContext, serializer);
-            
+
             if (httpContext == null)
                 return;
 

src/Platforms/Exceptionless.AspNetCore/ExceptionlessMiddleware.cs

@@ -1,7 +1,6 @@
 using System;
 using System.Threading.Tasks;
 using Microsoft.AspNetCore.Http;
-using Exceptionless;
 using Exceptionless.Plugins;
 
 namespace Exceptionless.AspNetCore {
@@ -13,7 +12,7 @@ public ExceptionlessMiddleware(RequestDelegate next, ExceptionlessClient client)
             _client = client ?? ExceptionlessClient.Default;
             _next = next;
         }
-        
+
         public async Task Invoke(HttpContext context) {
             try {
                 await _next(context);
@@ -26,6 +25,11 @@ public async Task Invoke(HttpContext context) {
                 ex.ToExceptionless(contextData, _client).Submit();
                 throw;
             }
+
+            if (context.Response?.StatusCode == 404) {
+                string path = context.Request.Path.HasValue ? context.Request.Path.Value : "/";
+                _client.CreateNotFound(path).AddRequestInfo(context).Submit();
+            }
         }
     }
 }

src/Platforms/Exceptionless.AspNetCore/RequestInfoCollector.cs

@@ -14,7 +14,7 @@ internal static class RequestInfoCollector {
         public static RequestInfo Collect(HttpContext context, IEnumerable<string> exclusions) {
             if (context == null)
                 return null;
-            
+
             var info = new RequestInfo {
                 ClientIpAddress = context.GetClientIpAddress(),
                 HttpMethod = context.Request.Method,
@@ -89,7 +89,7 @@ private static Dictionary<string, string> ToDictionary(this IRequestCookieCollec
 
         private static Dictionary<string, string> ToDictionary(this IEnumerable<KeyValuePair<string, StringValues>> values, IEnumerable<string> exclusions) {
             var d = new Dictionary<string, string>();
-            
+
             foreach (var kvp in values) {
                 if (String.IsNullOrEmpty(kvp.Key) || kvp.Key.AnyWildcardMatches(_ignoredFormFields) || kvp.Key.AnyWildcardMatches(exclusions))
                     continue;