Skip to content

Commit 4f3c451

Browse files
committed
Added closing of the event drawer and fixed stack traces and code block formatting
1 parent c093cee commit 4f3c451

File tree

10 files changed

+28
-22
lines changed

10 files changed

+28
-22
lines changed

src/Exceptionless.Web/ClientApp/src/lib/features/events/components/EventsDrawer.svelte

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,10 +26,11 @@
2626
2727
interface Props {
2828
changed: (filter: IFilter) => void;
29+
close: () => void;
2930
id: string;
3031
}
3132
32-
let { changed, id }: Props = $props();
33+
let { changed, close, id }: Props = $props();
3334
3435
function getTabs(event?: null | PersistentEvent, project?: ViewProject): TabType[] {
3536
if (!event) {
@@ -100,7 +101,11 @@
100101
activeTab = 'Extended Data';
101102
}
102103
103-
// TODO: Navigate on event deletion.
104+
$effect(() => {
105+
if (eventResponse.isError) {
106+
close();
107+
}
108+
});
104109
</script>
105110

106111
{#if eventResponse.isLoading}

src/Exceptionless.Web/ClientApp/src/lib/features/events/components/ExtendedDataItem.svelte

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -81,9 +81,11 @@
8181
</div>
8282
</div>
8383

84-
{#if showRaw}
85-
<pre class="overflow-auto whitespace-pre-wrap break-words p-2 text-xs"><Code>{json}</Code></pre>
86-
{:else}
87-
<ObjectDump value={filteredData} />
88-
{/if}
84+
<div class="mt-2 flex-grow overflow-auto text-xs">
85+
{#if showRaw}
86+
<pre class="whitespace-pre-wrap break-words rounded bg-muted p-2"><Code class="px-0"><div class="bg-inherit">{json}</div></Code></pre>
87+
{:else}
88+
<ObjectDump value={filteredData} />
89+
{/if}
90+
</div>
8991
{/if}

src/Exceptionless.Web/ClientApp/src/lib/features/events/components/SimpleStackTrace.svelte

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,8 @@
1919
const errors = getErrors(error);
2020
</script>
2121

22-
<pre class="whitespace-pre-wrap break-words border p-2"><Code
23-
><StackTraceHeader {errors}></StackTraceHeader>{#each errors.reverse() as error, index}{#if error.stack_trace}<div class="pl-[10px]">{cleanStackTrace(
24-
error.stack_trace
25-
)}</div>{#if index < errors.length - 1}<div
26-
class="text-muted-foreground">--- End of inner error stack trace ---</div>{/if}{/if}{/each}</Code
22+
<pre class="whitespace-pre-wrap break-words rounded bg-muted p-2"><Code class="px-0"
23+
><StackTraceHeader {errors}></StackTraceHeader>{#each errors.reverse() as error, index}{#if error.stack_trace}<div
24+
class="bg-inherit pl-[10px]">{cleanStackTrace(error.stack_trace)}</div>{#if index < errors.length - 1}<div
25+
class="bg-inherit text-muted-foreground">--- End of inner error stack trace ---</div>{/if}{/if}{/each}</Code
2726
></pre>

src/Exceptionless.Web/ClientApp/src/lib/features/events/components/StackTrace.svelte

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@
1515
const errors = getErrors(error);
1616
</script>
1717

18-
<pre class="whitespace-pre-wrap break-words border p-2"><Code
18+
<pre class="whitespace-pre-wrap break-words rounded bg-muted p-2"><Code class="px-0"
1919
><StackTraceHeader {errors}></StackTraceHeader>{#each errors.reverse() as error, index}{#if error.stack_trace}<div
20-
class="pl-[10px]">{#each error.stack_trace as frame}{getStackFrame(frame)}<br />{/each}{#if index < errors.length - 1}<div
21-
class="text-muted-foreground">--- End of inner exception stack trace ---</div>{/if}</div>{/if}{/each}</Code
20+
class="bg-inherit pl-[10px]">{#each error.stack_trace as frame}{getStackFrame(frame)}<br />{/each}{#if index < errors.length - 1}<div
21+
class="bg-inherit text-muted-foreground">--- End of inner exception stack trace ---</div>{/if}</div>{/if}{/each}</Code
2222
></pre>

src/Exceptionless.Web/ClientApp/src/lib/features/events/components/StackTraceHeader.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
let { errors }: Props = $props();
99
</script>
1010

11-
{#each errors as error, index}<div>
11+
{#each errors as error, index}<div class="bg-inherit">
1212
{#if index > 0}<span class="ml-6">---> </span>{/if}{#if error.type}<span class="mr-1 font-bold">{error.type}:</span
1313
>{/if}{#if error.message}{error.message}{/if}
1414
</div>

src/Exceptionless.Web/ClientApp/src/lib/features/events/components/views/Error.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@
7070
<CopyToClipboardButton title="Copy Stack Trace to Clipboard" value={stackTrace}></CopyToClipboardButton>
7171
</div>
7272
</div>
73-
<div class="mt-2 overflow-auto p-2 text-xs">
73+
<div class="mb-4 mt-2 overflow-auto text-xs">
7474
{#if event.data?.['@error']}
7575
<StackTrace error={event.data['@error']} />
7676
{:else if event.data?.['@simple_error']}

src/Exceptionless.Web/ClientApp/src/lib/features/events/components/views/Overview.svelte

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -271,13 +271,13 @@
271271
{/if}
272272

273273
{#if hasError}
274-
<div class="mb-2 mt-4 flex justify-between">
274+
<div class="mt-4 flex justify-between">
275275
<H4>Stack Trace</H4>
276276
<div class="flex justify-end">
277277
<CopyToClipboardButton title="Copy Stack Trace to Clipboard" value={stackTrace}></CopyToClipboardButton>
278278
</div>
279279
</div>
280-
<div class="mt-2 max-h-[150px] overflow-auto p-2 text-xs">
280+
<div class="mt-2 max-h-[300px] flex-grow overflow-auto text-xs">
281281
{#if event.data?.['@error']}
282282
<StackTrace error={event.data['@error']} />
283283
{:else if event.data?.['@simple_error']}

src/Exceptionless.Web/ClientApp/src/routes/(app)/+page.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,6 +127,6 @@
127127
></Sheet.Title
128128
>
129129
</Sheet.Header>
130-
<EventsDrawer changed={onDrawerFilterChanged} id={selectedEventId || ''}></EventsDrawer>
130+
<EventsDrawer changed={onDrawerFilterChanged} id={selectedEventId || ''} close={() => (selectedEventId = null)}></EventsDrawer>
131131
</Sheet.Content>
132132
</Sheet.Root>

src/Exceptionless.Web/ClientApp/src/routes/(app)/issues/+page.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,6 +121,6 @@
121121
>Event Details <Button href="/event/{eventId}" size="sm" title="Open in new window" variant="ghost"><IconOpenInNew /></Button></Sheet.Title
122122
>
123123
</Sheet.Header>
124-
<EventsDrawer changed={onDrawerFilterChanged} id={eventId || ''}></EventsDrawer>
124+
<EventsDrawer changed={onDrawerFilterChanged} id={eventId || ''} close={() => (selectedStackId = undefined)}></EventsDrawer>
125125
</Sheet.Content>
126126
</Sheet.Root>

src/Exceptionless.Web/ClientApp/src/routes/(app)/stream/+page.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -155,6 +155,6 @@
155155
></Sheet.Title
156156
>
157157
</Sheet.Header>
158-
<EventsDrawer changed={onDrawerFilterChanged} id={selectedEventId || ''}></EventsDrawer>
158+
<EventsDrawer changed={onDrawerFilterChanged} id={selectedEventId || ''} close={() => (selectedEventId = null)}></EventsDrawer>
159159
</Sheet.Content>
160160
</Sheet.Root>

0 commit comments

Comments
 (0)