Updated FluentRest and fixed tests due to new nullable reference types

Author: niemyjski

src/Exceptionless.Web/ClientApp/package-lock.json

@@ -33,7 +33,7 @@
         "@storybook/addon-a11y": "^8.6.2",
         "@storybook/addon-essentials": "^8.6.2",
         "@storybook/addon-interactions": "^8.6.2",
-        "@storybook/addon-svelte-csf": "^5.0.0-next.23",
+        "@storybook/addon-svelte-csf": "^5.0.0-next.26",
         "@storybook/blocks": "^8.6.2",
         "@storybook/svelte": "^8.6.2",
         "@storybook/sveltekit": "^8.6.2",
@@ -92,4 +92,4 @@
         "throttle-debounce": "^5.0.2"
     },
     "type": "module"
-}
+}

src/Exceptionless.Web/ClientApp/package.json

@@ -20,7 +20,7 @@
     <PackageReference Include="MiniValidation" Version="0.9.2" />
     <PackageReference Include="NEST.JsonNetSerializer" Version="7.17.5" />
     <PackageReference Include="OAuth2" Version="0.10.3" />
-    <PackageReference Include="Swashbuckle.AspNetCore" Version="7.3.0" />
+    <PackageReference Include="Swashbuckle.AspNetCore" Version="7.3.1" />
     <PackageReference Include="Serilog.AspNetCore" Version="9.0.0" />
     <PackageReference Include="Serilog.Enrichers.Span" Version="3.1.0" />
     <PackageReference Include="Serilog.Enrichers.Environment" Version="3.0.1" />
@@ -35,7 +35,7 @@
     <PackageReference Include="OpenTelemetry.Instrumentation.ElasticsearchClient" Version="1.0.0-beta.5" />
     <PackageReference Include="OpenTelemetry.Instrumentation.Runtime" Version="1.11.0" />
     <PackageReference Include="OpenTelemetry.Instrumentation.Process" Version="1.10.0-beta.1" />
-    <PackageReference Include="Swashbuckle.AspNetCore.Newtonsoft" Version="7.3.0" />
+    <PackageReference Include="Swashbuckle.AspNetCore.Newtonsoft" Version="7.3.1" />
     <PackageReference Include="Unchase.Swashbuckle.AspNetCore.Extensions" Version="2.7.2" />
   </ItemGroup>
   <ItemGroup Label="Transitive dependency updates to resolve vulnerability warnings">

src/Exceptionless.Web/Exceptionless.Web.csproj

@@ -372,6 +372,7 @@ public async Task CanGetMostFrequentStackMode()
             .StatusCodeShouldBeOk()
         );
 
+        Assert.NotNull(results);
         Assert.Equal(2, results.Count);
     }
 
@@ -392,6 +393,7 @@ public async Task CanGetProjectLevelMostFrequentStackMode()
             .StatusCodeShouldBeOk()
         );
 
+        Assert.NotNull(results);
         Assert.Equal(2, results.Count);
     }
 
@@ -415,6 +417,7 @@ public async Task CanGetFreeProjectLevelMostFrequentStackMode()
             .StatusCodeShouldBeOk()
         );
 
+        Assert.NotNull(results);
         Assert.Equal(2, results.Count);
     }
 
@@ -436,6 +439,7 @@ public async Task CanGetNewStackMode()
             .StatusCodeShouldBeOk()
         );
 
+        Assert.NotNull(results);
         Assert.Equal(2, results.Count);
     }
 
@@ -452,6 +456,7 @@ public async Task GetRecentStackMode()
             .StatusCodeShouldBeOk()
         );
 
+        Assert.NotNull(results);
         Assert.Equal(2, results.Count);
     }
 
@@ -469,6 +474,7 @@ public async Task GetUsersStackMode()
             .StatusCodeShouldBeOk()
         );
 
+        Assert.NotNull(results);
         Assert.Single(results);
     }
 
@@ -492,6 +498,7 @@ await CreateDataAsync(d =>
             .StatusCodeShouldBeOk()
         );
 
+        Assert.NotNull(countResult);
         Assert.Equal(1, countResult.Total);
 
         var results = await SendRequestAsAsync<IReadOnlyCollection<PersistentEvent>>(r => r
@@ -501,13 +508,14 @@ await CreateDataAsync(d =>
             .StatusCodeShouldBeOk()
         );
 
+        Assert.NotNull(results);
         Assert.Single(results);
     }
 
     [Fact]
     public async Task WillGetStackEvents()
     {
-        (var stacks, _) = await CreateDataAsync(d =>
+        var (stacks, _) = await CreateDataAsync(d =>
         {
             d.Event().TestProject();
         });
@@ -522,6 +530,7 @@ public async Task WillGetStackEvents()
             .StatusCodeShouldBeOk()
         );
 
+        Assert.NotNull(result);
         Assert.Single(result);
     }
 
@@ -547,6 +556,7 @@ await CreateDataAsync(d =>
             .StatusCodeShouldBeOk()
         );
 
+        Assert.NotNull(result);
         Assert.Equal(2, result.Count);
 
         result = await SendRequestAsAsync<IReadOnlyCollection<PersistentEvent>>(r => r
@@ -559,6 +569,7 @@ await CreateDataAsync(d =>
             .StatusCodeShouldBeOk()
         );
 
+        Assert.NotNull(result);
         Assert.Equal(2, result.Count);
     }
 
@@ -594,6 +605,7 @@ public async Task CheckStackModeCounts(string filter, int expected)
                 .StatusCodeShouldBeOk()
             );
 
+            Assert.NotNull(results);
             Assert.Equal(expected, results.Count);
 
             // @! forces use of opposite of default filter inversion
@@ -605,6 +617,7 @@ public async Task CheckStackModeCounts(string filter, int expected)
                 .StatusCodeShouldBeOk()
             );
 
+            Assert.NotNull(results);
             Assert.Equal(expected, results.Count);
         }
     }
@@ -638,6 +651,7 @@ public async Task CheckSummaryModeCounts(string filter, int expected)
             .StatusCodeShouldBeOk()
         );
 
+        Assert.NotNull(results);
         Assert.Equal(expected, results.Count);
 
         // @! forces use of opposite of default filter inversion
@@ -649,6 +663,7 @@ public async Task CheckSummaryModeCounts(string filter, int expected)
             .StatusCodeShouldBeOk()
         );
 
+        Assert.NotNull(results);
         Assert.Equal(expected, results.Count);
     }
 
@@ -692,6 +707,7 @@ await CreateDataAsync(d =>
             .StatusCodeShouldBeOk()
         );
 
+        Assert.NotNull(results);
         Assert.Single(results);
 
         var countResult = await SendRequestAsAsync<CountResult>(r => r
@@ -702,6 +718,7 @@ await CreateDataAsync(d =>
             .StatusCodeShouldBeOk()
         );
 
+        Assert.NotNull(countResult);
         var dateAgg = countResult.Aggregations.DateHistogram("date_date");
         double dateAggStackCount = dateAgg.Buckets.Sum(t => t.Aggregations.Cardinality("cardinality_stack").Value.GetValueOrDefault());
         double dateAggEventCount = dateAgg.Buckets.Sum(t => t.Aggregations.Cardinality("sum_count").Value.GetValueOrDefault());
@@ -794,6 +811,7 @@ await CreateDataAsync(d =>
             .StatusCodeShouldBeOk()
         );
 
+        Assert.NotNull(results);
         Assert.Equal(2, results.Count);
 
         _logger.LogInformation("Running normal count");
@@ -807,6 +825,7 @@ await CreateDataAsync(d =>
             .StatusCodeShouldBeOk()
         );
 
+        Assert.NotNull(countResult);
         var dateAgg = countResult.Aggregations.DateHistogram("date_date");
         double dateAggStackCount = dateAgg.Buckets.Sum(t => t.Aggregations.Cardinality("cardinality_stack").Value.GetValueOrDefault());
         double dateAggEventCount = dateAgg.Buckets.Sum(t => t.Aggregations.Cardinality("sum_count").Value.GetValueOrDefault());
@@ -855,6 +874,7 @@ public async Task ShouldRespectEventUsageLimits()
             .StatusCodeShouldBeOk()
         );
 
+        Assert.NotNull(viewOrganization);
         Assert.False(viewOrganization.IsThrottled);
         Assert.False(viewOrganization.IsOverMonthlyLimit);
         Assert.Equal(12, viewOrganization.Usage.Count);
@@ -878,6 +898,7 @@ await SendRequestAsync(r => r
             .StatusCodeShouldBeOk()
         );
 
+        Assert.NotNull(viewOrganization);
         Assert.False(viewOrganization.IsThrottled);
         Assert.False(viewOrganization.IsOverMonthlyLimit);
         Assert.Equal(12, viewOrganization.Usage.Count);
@@ -903,6 +924,7 @@ await SendRequestAsync(r => r
             .StatusCodeShouldBeOk()
         );
 
+        Assert.NotNull(viewOrganization);
         Assert.True(viewOrganization.IsThrottled);
         Assert.False(viewOrganization.IsOverMonthlyLimit);
         var organizationUsage = viewOrganization.GetCurrentUsage(TimeProvider);
@@ -956,6 +978,7 @@ await SendRequestAsync(r => r
             .StatusCodeShouldBeOk()
         );
 
+        Assert.NotNull(viewOrganization);
         Assert.False(viewOrganization.IsThrottled);
         Assert.False(viewOrganization.IsOverMonthlyLimit);
         organizationUsage = viewOrganization.GetCurrentUsage(TimeProvider);
@@ -1099,6 +1122,7 @@ public async Task PlanChangeShouldAllowEventSubmission()
             .StatusCodeShouldBeOk()
         );
 
+        Assert.NotNull(viewOrganization);
         Assert.False(viewOrganization.IsThrottled);
         Assert.False(viewOrganization.IsOverMonthlyLimit);
         Assert.Equal(12, viewOrganization.Usage.Count);
@@ -1135,6 +1159,7 @@ await SendRequestAsync(r => r
             .StatusCodeShouldBeOk()
         );
 
+        Assert.NotNull(viewOrganization);
         Assert.True(viewOrganization.IsThrottled);
         Assert.False(viewOrganization.IsOverMonthlyLimit);
 
@@ -1162,6 +1187,7 @@ await SendRequestAsync(r => r
             .StatusCodeShouldBeOk()
         );
 
+        Assert.NotNull(viewOrganization);
         Assert.False(viewOrganization.IsThrottled);
         Assert.False(viewOrganization.IsOverMonthlyLimit);
 
@@ -1184,6 +1210,7 @@ await SendRequestAsync(r => r
             .StatusCodeShouldBeOk()
         );
 
+        Assert.NotNull(viewOrganization);
         Assert.False(viewOrganization.IsThrottled);
         Assert.False(viewOrganization.IsOverMonthlyLimit);
         var organizationUsage = viewOrganization.GetCurrentUsage(TimeProvider);
@@ -1215,6 +1242,7 @@ await SendRequestAsync(r => r
             .StatusCodeShouldBeOk()
         );
 
+        Assert.NotNull(viewOrganization);
         Assert.True(viewOrganization.IsThrottled);
         Assert.False(viewOrganization.IsOverMonthlyLimit);