Skip to content

Commit d13568b

Browse files
committed
PR Feedback
1 parent ecc6e9c commit d13568b

File tree

10 files changed

+25
-21
lines changed

10 files changed

+25
-21
lines changed

src/Exceptionless.Web/ClientApp/src/lib/features/projects/components/dialogs/remove-project-config-dialog.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
<AlertDialog.Header>
2222
<AlertDialog.Title>Delete Configuration Value</AlertDialog.Title>
2323
<AlertDialog.Description>
24-
Are you sure you want to delete "<span class="truncate max-w-[200px] inline-block align-bottom" title={name}>{name}</span>"?
24+
Are you sure you want to delete "<span class="inline-block max-w-[200px] truncate align-bottom" title={name}>{name}</span>"?
2525
</AlertDialog.Description>
2626
</AlertDialog.Header>
2727
<AlertDialog.Footer>

src/Exceptionless.Web/ClientApp/src/lib/features/projects/components/dialogs/remove-project-dialog.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
<AlertDialog.Header>
2222
<AlertDialog.Title>Delete Project</AlertDialog.Title>
2323
<AlertDialog.Description>
24-
Are you sure you want to delete "<span class="truncate max-w-[200px] inline-block align-bottom" title={name}>{name}</span>"?
24+
Are you sure you want to delete "<span class="inline-block max-w-[200px] truncate align-bottom" title={name}>{name}</span>"?
2525
</AlertDialog.Description>
2626
</AlertDialog.Header>
2727
<AlertDialog.Footer>

src/Exceptionless.Web/ClientApp/src/lib/features/projects/components/dialogs/reset-project-data-dialog.svelte

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@
2121
<AlertDialog.Header>
2222
<AlertDialog.Title>Reset Project Data</AlertDialog.Title>
2323
<AlertDialog.Description>
24-
Are you sure you want to reset all project data for "<span class="truncate max-w-[200px] inline-block align-bottom" title={name}>{name}</span>"? This action cannot be undone and will permanently erase all events, stacks, and
25-
associated data.
24+
Are you sure you want to reset all project data for "<span class="inline-block max-w-[200px] truncate align-bottom" title={name}>{name}</span>"?
25+
This action cannot be undone and will permanently erase all events, stacks, and associated data.
2626
</AlertDialog.Description>
2727
</AlertDialog.Header>
2828
<AlertDialog.Footer>

src/Exceptionless.Web/ClientApp/src/lib/features/webhooks/components/dialogs/remove-webhook-dialog.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
<AlertDialog.Header>
2222
<AlertDialog.Title>Delete Webhook</AlertDialog.Title>
2323
<AlertDialog.Description>
24-
Are you sure you want to delete "<span class="truncate max-w-[200px] inline-block align-bottom" title={url}>{url}</span>"?
24+
Are you sure you want to delete "<span class="inline-block max-w-[200px] truncate align-bottom" title={url}>{url}</span>"?
2525
</AlertDialog.Description>
2626
</AlertDialog.Header>
2727
<AlertDialog.Footer>

src/Exceptionless.Web/ClientApp/src/routes/(app)/(components)/layouts/sidebar-organization-switcher.svelte

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,9 +81,9 @@
8181
<DropdownMenu.Separator />
8282
<DropdownMenu.Item class="gap-2 p-2">
8383
<div class="bg-background flex size-6 items-center justify-center rounded-md border">
84-
<Plus class="size-4" />
84+
<Plus class="size-4" aria-hidden="true" />
8585
</div>
86-
<div class="text-muted-foreground font-medium">Add organization</div>
86+
<span class="text-muted-foreground font-medium">Add organization</span>
8787
</DropdownMenu.Item>
8888
</DropdownMenu.Content>
8989
</DropdownMenu.Root>

src/Exceptionless.Web/ClientApp/src/routes/(app)/project/[projectId]/+layout.svelte

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -33,13 +33,13 @@
3333

3434
<Card.Root>
3535
<Card.Header>
36-
<Card.Title class="text-2xl flex items-center gap-1" level={2}
36+
<Card.Title class="flex items-center gap-1 text-2xl" level={2}
3737
>{#if projectQuery.isSuccess}
38-
<div class="max-w-[70%] overflow-hidden" title={projectQuery.data.name}>
39-
<span class="truncate block">{projectQuery.data.name}</span>
40-
</div>
41-
{/if}
42-
<span class="flex-shrink-0">Settings</span></Card.Title
38+
<div class="max-w-[70%] overflow-hidden" title={projectQuery.data.name}>
39+
<span class="block truncate">{projectQuery.data.name}</span>
40+
</div>
41+
{/if}
42+
<span class="flex-shrink-0">Settings</span></Card.Title
4343
>
4444
<Card.Description>Manage your project settings and integrations.</Card.Description>
4545
<Card.Action>

src/Exceptionless.Web/ClientApp/src/routes/(app)/project/[projectId]/api-keys/+page.svelte

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,8 +82,9 @@
8282
<H3>API Keys</H3>
8383
<Muted>Create and manage API keys for authenticating your applications with Exceptionless.</Muted>
8484
</div>
85-
<Button variant="secondary" size="icon" onclick={addApiKey} title="Add API Key">
86-
<Plus class="size-4" />
85+
<Button size="icon" onclick={addApiKey} title="Add API Key" class="flex-shrink-0">
86+
<Plus class="size-4" aria-hidden="true" />
87+
<span class="sr-only">Add API Key</span>
8788
</Button>
8889
</div>
8990
<Separator />

src/Exceptionless.Web/ClientApp/src/routes/(app)/project/[projectId]/configuration-values/+page.svelte

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,8 +82,9 @@
8282
>
8383
</div>
8484

85-
<Button variant="secondary" size="icon" onclick={() => (showAddProjectConfigDialog = true)} title="Add Configuration Value">
86-
<Plus class="size-4" />
85+
<Button size="icon" onclick={() => (showAddProjectConfigDialog = true)} title="Add Configuration Value" class="flex-shrink-0">
86+
<Plus class="size-4" aria-hidden="true" />
87+
<span class="sr-only">Add Configuration Value</span>
8788
</Button>
8889
</div>
8990
<Separator />

src/Exceptionless.Web/ClientApp/src/routes/(app)/project/[projectId]/integrations/+page.svelte

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -208,8 +208,9 @@
208208
<Muted>The following web hooks will be called for this project.</Muted>
209209
</div>
210210

211-
<Button variant="secondary" size="icon" onclick={() => (showAddWebhookDialog = true)} title="Add Webhook">
212-
<Plus class="size-4" />
211+
<Button size="icon" onclick={() => (showAddWebhookDialog = true)} title="Add Webhook" class="flex-shrink-0">
212+
<Plus class="size-4" aria-hidden="true" />
213+
<span class="sr-only">Add Webhook</span>
213214
</Button>
214215
</div>
215216

src/Exceptionless.Web/ClientApp/src/routes/(app)/project/list/+page.svelte

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,8 +79,9 @@
7979
<Card.Title class="text-2xl" level={2}>My Projects</Card.Title>
8080
<Card.Description>View and manage your projects. Click on a project to view its details.</Card.Description>
8181
<Card.Action>
82-
<Button variant="secondary" size="icon" onclick={addProject} title="Add Project">
83-
<Plus class="size-4" />
82+
<Button size="icon" onclick={addProject} title="Add Project">
83+
<Plus class="size-4" aria-hidden="true" />
84+
<span class="sr-only">Add Project</span>
8485
</Button>
8586
</Card.Action>
8687
</Card.Header>

0 commit comments

Comments
 (0)