FIX: fix solution node titles are links to exercise node

Author: mmcky

sphinx_exercise/post_transforms.py

@@ -147,22 +147,23 @@ def resolve_solution_title(app, node, exercise_node):
             updated_title_text += f" {node_number}"
         # New Title Node
         updated_title = docutil_nodes.title()
-        updated_title += build_reference_node(app, exercise_node)
-        updated_title += docutil_nodes.Text(updated_title_text)
+        wrap_reference = build_reference_node(app, exercise_node)
+        wrap_reference += docutil_nodes.Text(updated_title_text)
         node["title"] = updated_title_text
         # Parse Custom Titles from Exercise
         if len(exercise_title.children) > 1:
             subtitle = exercise_title.children[1]
             if isinstance(subtitle, exercise_subtitle):
-                updated_title += docutil_nodes.Text(" (")
+                wrap_reference += docutil_nodes.Text(" (")
                 for child in subtitle.children:
                     if isinstance(child, docutil_nodes.math):
                         # Ensure mathjax is loaded for pages that only contain
                         # references to nodes that contain math
                         domain = app.env.get_domain("math")
                         domain.data["has_equations"][app.env.docname] = True
-                    updated_title += child
-                updated_title += docutil_nodes.Text(")")
+                    wrap_reference += child
+                wrap_reference += docutil_nodes.Text(")")
+        updated_title += wrap_reference
         updated_title.parent = title.parent
         node.children[0] = updated_title
     node.resolved_title = True

tests/test_solution/_linked_enum.html

@@ -1,5 +1,5 @@
 <div class="solution admonition" id="sol-number">
-<p class="admonition-title"><a class="reference internal" href="#ex-number"></a>Solution to Exercise 6 (This is a title)</p>
+<p class="admonition-title"><a class="reference internal" href="#ex-number">Solution to Exercise 6 (This is a title)</a></p>
 <div class="section" id="solution-content">
 <p>Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua.</p>
 <div class="math notranslate nohighlight">

tests/test_solution/_linked_enum_class.html

@@ -1,5 +1,5 @@
 <div class="solution test-solution admonition" id="solution-label">
-<p class="admonition-title"><a class="reference internal" href="_linked_enum.html#ex-number"></a>Solution to Exercise 6 (This is a title)</p>
+<p class="admonition-title"><a class="reference internal" href="_linked_enum.html#ex-number">Solution to Exercise 6 (This is a title)</a></p>
 <div class="section" id="solution-content">
 <p>Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua.</p>
 </div>

tests/test_solution/_linked_unenum_mathtitle.html

@@ -1,5 +1,5 @@
 <div class="solution admonition" id="sol-nonumber-title-math">
-<p class="admonition-title"><a class="reference internal" href="#ex-nonumber-title-math"></a>Solution to Exercise (This is a title <span class="math notranslate nohighlight">\(\mathbb{R}\)</span>)</p>
+<p class="admonition-title"><a class="reference internal" href="#ex-nonumber-title-math">Solution to Exercise (This is a title <span class="math notranslate nohighlight">\(\mathbb{R}\)</span>)</a></p>
 <div class="section" id="solution-content">
 <p>Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua.</p>
 </div>

tests/test_solution/_linked_unenum_mathtitle2.html

@@ -1,5 +1,5 @@
 <div class="solution admonition" id="sol-nonumber-title-math2">
-<p class="admonition-title"><a class="reference internal" href="#ex-nonumber-title-math2"></a>Solution to Exercise (This is a title <span class="math notranslate nohighlight">\(P_t(x, y) = \mathbb 1\{x = y\} + t Q(x, y) + o(t)\)</span>)</p>
+<p class="admonition-title"><a class="reference internal" href="#ex-nonumber-title-math2">Solution to Exercise (This is a title <span class="math notranslate nohighlight">\(P_t(x, y) = \mathbb 1\{x = y\} + t Q(x, y) + o(t)\)</span>)</a></p>
 <div class="section" id="solution-content">
 <p>Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua.</p>
 </div>

tests/test_solution/_linked_unenum_notitle.html

@@ -1,5 +1,5 @@
 <div class="solution admonition" id="sol-nonumber-notitle">
-<p class="admonition-title"><a class="reference internal" href="#ex-nonumber-notitle"></a>Solution to Exercise</p>
+<p class="admonition-title"><a class="reference internal" href="#ex-nonumber-notitle">Solution to Exercise</a></p>
 <div class="section" id="solution-content">
 <p>Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua.</p>
 </div>

tests/test_solution/_linked_unenum_title.html

@@ -1,5 +1,5 @@
 <div class="solution admonition" id="sol-nonumber-title">
-<p class="admonition-title"><a class="reference internal" href="#ex-nonumber-title"></a>Solution to Exercise (This is a title)</p>
+<p class="admonition-title"><a class="reference internal" href="#ex-nonumber-title">Solution to Exercise (This is a title)</a></p>
 <div class="section" id="solution-content">
 <p>Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua.</p>
 </div>