Skip to content

Commit e5e756b

Browse files
authored
Merge pull request #48 from executablebooks/fix-#12
FIX: Update style for solution titles to agree with #12
2 parents 26c3150 + dbd4ddc commit e5e756b

File tree

7 files changed

+10
-10
lines changed

7 files changed

+10
-10
lines changed

sphinx_exercise/post_transforms.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -139,17 +139,16 @@ def resolve_solution_title(app, node, exercise_node):
139139
title = node.children[0]
140140
exercise_title = exercise_node.children[0]
141141
if isinstance(title, solution_title):
142-
updated_title_text = (
143-
node.get("title") + " " + exercise_title.children[0].astext()
144-
)
142+
entry_title_text = node.get("title")
143+
updated_title_text = " " + exercise_title.children[0].astext()
145144
if isinstance(exercise_node, exercise_enumerable_node):
146145
node_number = get_node_number(app, exercise_node, "exercise")
147146
updated_title_text += f" {node_number}"
148147
# New Title Node
149148
updated_title = docutil_nodes.title()
150149
wrap_reference = build_reference_node(app, exercise_node)
151150
wrap_reference += docutil_nodes.Text(updated_title_text)
152-
node["title"] = updated_title_text
151+
node["title"] = entry_title_text + updated_title_text
153152
# Parse Custom Titles from Exercise
154153
if len(exercise_title.children) > 1:
155154
subtitle = exercise_title.children[1]
@@ -163,6 +162,7 @@ def resolve_solution_title(app, node, exercise_node):
163162
domain.data["has_equations"][app.env.docname] = True
164163
wrap_reference += child
165164
wrap_reference += docutil_nodes.Text(")")
165+
updated_title += docutil_nodes.Text(entry_title_text)
166166
updated_title += wrap_reference
167167
updated_title.parent = title.parent
168168
node.children[0] = updated_title

tests/test_solution/_linked_enum.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<div class="solution admonition" id="sol-number">
2-
<p class="admonition-title"><a class="reference internal" href="#ex-number">Solution to Exercise 6 (This is a title)</a></p>
2+
<p class="admonition-title">Solution to<a class="reference internal" href="#ex-number"> Exercise 6 (This is a title)</a></p>
33
<div class="section" id="solution-content">
44
<p>Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua.</p>
55
<div class="math notranslate nohighlight">

tests/test_solution/_linked_enum_class.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<div class="solution test-solution admonition" id="solution-label">
2-
<p class="admonition-title"><a class="reference internal" href="_linked_enum.html#ex-number">Solution to Exercise 6 (This is a title)</a></p>
2+
<p class="admonition-title">Solution to<a class="reference internal" href="_linked_enum.html#ex-number"> Exercise 6 (This is a title)</a></p>
33
<div class="section" id="solution-content">
44
<p>Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua.</p>
55
</div>

tests/test_solution/_linked_unenum_mathtitle.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<div class="solution admonition" id="sol-nonumber-title-math">
2-
<p class="admonition-title"><a class="reference internal" href="#ex-nonumber-title-math">Solution to Exercise (This is a title <span class="math notranslate nohighlight">\(\mathbb{R}\)</span>)</a></p>
2+
<p class="admonition-title">Solution to<a class="reference internal" href="#ex-nonumber-title-math"> Exercise (This is a title <span class="math notranslate nohighlight">\(\mathbb{R}\)</span>)</a></p>
33
<div class="section" id="solution-content">
44
<p>Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua.</p>
55
</div>

tests/test_solution/_linked_unenum_mathtitle2.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<div class="solution admonition" id="sol-nonumber-title-math2">
2-
<p class="admonition-title"><a class="reference internal" href="#ex-nonumber-title-math2">Solution to Exercise (This is a title <span class="math notranslate nohighlight">\(P_t(x, y) = \mathbb 1\{x = y\} + t Q(x, y) + o(t)\)</span>)</a></p>
2+
<p class="admonition-title">Solution to<a class="reference internal" href="#ex-nonumber-title-math2"> Exercise (This is a title <span class="math notranslate nohighlight">\(P_t(x, y) = \mathbb 1\{x = y\} + t Q(x, y) + o(t)\)</span>)</a></p>
33
<div class="section" id="solution-content">
44
<p>Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua.</p>
55
</div>

tests/test_solution/_linked_unenum_notitle.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<div class="solution admonition" id="sol-nonumber-notitle">
2-
<p class="admonition-title"><a class="reference internal" href="#ex-nonumber-notitle">Solution to Exercise</a></p>
2+
<p class="admonition-title">Solution to<a class="reference internal" href="#ex-nonumber-notitle"> Exercise</a></p>
33
<div class="section" id="solution-content">
44
<p>Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua.</p>
55
</div>

tests/test_solution/_linked_unenum_title.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<div class="solution admonition" id="sol-nonumber-title">
2-
<p class="admonition-title"><a class="reference internal" href="#ex-nonumber-title">Solution to Exercise (This is a title)</a></p>
2+
<p class="admonition-title">Solution to<a class="reference internal" href="#ex-nonumber-title"> Exercise (This is a title)</a></p>
33
<div class="section" id="solution-content">
44
<p>Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua.</p>
55
</div>

0 commit comments

Comments
 (0)